| Message ID | 20250207-pre-ict-jaguar-v5-2-a70819ea0692@cherry.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: minimal support for Pre-ICT tester adapter for RK3588 Jaguar + add overlay tests | expand |
On 2025-02-07 16:19, Quentin Schulz wrote: > From: Quentin Schulz <quentin.schulz@cherry.de> > > The Edgeble NCM6A can have WiFi modules connected and this is handled > via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble > NCM6A WiFi6 Overlay")). > > In order to make sure the overlay is still valid in the future, let's > add a validation test by applying the overlay on top of the main base > at build time. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile > b/arch/arm64/boot/dts/rockchip/Makefile > index > 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e > 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += > rk3568-wolfvision-pf5-vz-2-uhd.dtb > rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ > rk3568-wolfvision-pf5-display-vz.dtbo \ > rk3568-wolfvision-pf5-io-expander.dtbo > + > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb > +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ > + rk3588-edgeble-neu6a-wifi.dtbo Looking good to me, thanks for the patch! It was already discussed and commented in detail in the v4 of this series, [*] so please feel free to include: Reviewed-by: Dragan Simic <dsimic@manjaro.org> [*] https://lore.kernel.org/linux-rockchip/a3b98e3d3a2571ee75e59418bb3b6960@manjaro.org/T/#u
On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> wrote: > > From: Quentin Schulz <quentin.schulz@cherry.de> > > The Edgeble NCM6A can have WiFi modules connected and this is handled > via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble > NCM6A WiFi6 Overlay")). > > In order to make sure the overlay is still valid in the future, let's > add a validation test by applying the overlay on top of the main base > at build time. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > --- > arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb > rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ > rk3568-wolfvision-pf5-display-vz.dtbo \ > rk3568-wolfvision-pf5-io-expander.dtbo > + > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb > +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ > + rk3588-edgeble-neu6a-wifi.dtbo Please add neu6b-io as well, wifi dtbo is similar for it as well. Thanks, Jagan.
Hi Jagan, On 2/10/25 3:11 PM, Jagan Teki wrote: > On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> wrote: >> >> From: Quentin Schulz <quentin.schulz@cherry.de> >> >> The Edgeble NCM6A can have WiFi modules connected and this is handled >> via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble >> NCM6A WiFi6 Overlay")). >> >> In order to make sure the overlay is still valid in the future, let's >> add a validation test by applying the overlay on top of the main base >> at build time. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> >> --- >> arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile >> index 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e 100644 >> --- a/arch/arm64/boot/dts/rockchip/Makefile >> +++ b/arch/arm64/boot/dts/rockchip/Makefile >> @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb >> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ >> rk3568-wolfvision-pf5-display-vz.dtbo \ >> rk3568-wolfvision-pf5-io-expander.dtbo >> + >> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb >> +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ >> + rk3588-edgeble-neu6a-wifi.dtbo > > Please add neu6b-io as well, wifi dtbo is similar for it as well. > Similar or identical :)? Should the overlay be renamed if it applies to neu6b AND neu6a instead of implying it's only for neu6a based on the name of the overlay? Cheers, Quentin
Hello Quentin and Jagan, On 2025-02-10 18:57, Quentin Schulz wrote: > On 2/10/25 3:11 PM, Jagan Teki wrote: >> On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> >> wrote: >>> >>> From: Quentin Schulz <quentin.schulz@cherry.de> >>> >>> The Edgeble NCM6A can have WiFi modules connected and this is handled >>> via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add >>> Edgeble >>> NCM6A WiFi6 Overlay")). >>> >>> In order to make sure the overlay is still valid in the future, let's >>> add a validation test by applying the overlay on top of the main base >>> at build time. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> >>> --- >>> arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile >>> b/arch/arm64/boot/dts/rockchip/Makefile >>> index >>> 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e >>> 100644 >>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>> @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += >>> rk3568-wolfvision-pf5-vz-2-uhd.dtb >>> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ >>> rk3568-wolfvision-pf5-display-vz.dtbo \ >>> rk3568-wolfvision-pf5-io-expander.dtbo >>> + >>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb >>> +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ >>> + rk3588-edgeble-neu6a-wifi.dtbo >> >> Please add neu6b-io as well, wifi dtbo is similar for it as well. > > Similar or identical :)? > > Should the overlay be renamed if it applies to neu6b AND neu6a instead > of implying it's only for neu6a based on the name of the overlay? I'm afraid it's a bit too late for renaming the .dtso file. :/ Though, the DT overlay tests could also serve as some kind of documentation about what overlay can get applied to what base .dtb, making this situation a bit better.
Hi Dragan, On 2/10/25 7:29 PM, Dragan Simic wrote: > Hello Quentin and Jagan, > > On 2025-02-10 18:57, Quentin Schulz wrote: >> On 2/10/25 3:11 PM, Jagan Teki wrote: >>> On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> >>> wrote: >>>> >>>> From: Quentin Schulz <quentin.schulz@cherry.de> >>>> >>>> The Edgeble NCM6A can have WiFi modules connected and this is handled >>>> via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble >>>> NCM6A WiFi6 Overlay")). >>>> >>>> In order to make sure the overlay is still valid in the future, let's >>>> add a validation test by applying the overlay on top of the main base >>>> at build time. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> >>>> --- >>>> arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/ >>>> boot/dts/rockchip/Makefile >>>> index >>>> 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>> @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568- >>>> wolfvision-pf5-vz-2-uhd.dtb >>>> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ >>>> rk3568-wolfvision-pf5-display-vz.dtbo \ >>>> rk3568-wolfvision-pf5-io-expander.dtbo >>>> + >>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb >>>> +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ >>>> + rk3588-edgeble-neu6a-wifi.dtbo >>> >>> Please add neu6b-io as well, wifi dtbo is similar for it as well. >> >> Similar or identical :)? >> >> Should the overlay be renamed if it applies to neu6b AND neu6a instead >> of implying it's only for neu6a based on the name of the overlay? > > I'm afraid it's a bit too late for renaming the .dtso file. :/ How is it too late? Is there some rule somewhere about renaming I missed? Cheers, Quentin
Hi Quentin, On Mon, 10 Feb 2025 at 23:27, Quentin Schulz <quentin.schulz@cherry.de> wrote: > > Hi Jagan, > > On 2/10/25 3:11 PM, Jagan Teki wrote: > > On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> wrote: > >> > >> From: Quentin Schulz <quentin.schulz@cherry.de> > >> > >> The Edgeble NCM6A can have WiFi modules connected and this is handled > >> via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add Edgeble > >> NCM6A WiFi6 Overlay")). > >> > >> In order to make sure the overlay is still valid in the future, let's > >> add a validation test by applying the overlay on top of the main base > >> at build time. > >> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> > >> --- > >> arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > >> index 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e 100644 > >> --- a/arch/arm64/boot/dts/rockchip/Makefile > >> +++ b/arch/arm64/boot/dts/rockchip/Makefile > >> @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb > >> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ > >> rk3568-wolfvision-pf5-display-vz.dtbo \ > >> rk3568-wolfvision-pf5-io-expander.dtbo > >> + > >> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb > >> +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ > >> + rk3588-edgeble-neu6a-wifi.dtbo > > > > Please add neu6b-io as well, wifi dtbo is similar for it as well. > > > > Similar or identical :)? > > Should the overlay be renamed if it applies to neu6b AND neu6a instead > of implying it's only for neu6a based on the name of the overlay? Similar. that overlay is applicable for neu6a-io and neu6b-io both. Thanks, Jagan.
Hello Quentin, On 2025-02-11 13:59, Quentin Schulz wrote: > On 2/10/25 7:29 PM, Dragan Simic wrote: >> On 2025-02-10 18:57, Quentin Schulz wrote: >>> On 2/10/25 3:11 PM, Jagan Teki wrote: >>>> On Fri, 7 Feb 2025 at 20:50, Quentin Schulz <foss+kernel@0leil.net> >>>> wrote: >>>>> >>>>> From: Quentin Schulz <quentin.schulz@cherry.de> >>>>> >>>>> The Edgeble NCM6A can have WiFi modules connected and this is >>>>> handled >>>>> via an overlay (commit 951d6aaa37fe ("arm64: dts: rockchip: Add >>>>> Edgeble >>>>> NCM6A WiFi6 Overlay")). >>>>> >>>>> In order to make sure the overlay is still valid in the future, >>>>> let's >>>>> add a validation test by applying the overlay on top of the main >>>>> base >>>>> at build time. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de> >>>>> --- >>>>> arch/arm64/boot/dts/rockchip/Makefile | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/ >>>>> boot/dts/rockchip/Makefile >>>>> index >>>>> 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e >>>>> 100644 >>>>> --- a/arch/arm64/boot/dts/rockchip/Makefile >>>>> +++ b/arch/arm64/boot/dts/rockchip/Makefile >>>>> @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568- >>>>> wolfvision-pf5-vz-2-uhd.dtb >>>>> rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb >>>>> \ >>>>> rk3568-wolfvision-pf5-display-vz.dtbo \ >>>>> rk3568-wolfvision-pf5-io-expander.dtbo >>>>> + >>>>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb >>>>> +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ >>>>> + rk3588-edgeble-neu6a-wifi.dtbo >>>> >>>> Please add neu6b-io as well, wifi dtbo is similar for it as well. >>> >>> Similar or identical :)? >>> >>> Should the overlay be renamed if it applies to neu6b AND neu6a >>> instead >>> of implying it's only for neu6a based on the name of the overlay? >> >> I'm afraid it's a bit too late for renaming the .dtso file. :/ > > How is it too late? Is there some rule somewhere about renaming I > missed? The way I see it, names of the .dts and .dtso files become part of the "extended ABI", so to speak, once they've been accepted upstream for a while, because renaming them may break boot configurations.
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile index 534e70a649eeada7f9b6f12596b83f5c47b184b4..02f98abe1df10f44f2ac27ea5f6c6e6c6334724e 100644 --- a/arch/arm64/boot/dts/rockchip/Makefile +++ b/arch/arm64/boot/dts/rockchip/Makefile @@ -192,3 +192,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \ rk3568-wolfvision-pf5-display-vz.dtbo \ rk3568-wolfvision-pf5-io-expander.dtbo + +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb +rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \ + rk3588-edgeble-neu6a-wifi.dtbo