From patchwork Fri Mar 14 03:38:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Yan X-Patchwork-Id: 14016183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11720C35FF3 for ; Fri, 14 Mar 2025 03:40:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NEj72eu6aBW2Q/+4/p5zlW4nHed/Au0lvzfn3BPuJGo=; b=3/Cn5OCNwV7rYg /X4Qh1yb7b/8ZVS0yV8ZoiX/JxzVBlv53i8syTvdLS7G5mhyeDU1t2kEJsjsWpwfi9s3uRuu5Zgqy vc4vF9k/y19GJHV+qkoBZkKmJVI8enRPDd1AjPfg0x6Uy0CWmsk24/f04+djis8Su1eliGDJ2fhtq S9ojEOjMcUVZbhTVLeeQFR0Hu6hDrNtJbQloqrHFv8NdNPS7xzZ0p0Ossi41/MSwiSYEA4NN2E63G nG65Q9N/3BP+om7a/5U1E2eNaBZKZXOYxxxpN6kD7fiXxauqrhQDpN9uZsuCazyY1gizXtZSg7cg2 b2x/YfZT+xVdf4XgmrwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsvu7-0000000D0zb-2BkQ; Fri, 14 Mar 2025 03:40:11 +0000 Received: from m16.mail.163.com ([117.135.210.2]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsvtd-0000000D0vW-3Jbi for linux-rockchip@lists.infradead.org; Fri, 14 Mar 2025 03:39:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=dejPp TW6xI9LsiYWdXKjg58ofBjcFaN80CbDlQAoGus=; b=PidKvtsS7zVgpIjN5puAf ljoSSHTsAJJo4tZTzR9pzv0v5AGBllOkQNT/VxopUiCCFpKniUtUH6iZU7zMNK87 eGp74hZIydEVRNhP/dXKEgRI668n45PvONtXxvEGNZbbgVwHRelPour/wK2qX2T5 n8Ky6Ozr0YtKs4iQauFdYA= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g0-0 (Coremail) with SMTP id _____wC3bE_SpNNn4bIfSw--.42501S4; Fri, 14 Mar 2025 11:39:06 +0800 (CST) From: Andy Yan To: lumag@kernel.org Cc: mripard@kernel.org, neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, jani.nikula@intel.com, lyude@redhat.com, jonathanh@nvidia.com, thierry.reding@gmail.com, victor.liu@nxp.com, rfoss@kernel.org, linux-rockchip@lists.infradead.org, Andy Yan Subject: [PATCH 3/5] drm/bridge: anx6345: Switch to common helpers to power up/down dp link Date: Fri, 14 Mar 2025 11:38:42 +0800 Message-ID: <20250314033856.538352-3-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250314033856.538352-1-andyshrk@163.com> References: <20250314033856.538352-1-andyshrk@163.com> MIME-Version: 1.0 X-CM-TRANSID: _____wC3bE_SpNNn4bIfSw--.42501S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cr4ktrykZw1UGr4rGr4rZrb_yoW8Ww48pr 1fC342qr1a9wnYqrs0kF10gFs8Z34DW395GrWUCw4ku3WUCFnFy34Sy34fJas5XrykAa1j qF1DJ3srXFy0vw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jVUDJUUUUU= X-Originating-IP: [58.22.7.114] X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiqBIQXmfTozEwRQAAsn X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250313_203942_203791_19AF71AC X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Andy Yan Use the common dp link power up/down helpers to avoid duplicating code. Signed-off-by: Andy Yan Reviewed-by: Dmitry Baryshkov --- .../drm/bridge/analogix/analogix-anx6345.c | 30 +------------------ 1 file changed, 1 insertion(+), 29 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c index 83d711ee3a2e..f4fffe4bbb30 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c @@ -143,35 +143,7 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345) if (err) return err; - /* - * Power up the sink (DP_SET_POWER register is only available on DPCD - * v1.1 and later). - */ - if (anx6345->dpcd[DP_DPCD_REV] >= 0x11) { - err = drm_dp_dpcd_readb(&anx6345->aux, DP_SET_POWER, &dpcd[0]); - if (err < 0) { - DRM_ERROR("Failed to read DP_SET_POWER register: %d\n", - err); - return err; - } - - dpcd[0] &= ~DP_SET_POWER_MASK; - dpcd[0] |= DP_SET_POWER_D0; - - err = drm_dp_dpcd_writeb(&anx6345->aux, DP_SET_POWER, dpcd[0]); - if (err < 0) { - DRM_ERROR("Failed to power up DisplayPort link: %d\n", - err); - return err; - } - - /* - * According to the DP 1.1 specification, a "Sink Device must - * exit the power saving state within 1 ms" (Section 2.5.3.1, - * Table 5-52, "Sink Control Field" (register 0x600). - */ - usleep_range(1000, 2000); - } + drm_dp_link_power_up(&anx6345->aux, anx6345->dpcd[DP_DPCD_REV]); /* Possibly enable downspread on the sink */ err = regmap_write(anx6345->map[I2C_IDX_DPTX],