diff mbox

regulator: fan53555: fix wrong cast in probe

Message ID 2443447.AFyh6VXdN9@diego (mailing list archive)
State New, archived
Headers show

Commit Message

Heiko Stübner Sept. 17, 2014, 11:21 a.m. UTC 
The vendor-id gathered from the dt match-data was cast to int but assigned
to an unsigned long, producing warnings on at least sparc, like

   drivers/regulator/fan53555.c: In function 'fan53555_regulator_probe':
>> drivers/regulator/fan53555.c:373:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      di->vendor = (int) match->data;

Fix this by using an appropriate cast.

Reported-by: kbuild test robot
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/regulator/fan53555.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Sept. 17, 2014, 4:49 p.m. UTC | #1 
On Wed, Sep 17, 2014 at 01:21:48PM +0200, Heiko Stübner wrote:
> The vendor-id gathered from the dt match-data was cast to int but assigned
> to an unsigned long, producing warnings on at least sparc, like

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c
index f2f5535..6ca6e26 100644
--- a/drivers/regulator/fan53555.c
+++ b/drivers/regulator/fan53555.c
@@ -370,7 +370,7 @@  static int fan53555_regulator_probe(struct i2c_client *client,
 		if (!match)
 			return -ENODEV;
 
-		di->vendor = (int) match->data;
+		di->vendor = (unsigned long) match->data;
 	} else {
 		/* if no ramp constraint set, get the pdata ramp_delay */
 		if (!di->regulator->constraints.ramp_delay) {