From patchwork Wed Jan 13 08:10:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 8023311 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 61D029F2F4 for ; Wed, 13 Jan 2016 08:11:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7D2D12041A for ; Wed, 13 Jan 2016 08:11:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A39D7203F3 for ; Wed, 13 Jan 2016 08:11:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aJGWa-0000VR-Pn; Wed, 13 Jan 2016 08:11:24 +0000 Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aJGWR-0000S6-9w; Wed, 13 Jan 2016 08:11:16 +0000 Received: by mail-pa0-x243.google.com with SMTP id yy13so26751569pab.1; Wed, 13 Jan 2016 00:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=+0xi6f0kTNLnI5T7je7MmHr+Yzs6xjijeb4IZzLCLvI=; b=EW32uqqvc9+RrHzV80aosVXnaiw8miSjicRPkvog+/pyuPpKg3OiA+zL6bdi0zh0uS wT5oa8M2LBDzkQGPYiuxnMmf61CeAeulZdYwg83/xUS9pLZM3WgJLE4xkv1u3No/Oo// QAIHgTEPdROzg/RKy7U1F+TjUDGnzwkfPJpW48rrHoBEp2n9FNU5YFfdvAVij1TUz95c G6Qv5mSc82dZOX11toVodyJEtzxY13Mh6RSuNsd8qpXCwwGTbIi+Rndx8Gs9UWOISSLV F7eomlwSUi5DC+eMnYx1LirkEoygd+qbl8dl+H4uIW2zPPv9NlJKFdhPGc/uH/tNsaCl Su9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=+0xi6f0kTNLnI5T7je7MmHr+Yzs6xjijeb4IZzLCLvI=; b=LeGufjPUVt5yozZ/HMWWTNDEiM0Np6uxG503Xc/2XTkoEJf1jk01jb+sUGlSaUYkVk y1+X+vSApEwd/wD6b8oP1lviiETY8A4qfvI+B8cS4az7iT+NZPTxJRcImAorFG7kfdfo dOplk9xPN7Y3YPKyJkM2iMAgnxsVcQWWrMeVtaBxk2zVxJWwaI+dgqJwmYM/dLB8nZpk i4/o6rkd7jO7ZNwzT1+JjvOb5ppIF++19d0ZNN2ifmiLUU8PMcQg3CCepdVaOlmX9CeL dyBLcNIlEM4lA5BVUIGt6JRkwu6m9UN+N7zdu22GqMhpCxQR/NGDouAQn8Kud5z8osaW kNwQ== X-Gm-Message-State: ALoCoQlxA5fapWHTR9qGjOKHZMTTB5kah9zpZW27ga9GPF5/904LQ4EDKon5MHePmKp4r8BaSky1D+2jLXl7+q3Sj39t7ZH7vA== X-Received: by 10.66.161.227 with SMTP id xv3mr22607136pab.117.1452672653119; Wed, 13 Jan 2016 00:10:53 -0800 (PST) Received: from [192.168.1.100] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id 11sm396546pfq.87.2016.01.13.00.10.48 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 13 Jan 2016 00:10:51 -0800 (PST) Subject: Re: [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out To: Heiko Stuebner References: <1452155155-16232-1-git-send-email-wxt@rock-chips.com> <290434099.8XFZ9qmNRz@phil> <568F80BA.6060209@gmail.com> <20757797.djuaztrzGE@phil> From: Caesar Wang Message-ID: <56960686.7030903@gmail.com> Date: Wed, 13 Jan 2016 16:10:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20757797.djuaztrzGE@phil> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160113_001115_420401_82513CCF X-CRM114-Status: GOOD ( 14.47 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Caesar Wang , Ulf Hansson , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, leecam@google.com, linux-arm-kernel@lists.infradead.org, keescook@google.com, linux-clk@vger.kernel.org, leozwang@google.com, Caesar Wang Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Heiko, ? 2016?01?08? 17:46, Heiko Stuebner ??: > Hi Caesar, > > Am Freitag, 8. Januar 2016, 17:26:18 schrieb Caesar Wang: >> ? 2016?01?07? 18:05, Heiko Stuebner ??: >>> Am Donnerstag, 7. Januar 2016, 16:25:47 schrieb Caesar Wang: >>>> SCLk_I2S_OUT is the noc bus clock for i2s module, this clock is used by >>>> extra codecs. >>>> >>>> Due to it shouldn't belong to any driver, but we need it enabled, >>>> so just mark it as the CLK_IGNORE_UNUSED flag. >>> What makes you think it shouldn't belong to any driver? >>> >>> In most schematics I have, i2s_clkout is going to some clock-input of >>> the >>> audio codec - probably the MCLK input on your rt5616. And while the new >>> rt5616 driver does not seem to do clock handling, it should just handle >>> the clock using the normal APIs. >> You are right, that's seem has to find the root cause. >> I'm wonder that the codec/i2s is working in kernel v4.1 patch without it. >> >> In general, the MLCK will be handled in i2s driver if the cpu side is >> master. > looking at the rt5616 datasheet, that would be BCLK1 instead I think. This > one does differentiate between being master/slave. > > The master/sysclk (mclk) is also handled in other drivers in all cases. > (da7213.c, da7219.c, max98090.c, max98095.c, probably more) Saw the patch: https://patchwork.kernel.org/patch/5427131/ Add the follow that's working. > > > Heiko > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip --- a/arch/arm/boot/dts/rk3036.dtsi +++ b/arch/arm/boot/dts/rk3036.dtsi @@ -288,8 +288,8 @@ interrupts = ; #address-cells = <1>; #size-cells = <0>; - clock-names = "i2s_clk", "i2s_hclk"; - clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>; + clock-names = "i2s_clk", "i2s_hclk", "i2s_clk_out"; + clocks = <&cru SCLK_I2S>, <&cru HCLK_I2S>, <&cru SCLK_I2S_OUT>; Okay, I believe Mark likes that works in codec driver.