From patchwork Thu Mar 24 15:09:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Finley Xiao X-Patchwork-Id: 8662151 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BD72CC0553 for ; Thu, 24 Mar 2016 15:09:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D1124203B4 for ; Thu, 24 Mar 2016 15:09:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAA79203A0 for ; Thu, 24 Mar 2016 15:09:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aj6t2-00080K-Vp; Thu, 24 Mar 2016 15:09:24 +0000 Received: from regular1.263xmail.com ([211.150.99.137]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aj6ss-0007nW-4L; Thu, 24 Mar 2016 15:09:15 +0000 Received: from xf?rock-chips.com (unknown [192.168.167.110]) by regular1.263xmail.com (Postfix) with SMTP id 0A240B572; Thu, 24 Mar 2016 23:08:44 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 Received: from [172.16.12.15] (localhost.localdomain [127.0.0.1]) by smtp.263.net (Postfix) with ESMTP id 8E3ED280C9; Thu, 24 Mar 2016 23:08:37 +0800 (CST) X-RL-SENDER: xf@rock-chips.com X-FST-TO: huangtao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: xf@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-SENDER: xf@rock-chips.com X-DNS-TYPE: 0 Received: from [172.16.12.15] (unknown [58.22.7.114]) by smtp.263.net (Postfix) whith ESMTP id 32575EI2ZUH; Thu, 24 Mar 2016 23:08:38 +0800 (CST) Subject: Re: [PATCH v2] cpufreq: rockchip: add driver To: Viresh Kumar , Feng Xiao References: <1458647848-48999-1-git-send-email-xf@rock-chips.com> <1458699487-58470-1-git-send-email-xf@rock-chips.com> <20160323044033.GQ5272@vireshk-i7> <56F35894.3020106@rock-chips.com> <20160324064324.GG22062@vireshk-i7> From: Finley Xiao Message-ID: <56F40328.5090001@rock-chips.com> Date: Thu, 24 Mar 2016 23:09:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160324064324.GG22062@vireshk-i7> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160324_080914_643478_BA5C678A X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.6 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, tim.chen@rock-chips.com, linux@arm.linux.org.uk, heiko@sntech.de, linux-pm@vger.kernel.org, xxx@rock-chips.com, rjw@rjwysocki.net, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, zyw@rock-chips.com, jay.xu@rock-chips.com, linux-arm-kernel@lists.infradead.org, wxt@rock-chips.com Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Viresh, can we add a of_match_table with a common compatible name as follows ? + cpufreq { + compatible = "***,***"; + } Does it create a DT node for a dummy device too ? ? 2016/3/24 14:43, Viresh Kumar ??: > On 24-03-16, 11:01, Feng Xiao wrote: >> hi all, >> I found that it could match the cpufreq-dt driver succesfully only with >> the following changes. >> --- a/arch/arm64/boot/dts/rockchip/rk3366.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3366.dtsi >> @@ -139,6 +139,10 @@ >> }; >> }; >> >> + cpufreq-dt { //the node name must be cpufreq-dt >> + compatible = "rockchip,cpufreq"; // the compatible name is >> insignificant >> + }; >> + > Its not allowed to create a DT node for a dummy device and so we never > followed this way. > > I have just sent a patchset and cc'd you: > "[PATCH 0/3] cpufreq: dt: Create platform device from generic code" > > and so this patch shall get replaced now. > --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -470,10 +470,16 @@ static int dt_cpufreq_remove(struct platform_device *pdev) cpufreq_unregister_driver(&dt_cpufreq_driver); return 0; } +static const struct of_device_id dt_cpufreq_of_match[] = { + { .compatible = "***,***", }, + { } +}; +MODULE_DEVICE_TABLE(of, dt_cpufreq_of_match); static struct platform_driver dt_cpufreq_platdrv = { .driver = { .name = "cpufreq-dt", + .of_match_table = dt_cpufreq_of_match, }, --- a/arch/arm64/boot/dts/rockchip/rk3366.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3366.dtsi