From patchwork Wed Dec 6 11:44:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13481587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14DEEC4167B for ; Wed, 6 Dec 2023 11:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jsntp9b6lhaYcmIG5yxFEwYGS87EwkTfnPBidQFAiew=; b=witgLRxQNfV+0z LuMoJMEAvf3/8VpyLXAOLQfeoz49HAbQ64B1CA7833IGH5G6AbBcwwDqSlKMOum5Zo3EP9yrWlySH td2OaoW3dR/jWPxBlR4U6pp12cPYVorWUNpYzR4nhA0/lq8m7h94ywqO/iYJzhw+pkF7xa0SOb5ki zvrLdAJwtbjf+6R4mQMWyTAy0Ak0ZIdN4mbtZBIytGKaeIjRR6BkBmUE7fWzaRQ5mVzwmVpax3r9y G31iOSD2NVgmJkR77hQHGNT1QfPmGEMQQb/MKK1KAIwEE92e+cXMY0ndSh6Ot22CLF1Lu1FhW1g9Z STjMDDLy1zuox0VPqj1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAqPn-00A7ef-0F; Wed, 06 Dec 2023 11:50:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAqOT-00A6MZ-0w for linux-rockchip@bombadil.infradead.org; Wed, 06 Dec 2023 11:48:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=TzfasbkGyDvNfRcHywl8JXqjm5rOYFrymrqw1WeQHGc=; b=RjKidYecoyv7FTxyH0eOf2K89a k9RMapG7TGvuOtABTMJ+1hhzipKvk5IDBpBwfaxNdU0KufUGNiE2PLvrm1eI+2x2hCCgFEOeACDsK QU5COKh7WFJn1L3x5T4Oh++ZBbpqqOpanLSSQgAMgVPhn9T3QMxMFKZU0XOz9KT0YLgFfGBK3mcfw IFpr7W9QitAl7wp5LlKozh9RdZ37jllMANNI7M2LhUWbx8BOssdIVb35X1KVxDYRKWlphWdBJai1k 07zSLvB0AtPRC4iEKLxsJYQhERPCjyneMammFf3nEalbYbhwsAsPwyG91dz/TSPGUEqRIQyKMYPTc uWXu0j2Q==; Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAqOP-0059Vr-34 for linux-rockchip@lists.infradead.org; Wed, 06 Dec 2023 11:48:44 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAqOK-0007HD-V6; Wed, 06 Dec 2023 12:48:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAqOI-00Dwwg-Oo; Wed, 06 Dec 2023 12:48:34 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAqOI-00FR29-Fj; Wed, 06 Dec 2023 12:48:34 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding Cc: kernel@pengutronix.de, Heiko Stuebner , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v4 086/115] pwm: rockchip: Make use of devm_pwmchip_alloc() function Date: Wed, 6 Dec 2023 12:44:40 +0100 Message-ID: <6ff62a16862768b6817819b95e2924e41e05274f.1701860672.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2782; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=S7YX0LwIqVOrST7fEGIoSpGkN5LeF/GvgXdy7bmFJng=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcF8L7yvFClcAEsxR7qwjFMFeptLj1uN1lQo+j wAiKYkyHf2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXBfCwAKCRCPgPtYfRL+ ToOgB/4nxtvlkfat2L0pkMInq5YCqdx6qHhSfWrrtVUm/8qDbeIWh/3BRuLQDYDSc4e1YNgmz9d qUFCK+r0kDwnNgxqszPj5/LRlviTZu3RnwGvk7U0RR+DKL8trUKjhvSgbNLBf8KXHXNICPn9pus 2N9CpNc2NerpHDaoZSALAyFfNAbORgCNIjLFXS91n1rVyz6Sa3VIFdM/OmHSqMw6zNPy8RWXSNQ Nhd7AIMObGFCVQG+lz3FsgT8WM92EVzuHu3DPbYFZnMaHqKWi1oFNeitaMtrvWwAqKe63z9zDZ6 oDfMan+q7WhGdIIgT7+Oha1hDVbif2lDlNjlAXLUxm/sJnGj X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_114842_117050_77F9E6A7 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org This prepares the pwm-rockchip driver to further changes of the pwm core outlined in the commit introducing devm_pwmchip_alloc(). There is no intended semantical change and the driver should behave as before. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/pwm/pwm-rockchip.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index a7c647e37837..0fa7575dbb54 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -30,7 +30,6 @@ #define PWM_LP_DISABLE (0 << 8) struct rockchip_pwm_chip { - struct pwm_chip chip; struct clk *clk; struct clk *pclk; const struct rockchip_pwm_data *data; @@ -54,7 +53,7 @@ struct rockchip_pwm_data { static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *chip) { - return container_of(chip, struct rockchip_pwm_chip, chip); + return pwmchip_get_drvdata(chip); } static int rockchip_pwm_get_state(struct pwm_chip *chip, @@ -296,14 +295,16 @@ MODULE_DEVICE_TABLE(of, rockchip_pwm_dt_ids); static int rockchip_pwm_probe(struct platform_device *pdev) { + struct pwm_chip *chip; struct rockchip_pwm_chip *pc; u32 enable_conf, ctrl; bool enabled; int ret, count; - pc = devm_kzalloc(&pdev->dev, sizeof(*pc), GFP_KERNEL); - if (!pc) - return -ENOMEM; + chip = devm_pwmchip_alloc(&pdev->dev, 1, sizeof(*pc)); + if (IS_ERR(chip)) + return PTR_ERR(chip); + pc = to_rockchip_pwm_chip(chip); pc->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(pc->base)) @@ -337,18 +338,16 @@ static int rockchip_pwm_probe(struct platform_device *pdev) goto err_clk; } - platform_set_drvdata(pdev, pc); + platform_set_drvdata(pdev, chip); pc->data = device_get_match_data(&pdev->dev); - pc->chip.dev = &pdev->dev; - pc->chip.ops = &rockchip_pwm_ops; - pc->chip.npwm = 1; + chip->ops = &rockchip_pwm_ops; enable_conf = pc->data->enable_conf; ctrl = readl_relaxed(pc->base + pc->data->regs.ctrl); enabled = (ctrl & enable_conf) == enable_conf; - ret = pwmchip_add(&pc->chip); + ret = pwmchip_add(chip); if (ret < 0) { dev_err_probe(&pdev->dev, ret, "pwmchip_add() failed\n"); goto err_pclk; @@ -372,9 +371,10 @@ static int rockchip_pwm_probe(struct platform_device *pdev) static void rockchip_pwm_remove(struct platform_device *pdev) { - struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev); + struct pwm_chip *chip = platform_get_drvdata(pdev); + struct rockchip_pwm_chip *pc = to_rockchip_pwm_chip(chip); - pwmchip_remove(&pc->chip); + pwmchip_remove(chip); clk_unprepare(pc->pclk); clk_unprepare(pc->clk);