Message ID | f5bc182b-f9b6-26a8-8649-19ce33e3c0e1@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v1,1/3] dt-bindings: drm: rockchip: convert inno_hdmi-rockchip.txt to yaml | expand |
Hi Johan, Am 04.12.23 um 18:40 schrieb Johan Jonker: > Add hdmi-connector node to comply with the inno_hdmi binding. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > index 67e1e04139e7..a213333be011 100644 > --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts > @@ -13,6 +13,17 @@ memory@60000000 { > reg = <0x60000000 0x20000000>; > }; > > + hdmi_con: hdmi-con { > + compatible = "hdmi-connector"; > + type = "c"; According to [0], kylin has an A-Type HDMI port - so this should be + type = "a"; [0] http://rockchip.wikidot.com/kylin Regards, Alex > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; > + }; > + }; > + }; > + > leds: gpio-leds { > compatible = "gpio-leds"; > > @@ -110,6 +121,12 @@ &hdmi { > status = "okay"; > }; > > +&hdmi_out { > + hdmi_out_con: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > +}; > + > &i2c1 { > clock-frequency = <400000>; > > -- > 2.39.2 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
Hi Alex, Heiko, On 12/4/23 20:12, Alex Bee wrote: > Hi Johan, > Am 04.12.23 um 18:40 schrieb Johan Jonker: >> Add hdmi-connector node to comply with the inno_hdmi binding. >> >> Signed-off-by: Johan Jonker <jbx6244@gmail.com> >> --- >> arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts >> index 67e1e04139e7..a213333be011 100644 >> --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts >> +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts >> @@ -13,6 +13,17 @@ memory@60000000 { >> reg = <0x60000000 0x20000000>; >> }; >> >> + hdmi_con: hdmi-con { >> + compatible = "hdmi-connector"; >> + type = "c"; > According to [0], kylin has an A-Type HDMI port - so this should be > + type = "a"; > > [0] http://rockchip.wikidot.com/kylin Not sure from the text or do I miss something... I did look at that board picture before submitting. Can be wrong, but to me it looks a smaller HDMI connector. Does anyone have a Kylin picture from a different angle? Or reference design? Else apply and fix later? (Heiko ?) Let me know. Johan > > Regards, > Alex >> + >> + port { >> + hdmi_con_in: endpoint { >> + remote-endpoint = <&hdmi_out_con>; >> + }; >> + }; >> + }; >> + >> leds: gpio-leds { >> compatible = "gpio-leds"; >> >> @@ -110,6 +121,12 @@ &hdmi { >> status = "okay"; >> }; >> >> +&hdmi_out { >> + hdmi_out_con: endpoint { >> + remote-endpoint = <&hdmi_con_in>; >> + }; >> +}; >> + >> &i2c1 { >> clock-frequency = <400000>; >> >> -- >> 2.39.2 >> >> >> _______________________________________________ >> Linux-rockchip mailing list >> Linux-rockchip@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-rockchip >
diff --git a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts index 67e1e04139e7..a213333be011 100644 --- a/arch/arm/boot/dts/rockchip/rk3036-kylin.dts +++ b/arch/arm/boot/dts/rockchip/rk3036-kylin.dts @@ -13,6 +13,17 @@ memory@60000000 { reg = <0x60000000 0x20000000>; }; + hdmi_con: hdmi-con { + compatible = "hdmi-connector"; + type = "c"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; + leds: gpio-leds { compatible = "gpio-leds"; @@ -110,6 +121,12 @@ &hdmi { status = "okay"; }; +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + &i2c1 { clock-frequency = <400000>;
Add hdmi-connector node to comply with the inno_hdmi binding. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) -- 2.39.2