From patchwork Tue Sep 29 13:14:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 11806037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B47A1746 for ; Tue, 29 Sep 2020 14:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EADBB20848 for ; Tue, 29 Sep 2020 14:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730077AbgI2OEy (ORCPT ); Tue, 29 Sep 2020 10:04:54 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:47943 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730496AbgI2OEw (ORCPT ); Tue, 29 Sep 2020 10:04:52 -0400 X-Greylist: delayed 428 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Sep 2020 10:04:51 EDT X-IronPort-AV: E=Sophos;i="5.77,318,1596492000"; d="scan'208";a="470079946" Received: from palace.lip6.fr ([132.227.105.202]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-SHA256; 29 Sep 2020 15:57:40 +0200 From: Julia Lawall To: linux-samsung-soc@vger.kernel.org Cc: =?utf-8?q?Valdis_Kl=C4=93tnieks?= , Joe Perches , Thomas Gleixner , kernel-janitors@vger.kernel.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 00/20] media: use semicolons rather than commas to separate statements Date: Tue, 29 Sep 2020 15:14:23 +0200 Message-Id: <1601385283-26144-1-git-send-email-Julia.Lawall@inria.fr> X-Mailer: git-send-email 1.9.1 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org These patches replace commas by semicolons. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. This semantic patch ensures that commas inside for loop headers will not be transformed. It also doesn't touch macro definitions. Coccinelle ensures that braces are added as needed when a single-statement branch turns into a multi-statement one. This semantic patch has a few false positives, for variable delcarations such as: LIST_HEAD(x), *y; The semantic patch could be improved to avoid these, but for the moment they have been removed manually (2 occurrences). // @initialize:ocaml@ @@ let infunction p = (* avoid macros *) (List.hd p).current_element <> "something_else" let combined p1 p2 = (List.hd p1).line_end = (List.hd p2).line || (((List.hd p1).line_end < (List.hd p2).line) && ((List.hd p1).col < (List.hd p2).col)) @bad@ statement S; declaration d; position p; @@ S@p d // special cases where newlines are needed (hope for no more than 5) @@ expression e1,e2; statement S; position p != bad.p; position p1; position p2 : script:ocaml(p1) { infunction p1 && combined p1 p2 }; @@ - e1@p1,@S@p e2@p2; + e1; e2; @@ expression e1,e2; statement S; position p != bad.p; position p1; position p2 : script:ocaml(p1) { infunction p1 && combined p1 p2 }; @@ - e1@p1,@S@p e2@p2; + e1; e2; @@ expression e1,e2; statement S; position p != bad.p; position p1; position p2 : script:ocaml(p1) { infunction p1 && combined p1 p2 }; @@ - e1@p1,@S@p e2@p2; + e1; e2; @@ expression e1,e2; statement S; position p != bad.p; position p1; position p2 : script:ocaml(p1) { infunction p1 && combined p1 p2 }; @@ - e1@p1,@S@p e2@p2; + e1; e2; @@ expression e1,e2; statement S; position p != bad.p; position p1; position p2 : script:ocaml(p1) { infunction p1 && combined p1 p2 }; @@ - e1@p1,@S@p e2@p2; + e1; e2; @r@ expression e1,e2; statement S; position p != bad.p; @@ e1 ,@S@p e2; @@ expression e1,e2; position p1; position p2 : script:ocaml(p1) { infunction p1 && not(combined p1 p2) }; statement S; position r.p; @@ e1@p1 -,@S@p +; e2@p2 ... when any // --- drivers/media/dvb-frontends/m88ds3103.c | 6 ++--- drivers/media/dvb-frontends/rtl2832.c | 14 ++++++------ drivers/media/dvb-frontends/ts2020.c | 10 ++++----- drivers/media/i2c/msp3400-kthreads.c | 12 +++++++--- drivers/media/pci/bt8xx/bttv-cards.c | 6 +++-- drivers/media/pci/saa7134/saa7134-video.c | 7 ++++-- drivers/media/platform/coda/coda-common.c | 2 - drivers/media/platform/exynos4-is/fimc-core.c | 6 +++-- drivers/media/platform/s3c-camif/camif-core.c | 6 +++-- drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c | 2 - drivers/media/radio/radio-sf16fmr2.c | 2 - drivers/media/tuners/mt2060.c | 2 - drivers/media/usb/au0828/au0828-video.c | 2 - drivers/media/usb/dvb-usb-v2/dvbsky.c | 22 ++++++++++---------- drivers/media/usb/dvb-usb-v2/lmedm04.c | 2 - drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 4 +-- drivers/media/usb/dvb-usb/dib0700_devices.c | 4 +-- drivers/media/usb/em28xx/em28xx-audio.c | 14 ++++++------ drivers/media/usb/gspca/ov534.c | 12 +++++----- drivers/media/usb/pvrusb2/pvrusb2-devattr.c | 2 - 20 files changed, 75 insertions(+), 62 deletions(-)