[v2,0/3] Add initial support for exynos5420-chagallwifi

Message

Henrik Grimler Jan. 15, 2022, 4:27 p.m. UTC

Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename chagallwifi
and is one of several tablets released in 2013 - 2014 based on Exynos
5420.  This initial devicetree adds support for accessing device over
USB or UART, and allows using a rootfs in either the internal eMMC or
an external sdcard.  4 out of 8 CPUs are brought up when device boots,
which is the same as on the somewhat similar device
exynos5420-arndale-octa.

Patch 2 is necessary after a secure-firmware node is added, otherwise
device hangs during the CPU1BOOT secure monitor call. Without the
secure-firmware node we are not able to bring up any secondary CPUs.

Changes since v1
================

Fix mmc_0 and usbdrd in patch 3: 
* Remove extra, non supported, options from mmc_0 node 
* Do not set usbdrd supplies. Usb networking does not work with them 
  specified, but it works fine with dummy regulators

Henrik Grimler (3):
  dt-bindings: arm: samsung: document chagallwifi board binding
  ARM: exynos: only do SMC_CMD_CPU1BOOT call on Exynos4
  ARM: dts: Add support for Samsung Chagallwifi

 .../bindings/arm/samsung/samsung-boards.yaml  |   1 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/exynos5420-chagallwifi.dts  |  57 ++
 .../dts/exynos5420-galaxy-tab-common.dtsi     | 633 ++++++++++++++++++
 arch/arm/mach-exynos/firmware.c               |   4 +-
 5 files changed, 695 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/boot/dts/exynos5420-chagallwifi.dts
 create mode 100644 arch/arm/boot/dts/exynos5420-galaxy-tab-common.dtsi

Comments

Krzysztof Kozlowski Jan. 15, 2022, 4:37 p.m. UTC | #1

On 15/01/2022 17:27, Henrik Grimler wrote:
> Samsung's tablet Galaxy Tab S 10.5" (wifi) has codename chagallwifi
> and is one of several tablets released in 2013 - 2014 based on Exynos
> 5420.  This initial devicetree adds support for accessing device over
> USB or UART, and allows using a rootfs in either the internal eMMC or
> an external sdcard.  4 out of 8 CPUs are brought up when device boots,
> which is the same as on the somewhat similar device
> exynos5420-arndale-octa.
> 
> Patch 2 is necessary after a secure-firmware node is added, otherwise
> device hangs during the CPU1BOOT secure monitor call. Without the
> secure-firmware node we are not able to bring up any secondary CPUs.
> 
> Changes since v1
> ================
> 
> Fix mmc_0 and usbdrd in patch 3: 
> * Remove extra, non supported, options from mmc_0 node 
> * Do not set usbdrd supplies. Usb networking does not work with them 
>   specified, but it works fine with dummy regulators

Re-try with supplies after fixing the regulators (my comment to v1).
These should work, unless your regulators are wrongly configured or you
used wrong supplies.

I just sent a review for v1, so please go through it.

Best regards,
Krzysztof