| Message ID | 20220523064252.11938-1-juergh@canonical.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: s3c: Kconfig: Style cleanups | expand |
On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote: > The majority of the Kconfig files use a single tab for basic indentation > and a single tab followed by two whitespaces for help text indentation. > Fix the lines that don't follow this convention. > > While at it, add missing trailing comments to endif statements and replace > tabs before comments with whitespaces (which seems to be more common). > > [...] Applied, thanks! [1/3] ARM: s3c: Kconfig: Fix indentation https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation (no commit info) Best regards,
On 06/06/2022 11:13, Krzysztof Kozlowski wrote: > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote: >> The majority of the Kconfig files use a single tab for basic indentation >> and a single tab followed by two whitespaces for help text indentation. >> Fix the lines that don't follow this convention. >> >> While at it, add missing trailing comments to endif statements and replace >> tabs before comments with whitespaces (which seems to be more common). >> >> [...] > > Applied, thanks! > > [1/3] ARM: s3c: Kconfig: Fix indentation > https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation > (no commit info) ...And dropped. This does not pass checkpatch. Please be sure you run scripts/checkpatch on your contributions. WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg Haefliger <juergh@canonical.com>' Best regards, Krzysztof
On Mon, 6 Jun 2022 11:14:28 +0200 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > On 06/06/2022 11:13, Krzysztof Kozlowski wrote: > > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote: > >> The majority of the Kconfig files use a single tab for basic indentation > >> and a single tab followed by two whitespaces for help text indentation. > >> Fix the lines that don't follow this convention. > >> > >> While at it, add missing trailing comments to endif statements and replace > >> tabs before comments with whitespaces (which seems to be more common). > >> > >> [...] > > > > Applied, thanks! > > > > [1/3] ARM: s3c: Kconfig: Fix indentation > > https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae > > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation > > (no commit info) > > ...And dropped. This does not pass checkpatch. Please be sure you run > scripts/checkpatch on your contributions. I did and the check passed but email aliases don't work well in this scenario. Will fix and resubmit. ...Juerg > WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg > Haefliger <juerg.haefliger@canonical.com>' != 'Signed-off-by: Juerg > Haefliger <juergh@canonical.com>' > > > Best regards, > Krzysztof
The majority of the Kconfig files use a single tab for basic indentation and a single tab followed by two whitespaces for help text indentation. Fix the lines that don't follow this convention. While at it, add missing trailing comments to endif statements and replace tabs before comments with whitespaces (which seems to be more common). v3: - Match sob and author email addresses. - Rebase to next-20220609. v2 (patch 2 only): - Mention additional changes in the commit message. Juerg Haefliger (3): ARM: s3c: Kconfig: Fix indentation ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs ARM: s3c: Kconfig.s3c64xx: Fix indentation arch/arm/mach-s3c/Kconfig | 14 +++++++------- arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++-------------- arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++-------- 3 files changed, 27 insertions(+), 29 deletions(-)
On Thu, 9 Jun 2022 10:21:51 +0200, Juerg Haefliger wrote: > The majority of the Kconfig files use a single tab for basic indentation > and a single tab followed by two whitespaces for help text indentation. > Fix the lines that don't follow this convention. > > While at it, add missing trailing comments to endif statements and replace > tabs before comments with whitespaces (which seems to be more common). > > [...] Applied, thanks! [1/3] ARM: s3c: Kconfig: Fix indentation https://git.kernel.org/krzk/linux/c/1afde294a99d3dd2a2aa4e28d15590755927f66e [2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs https://git.kernel.org/krzk/linux/c/48bf4b8497419f5b9a29da19c72e00dc2b8d498c [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation https://git.kernel.org/krzk/linux/c/d1065293010a010261f0b1478daff40d5a3dc241 Best regards,