[v3,00/12] regmap-irq cleanups and refactoring

Message

Aidan MacDonald July 3, 2022, 11:20 a.m. UTC

This series is an attempt at cleaning up the regmap-irq API in order
to simplify things and consolidate existing features, while at the
same time generalizing it to support a wider range of hardware.

There is a new system for IRQ type configuration, some tweaks to
unmask registers so they're more intuitive and useful, and a new
callback for calculating register addresses. There's also a few
minor code cleanups in here.

Several existing features have been marked deprecated. Warnings will
be issued for any drivers that use deprecated features, but they'll
otherwise continue to function normally.

One important caveat: not all of these changes are tested beyond
compile testing, since I don't have hardware to exercise all of
the features.

v3 changelog

* Fix bug in patch 11/12 reported by Marek Szyprowski
  https://lore.kernel.org/lkml/[e-mail]/

v2 changelog

* Drop driver patches, these will be sent as separate series to the
  appropriate subsystem maintainers.
* Drop patches that remove deprecated features, that should be done
  in a separate series.
* Various fixups to address Andy Shevchenko's v1 review comments.
* Drop patches that changed the behavior of mask_writeonly; instead
  just remove the flag.

Aidan MacDonald (12):
  regmap-irq: Convert bool bitfields to unsigned int
  regmap-irq: Remove unused type_reg_stride field
  regmap-irq: Cleanup sizeof(...) use in memory allocation
  regmap-irq: Remove an unnecessary restriction on type_in_mask
  regmap-irq: Remove inappropriate uses of regmap_irq_update_bits()
  regmap-irq: Remove mask_writeonly and regmap_irq_update_bits()
  regmap-irq: Refactor checks for status bulk read support
  regmap-irq: Introduce config registers for irq types
  regmap-irq: Deprecate type registers and virtual registers
  regmap-irq: Fix inverted handling of unmask registers
  regmap-irq: Add get_irq_reg() callback
  regmap-irq: Deprecate the not_fixed_stride flag

 drivers/base/regmap/regmap-irq.c | 432 +++++++++++++++++++++----------
 include/linux/regmap.h           | 104 +++++---
 2 files changed, 367 insertions(+), 169 deletions(-)

Comments

Andy Shevchenko July 3, 2022, 2:27 p.m. UTC | #1

On Sun, Jul 3, 2022 at 1:20 PM Aidan MacDonald
<[e-mail]> wrote:
>
> This series is an attempt at cleaning up the regmap-irq API in order
> to simplify things and consolidate existing features, while at the
> same time generalizing it to support a wider range of hardware.
>
> There is a new system for IRQ type configuration, some tweaks to
> unmask registers so they're more intuitive and useful, and a new
> callback for calculating register addresses. There's also a few
> minor code cleanups in here.
>
> Several existing features have been marked deprecated. Warnings will
> be issued for any drivers that use deprecated features, but they'll
> otherwise continue to function normally.
>
> One important caveat: not all of these changes are tested beyond
> compile testing, since I don't have hardware to exercise all of
> the features.

Obviously you haven't rebased it on top of
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/log/?h=for-5.20
so it may not be applied.

Mark Brown July 4, 2022, 10:34 a.m. UTC | #2

On Sun, Jul 03, 2022 at 04:27:49PM +0200, Andy Shevchenko wrote:

> Obviously you haven't rebased it on top of
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/log/?h=for-5.20
> so it may not be applied.

Yes, please send incremental patches against what's already applied.

Aidan MacDonald July 4, 2022, 10:58 a.m. UTC | #3

Mark Brown <[e-mail]> writes:

> On Sun, Jul 03, 2022 at 04:27:49PM +0200, Andy Shevchenko wrote:
>
>> Obviously you haven't rebased it on top of
>> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/log/?h=for-5.20
>> so it may not be applied.
>
> Yes, please send incremental patches against what's already applied.

Alright, I'll send a patch along shortly. I thought it was fine to drop
patches from -next if problems show up so I had assumed it was better to
just replace the series.