From patchwork Thu Oct 10 06:32:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3014281 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 84EC4BF924 for ; Thu, 10 Oct 2013 06:32:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDDFE203A3 for ; Thu, 10 Oct 2013 06:32:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D768620250 for ; Thu, 10 Oct 2013 06:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049Ab3JJGco (ORCPT ); Thu, 10 Oct 2013 02:32:44 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:9477 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491Ab3JJGcn (ORCPT ); Thu, 10 Oct 2013 02:32:43 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUF00LS0WTVXL70@mailout4.samsung.com>; Thu, 10 Oct 2013 15:32:42 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.49]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 05.AD.31253.A0A46525; Thu, 10 Oct 2013 15:32:42 +0900 (KST) X-AuditID: cbfee690-b7f3b6d000007a15-8c-52564a0a1afd Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id D2.16.05832.A0A46525; Thu, 10 Oct 2013 15:32:42 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUF00BIQWUIAQ00@mmp1.samsung.com>; Thu, 10 Oct 2013 15:32:42 +0900 (KST) From: Jingoo Han To: 'Greg Kroah-Hartman' Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Kukjin Kim' , 'Alan Stern' , 'Sylwester Nawrocki' , 'Tomasz Figa' , 'Jingoo Han' References: <000001cec582$02a6cfb0$07f46f10$%han@samsung.com> In-reply-to: <000001cec582$02a6cfb0$07f46f10$%han@samsung.com> Subject: [PATCH 5/5] USB: ohci-exynos: Add missing usb_put_hcd() to prevent memory leak Date: Thu, 10 Oct 2013 15:32:42 +0900 Message-id: <000b01cec582$85c73b50$9155b1f0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7FggI+9Gc/UHTXR/6J62TM6wkGowAAHc5Q Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t8zQ10ur7Aggx9dghbNi9ezWVxeeInV onfBVTaLGef3MVksWtbKbHH4TTurxYTfF9gs1s94zeLA4bF/7hp2j9l3fzB69G1ZxejxeZNc AEsUl01Kak5mWWqRvl0CV8bta/fZCs6yVqztmM7awHiDpYuRk0NCwETi9KqFbBC2mMSFe+uB bC4OIYFljBK/Zi1khSk6ePY/E4gtJLCIUeLY0yqIol+MEs9nLwZLsAmoSXz5cpgdxBYRMJXY +H4KI4jNLNDPJHH1SBpEs63E1/+rwTZzCthJTO/eBFYvLBApsejoOTCbRUBV4tqN20CLOTh4 ger3z04BCfMKCEr8mHyPBWKklsT6nceZIGx5ic1r3jKDlEsIqEs8+qsLcYGRxOf306BKRCT2 vXjHCHKyhMBLdombnzYwQawSkPg2+RALRK+sxKYDzBDvSkocXHGDZQKjxCwkm2ch2TwLyeZZ SFYsYGRZxSiaWpBcUJyUXmSiV5yYW1yal66XnJ+7iRESuxN2MN47YH2IMRlo/URmKdHkfGDs 55XEGxqbGVmYmpgaG5lbmpEmrCTOq95iHSgkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBkeXl DQYHDva5lntf89zsWcN4ZeLhy0+SDcWl5+ec39Dkz1z1s/FX+o3fNx/fn9mRaT/Tel+zsmvk /qP6NQJPzofbfEw82ff77g7NcoNujt09fr+PeC9dvHDt3fRp8xb0zG3vZ5iQylx0Urnpa26l eCO7/Zf5dd9q7s/7JW+ksfDOvtmSB7a/d1FiKc5INNRiLipOBAADpNWD8wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsVy+t9jAV0ur7Agg7mfeCyaF69ns7i88BKr Re+Cq2wWM87vY7JYtKyV2eLwm3ZWiwm/L7BZrJ/xmsWBw2P/3DXsHrPv/mD06NuyitHj8ya5 AJaoBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKA7 lBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGEdYwZt6/dZys4y1qxtmM6awPj DZYuRk4OCQETiYNn/zNB2GISF+6tZwOxhQQWMUoce1rVxcgFZP9ilHg+ezFYEZuAmsSXL4fZ QWwRAVOJje+nMILYzAL9TBJXj6RBNNtKfP2/GmwBp4CdxPTuTWD1wgKREouOngOzWQRUJa7d uM3axcjBwQtUv392CkiYV0BQ4sfkeywQI7Uk1u88zgRhy0tsXvOWGaRcQkBd4tFfXYgLjCQ+ v58GVSIise/FO8YJjEKzkEyahWTSLCSTZiFpWcDIsopRNLUguaA4KT3XSK84Mbe4NC9dLzk/ dxMjODE8k97BuKrB4hCjAAejEg9vRVlokBBrYllxZe4hRgkOZiUR3ukngUK8KYmVValF+fFF pTmpxYcYk4H+nMgsJZqcD0xaeSXxhsYmZkaWRmYWRibm5qQJK4nzHmy1DhQSSE8sSc1OTS1I LYLZwsTBKdXA6OC66KtL15yj0zOEPGeZZHtN4232mV3A7f1meb6KlwD/lT3BW3frHPKUC9lk uPfI8c7M3iP3PLJ1fQKzCvZP3Mt9/LPMjyf7/hyRa165/ZKd9oFPp9XmVUbPCf8skuSn8OHZ hf6KgOW8zvyhd4+If3SRn295TVmXMXB32oclf5QVNy96eijqgBJLcUaioRZzUXEiAI4GndFQ AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When devm_usb_get_phy() fails, usb_put_hcd() should be called to prevent memory leak. Signed-off-by: Jingoo Han --- drivers/usb/host/ohci-exynos.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 5c877bf..aa50e18 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -91,6 +91,7 @@ static int exynos_ohci_probe(struct platform_device *pdev) phy = devm_usb_get_phy(&pdev->dev, USB_PHY_TYPE_USB2); if (IS_ERR(phy)) { + usb_put_hcd(hcd); dev_warn(&pdev->dev, "no platform data or transceiver defined\n"); return -EPROBE_DEFER; } else {