From patchwork Mon Jul 15 23:37:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2827771 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 89FD59F9CA for ; Mon, 15 Jul 2013 23:37:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9B88D201EA for ; Mon, 15 Jul 2013 23:37:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC48A201D1 for ; Mon, 15 Jul 2013 23:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757698Ab3GOXhe (ORCPT ); Mon, 15 Jul 2013 19:37:34 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54170 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757532Ab3GOXhd (ORCPT ); Mon, 15 Jul 2013 19:37:33 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQ0009L149QWH00@mailout1.samsung.com>; Tue, 16 Jul 2013 08:37:32 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 8E.13.08825.CB784E15; Tue, 16 Jul 2013 08:37:32 +0900 (KST) X-AuditID: cbfee68e-b7f276d000002279-14-51e487bcc716 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 1E.2A.03860.CB784E15; Tue, 16 Jul 2013 08:37:32 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQ0007704AJDQ50@mmp1.samsung.com>; Tue, 16 Jul 2013 08:37:31 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Joe Perches' , Jingoo Han Subject: [PATCH V3 2/2] spi: s3c64xx: fix checkpatch error and warnings Date: Tue, 16 Jul 2013 08:37:31 +0900 Message-id: <003101ce81b4$468041b0$d380c510$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac6BtDVXT+owoiSmT/6OuRxj1+PvXg== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t8zI9097U8CDb7fEbCY+vAJm8XlhZdY LWbff8xiMeP8PiaLxo832R1YPTat6mTz+LLqGrNH35ZVjB6fN8kFsERx2aSk5mSWpRbp2yVw Zcycso+t4J5oxYJZ3xkbGK8JdjFyckgImEhMbLrOAmGLSVy4t56ti5GLQ0hgGaPEmok32WCK tu26xw6RWMQosfb7KaiqX4wSe3aeBqtiE1CT+PLlMFAVB4eIgKrE/1fuIGFmgVZGiV8zPUBs YQF3iRUvnzOD2CxAJW2XD7CD2LwClhILV82DsgUlfky+xwLRqyWxfudxJghbXmLzmrfMEAcp SOw4+5oRxBYR0JN49ewlO0SNiMS+F+8YQW6TENjFLnFg9Xo2iGUCEt8mH2IBuU1CQFZi0wGo OZISB1fcYJnAKDYLyepZSFbPQrJ6FpIVCxhZVjGKphYkFxQnpRcZ6RUn5haX5qXrJefnbmKE RFzfDsabB6wPMSYDrZ/ILCWanA+M2LySeENjMyMLUxNTYyNzSzPShJXEedVarAOFBNITS1Kz U1MLUovii0pzUosPMTJxcEo1MHp71Pm9eHtl9q8GD1anLN3rigd2qbKcb2WcWiOqfCHPO9Tt JevkGu0o2fhzS6r7Tk1jtfL48u8206O6E51RHNJtO0+4VQTtczdSrDhj+ep85YJbruzLZkaw uLVkrxSNOXk1vYaBt2Wq6zmJ/D6THctixY2vc6i7Gabc21paE2stza6paCmnxFKckWioxVxU nAgAOPcVy84CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsVy+t9jAd097U8CDZ6f5baY+vAJm8XlhZdY LWbff8xiMeP8PiaLxo832R1YPTat6mTz+LLqGrNH35ZVjB6fN8kFsEQ1MNpkpCampBYppOYl 56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAC1WUihLzCkFCgUkFhcr6dth mhAa4qZrAdMYoesbEgTXY2SABhLWMWbMnLKPreCeaMWCWd8ZGxivCXYxcnJICJhIbNt1jx3C FpO4cG89WxcjF4eQwCJGibXfT0E5vxgl9uw8zQZSxSagJvHly2GgDg4OEQFVif+v3EHCzAKt jBK/ZnqA2MIC7hIrXj5nBrFZgEraLh8AW8ArYCmxcNU8KFtQ4sfkeywQvVoS63ceZ4Kw5SU2 r3nLDHGQgsSOs68ZQWwRAT2JV89eskPUiEjse/GOcQKjwCwko2YhGTULyahZSFoWMLKsYhRN LUguKE5KzzXSK07MLS7NS9dLzs/dxAiO52fSOxhXNVgcYhTgYFTi4T3I+SRQiDWxrLgy9xCj BAezkgivnTBQiDclsbIqtSg/vqg0J7X4EGMy0KcTmaVEk/OBqSavJN7Q2MTMyNLIzMLIxNyc NGElcd6DrdaBQgLpiSWp2ampBalFMFuYODilGhiVZkcZ+36YFv3vpnGURYJf4YoXHql3hFwm BK+c8MTUbamv+f1Hb3I/Sud8+PmOQUlx9qVf1rKH9imJuL+9o3Vf0/J0e1fbA5UIWYZwUYXs SUe0jec+ib/VJ7VhnmoAp98ml7T5Mzapvk5X9L1w/CkX93rWlyzbX26O8FS8vi1oVc2pp6dn 3fqixFKckWioxVxUnAgAplU8XCsDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the following checkpatch error and warnings: ERROR: "(foo*)" should be "(foo *)" WARNING: line over 80 characters WARNING: quoted string split across lines Also, it converts (void *) to (unsigned long *) to fix sparse error. Signed-off-by: Jingoo Han --- Changes since v2: - Converted (void *) to (unsigned long *) for sdd->ops->request drivers/spi/spi-s3c64xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 21ba0a0..52d7a28 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -338,8 +338,10 @@ static int acquire_dma(struct s3c64xx_spi_driver_data *sdd) req.cap = DMA_SLAVE; req.client = &s3c64xx_spi_dma_client; - sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach, &req, dev, "rx"); - sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach, &req, dev, "tx"); + sdd->rx_dma.ch = (unsigned long *)sdd->ops->request(sdd->rx_dma.dmach, + &req, dev, "rx"); + sdd->tx_dma.ch = (unsigned long *)sdd->ops->request(sdd->tx_dma.dmach, + &req, dev, "tx"); return 1; } @@ -439,7 +441,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi) /* Acquire DMA channels */ sdd->rx_dma.ch = dma_request_slave_channel_compat(mask, filter, - (void*)sdd->rx_dma.dmach, dev, "rx"); + (void *)sdd->rx_dma.dmach, dev, "rx"); if (!sdd->rx_dma.ch) { dev_err(dev, "Failed to get RX DMA channel\n"); ret = -EBUSY; @@ -447,7 +449,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi) } sdd->tx_dma.ch = dma_request_slave_channel_compat(mask, filter, - (void*)sdd->tx_dma.dmach, dev, "tx"); + (void *)sdd->tx_dma.dmach, dev, "tx"); if (!sdd->tx_dma.ch) { dev_err(dev, "Failed to get TX DMA channel\n"); ret = -EBUSY; @@ -1361,16 +1363,14 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) if (!sdd->pdev->dev.of_node) { res = platform_get_resource(pdev, IORESOURCE_DMA, 0); if (!res) { - dev_warn(&pdev->dev, "Unable to get SPI tx dma " - "resource. Switching to poll mode\n"); + dev_warn(&pdev->dev, "Unable to get SPI tx dma resource. Switching to poll mode\n"); sdd->port_conf->quirks = S3C64XX_SPI_QUIRK_POLL; } else sdd->tx_dma.dmach = res->start; res = platform_get_resource(pdev, IORESOURCE_DMA, 1); if (!res) { - dev_warn(&pdev->dev, "Unable to get SPI rx dma " - "resource. Switching to poll mode\n"); + dev_warn(&pdev->dev, "Unable to get SPI rx dma resource. Switching to poll mode\n"); sdd->port_conf->quirks = S3C64XX_SPI_QUIRK_POLL; } else sdd->rx_dma.dmach = res->start;