From patchwork Mon Jul 15 23:54:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2827799 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CC4CAC0AB2 for ; Mon, 15 Jul 2013 23:54:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EDCD6201D2 for ; Mon, 15 Jul 2013 23:54:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7F0E201C2 for ; Mon, 15 Jul 2013 23:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757351Ab3GOXym (ORCPT ); Mon, 15 Jul 2013 19:54:42 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:45924 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754915Ab3GOXyl (ORCPT ); Mon, 15 Jul 2013 19:54:41 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQ000KZZ52O07E0@mailout3.samsung.com>; Tue, 16 Jul 2013 08:54:40 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id FA.1A.11618.0CB84E15; Tue, 16 Jul 2013 08:54:40 +0900 (KST) X-AuditID: cbfee691-b7fef6d000002d62-fd-51e48bc07326 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F4.BD.03860.0CB84E15; Tue, 16 Jul 2013 08:54:40 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQ000DJJ534XN40@mmp2.samsung.com>; Tue, 16 Jul 2013 08:54:40 +0900 (KST) From: Jingoo Han To: 'Mark Brown' Cc: linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Joe Perches' , Jingoo Han Subject: [PATCH V4 2/2] spi: s3c64xx: fix checkpatch error and warnings Date: Tue, 16 Jul 2013 08:54:39 +0900 Message-id: <003401ce81b6$ab70cb10$02526130$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac6BtpFWM5Y9bWTySp6WK0UrlX+3Lw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsVy+t8zA90D3U8CDTpnSllMffiEzeLywkus FrPvP2axmHF+H5NF48eb7A6sHptWdbJ5fFl1jdmjb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4 Mm5fucFSMFOsYsPB64wNjH1CXYycHBICJhJzdl9lgbDFJC7cW8/WxcjFISSwjFFi07G1LDBF Fxa+gUpMZ5S4suEpC4Tzi1Gi5esHsCo2ATWJL18Os3cxcnCICKhK/H/lDhJmFmhllPg10wMk LCzgLvFmhwVImAWoYkFzAxOIzStgKdF8cQOULSjxY/I9FohWLYn1O48zQdjyEpvXvGWGuEdB YsfZ14wQm/Qk5n5JgCgRkdj34h0jRMk2dokjrSwQqwQkvk0+xAJSLiEgK7HpANQUSYmDK26w TGAUm4Vk8Swki2chWTwLyYYFjCyrGEVTC5ILipPSi0z1ihNzi0vz0vWS83M3MUJibeIOxvsH rA8xJgOtn8gsJZqcD4zVvJJ4Q2MzIwtTE1NjI3NLM9KElcR51VusA4UE0hNLUrNTUwtSi+KL SnNSiw8xMnFwSjUwGoVHW8VJm+/gvBdj4mVxxcF7p86CGXJ3lGLnPgtqWFUTGVZfcOhZ17mI qTZ2j77cD5W6/nvbXPlnxVotiuZd5rIGVxME7660D3b+ncfv3KC4Q8HG+ZH9Tdmz+9edlJn2 7LzS7IhNM1f3285ll1J6YbvyfZpGKPPNb5uZ47kUAvr/7/s7wVVQiaU4I9FQi7moOBEAqkJm 7MsCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGKsWRmVeSWpSXmKPExsVy+t9jQd0D3U8CDfYvFrWY+vAJm8XlhZdY LWbff8xiMeP8PiaLxo832R1YPTat6mTz+LLqGrNH35ZVjB6fN8kFsEQ1MNpkpCampBYppOYl 56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAC1WUihLzCkFCgUkFhcr6dth mhAa4qZrAdMYoesbEgTXY2SABhLWMWbcvnKDpWCmWMWGg9cZGxj7hLoYOTkkBEwkLix8wwZh i0lcuLceyObiEBKYzihxZcNTFgjnF6NEy9cPLCBVbAJqEl++HGbvYuTgEBFQlfj/yh0kzCzQ yijxa6YHSFhYwF3izQ4LkDALUMWC5gYmEJtXwFKi+eIGKFtQ4sfkeywQrVoS63ceZ4Kw5SU2 r3nLDHGPgsSOs68ZITbpScz9kgBRIiKx78U7xgmMArOQTJqFZNIsJJNmIWlZwMiyilE0tSC5 oDgpPddIrzgxt7g0L10vOT93EyM4lp9J72Bc1WBxiFGAg1GJh/cg55NAIdbEsuLK3EOMEhzM SiK8dsJAId6UxMqq1KL8+KLSnNTiQ4zJQI9OZJYSTc4Hppm8knhDYxMzI0sjMwsjE3Nz0oSV xHkPtloHCgmkJ5akZqemFqQWwWxh4uCUamA0Ye4SKPjdtMcha6PDjzmnc7Puq2ZJX4/g+r9l /f59EWk1E7+GrN1lOlus+9g/M7+1kY/Prj6Se57luPtFhi/xdrPu1XOoKp4J2xLZdXX2rlfB alVrNoas/LJA0crhcUHO9g67in1e1zYll6ier3hupxs+91yvscND/1t7/xyIZPfV0qs79vGU EktxRqKhFnNRcSIAaCurPikDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the following checkpatch error and warnings: ERROR: "(foo*)" should be "(foo *)" WARNING: line over 80 characters WARNING: quoted string split across lines Also, it converts (void *) to (unsigned long *)(unsigned long) to fix sparse error. Signed-off-by: Jingoo Han --- Changes since v3: - Converted (void *) to (unsigned long *)(unsigned long) for sdd->ops->request drivers/spi/spi-s3c64xx.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 21ba0a0..0768c3c 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -338,8 +338,10 @@ static int acquire_dma(struct s3c64xx_spi_driver_data *sdd) req.cap = DMA_SLAVE; req.client = &s3c64xx_spi_dma_client; - sdd->rx_dma.ch = (void *)sdd->ops->request(sdd->rx_dma.dmach, &req, dev, "rx"); - sdd->tx_dma.ch = (void *)sdd->ops->request(sdd->tx_dma.dmach, &req, dev, "tx"); + sdd->rx_dma.ch = (unsigned long *)(unsigned long)sdd->ops->request( + sdd->rx_dma.dmach, &req, dev, "rx"); + sdd->tx_dma.ch = (unsigned long *)(unsigned long)sdd->ops->request( + sdd->tx_dma.dmach, &req, dev, "tx"); return 1; } @@ -439,7 +441,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi) /* Acquire DMA channels */ sdd->rx_dma.ch = dma_request_slave_channel_compat(mask, filter, - (void*)sdd->rx_dma.dmach, dev, "rx"); + (void *)sdd->rx_dma.dmach, dev, "rx"); if (!sdd->rx_dma.ch) { dev_err(dev, "Failed to get RX DMA channel\n"); ret = -EBUSY; @@ -447,7 +449,7 @@ static int s3c64xx_spi_prepare_transfer(struct spi_master *spi) } sdd->tx_dma.ch = dma_request_slave_channel_compat(mask, filter, - (void*)sdd->tx_dma.dmach, dev, "tx"); + (void *)sdd->tx_dma.dmach, dev, "tx"); if (!sdd->tx_dma.ch) { dev_err(dev, "Failed to get TX DMA channel\n"); ret = -EBUSY; @@ -1361,16 +1363,14 @@ static int s3c64xx_spi_probe(struct platform_device *pdev) if (!sdd->pdev->dev.of_node) { res = platform_get_resource(pdev, IORESOURCE_DMA, 0); if (!res) { - dev_warn(&pdev->dev, "Unable to get SPI tx dma " - "resource. Switching to poll mode\n"); + dev_warn(&pdev->dev, "Unable to get SPI tx dma resource. Switching to poll mode\n"); sdd->port_conf->quirks = S3C64XX_SPI_QUIRK_POLL; } else sdd->tx_dma.dmach = res->start; res = platform_get_resource(pdev, IORESOURCE_DMA, 1); if (!res) { - dev_warn(&pdev->dev, "Unable to get SPI rx dma " - "resource. Switching to poll mode\n"); + dev_warn(&pdev->dev, "Unable to get SPI rx dma resource. Switching to poll mode\n"); sdd->port_conf->quirks = S3C64XX_SPI_QUIRK_POLL; } else sdd->rx_dma.dmach = res->start;