| Message ID | 1360162668-29677-1-git-send-email-rahul.sharma@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Rahul, On 02/06/2013 03:57 PM, Rahul Sharma wrote: > Binding Documents for drm-devices are placed in > Documentation/devicetree/bindings/drm/*. But these devices are common > for v4l framework, hence moved to a common place > Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to > associate them with exynos soc series. It looks good to me, I would just use 'exynos-' prefix instead, this seems to be more common across existing files. Sorry for the nitpicking.. I suppose you should address the patch to and base on the tree of the device tree maintainers. Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Sylwester, On Wed, Feb 6, 2013 at 8:20 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > Hi Rahul, > > On 02/06/2013 03:57 PM, Rahul Sharma wrote: >> Binding Documents for drm-devices are placed in >> Documentation/devicetree/bindings/drm/*. But these devices are common >> for v4l framework, hence moved to a common place >> Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to >> associate them with exynos soc series. > > It looks good to me, I would just use 'exynos-' prefix instead, > this seems to be more common across existing files. Sorry for > the nitpicking.. > > I suppose you should address the patch to and base on the tree of > the device tree maintainers. > > Thanks, > Sylwester I mentioned it in the patch. Please let me know if it needs to be re-based to some other tree. > Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> > --- > It is base on for-next branch of > git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git > > .../devicetree/bindings/drm/exynos/hdmi.txt | 22 ---------------------- > .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------ > .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------ > > -- Regards, Rahul Sharma, email to: rahul.sharma@samsung.com Samsung India. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt b/Documentation/devicetree/bindings/drm/exynos/hdmi.txt deleted file mode 100644 index 589edee..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmi.txt +++ /dev/null @@ -1,22 +0,0 @@ -Device-Tree bindings for drm hdmi driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmi". -- reg: physical base address of the hdmi and length of memory mapped - region. -- interrupts: interrupt number to the cpu. -- hpd-gpio: following information about the hotplug gpio pin. - a) phandle of the gpio controller node. - b) pin number within the gpio controller. - c) pin function mode. - d) optional flags and pull up/down. - e) drive strength. - -Example: - - hdmi { - compatible = "samsung,exynos5-hdmi"; - reg = <0x14530000 0x100000>; - interrupts = <0 95 0>; - hpd-gpio = <&gpx3 7 0xf 1 3>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt deleted file mode 100644 index fa166d9..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt +++ /dev/null @@ -1,12 +0,0 @@ -Device-Tree bindings for hdmiddc driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmiddc". -- reg: I2C address of the hdmiddc device. - -Example: - - hdmiddc { - compatible = "samsung,exynos5-hdmiddc"; - reg = <0x50>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt deleted file mode 100644 index 858f4f9..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt +++ /dev/null @@ -1,12 +0,0 @@ -Device-Tree bindings for hdmiphy driver - -Required properties: -- compatible: value should be "samsung,exynos5-hdmiphy". -- reg: I2C address of the hdmiphy device. - -Example: - - hdmiphy { - compatible = "samsung,exynos5-hdmiphy"; - reg = <0x38>; - }; diff --git a/Documentation/devicetree/bindings/drm/exynos/mixer.txt b/Documentation/devicetree/bindings/drm/exynos/mixer.txt deleted file mode 100644 index 9b2ea03..0000000 --- a/Documentation/devicetree/bindings/drm/exynos/mixer.txt +++ /dev/null @@ -1,15 +0,0 @@ -Device-Tree bindings for mixer driver - -Required properties: -- compatible: value should be "samsung,exynos5-mixer". -- reg: physical base address of the mixer and length of memory mapped - region. -- interrupts: interrupt number to the cpu. - -Example: - - mixer { - compatible = "samsung,exynos5-mixer"; - reg = <0x14450000 0x10000>; - interrupts = <0 94 0>; - }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt new file mode 100644 index 0000000..4c48a83 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt @@ -0,0 +1,22 @@ +Device-Tree bindings for hdmi driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmi". +- reg: physical base address of the hdmi and length of memory mapped + region. +- interrupts: interrupt number to the cpu. +- hpd-gpio: following information about the hotplug gpio pin. + a) phandle of the gpio controller node. + b) pin number within the gpio controller. + c) pin function mode. + d) optional flags and pull up/down. + e) drive strength. + +Example: + + hdmi { + compatible = "samsung,exynos5-hdmi"; + reg = <0x14530000 0x100000>; + interrupts = <0 95 0>; + hpd-gpio = <&gpx3 7 0xf 1 3>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt new file mode 100644 index 0000000..fa166d9 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt @@ -0,0 +1,12 @@ +Device-Tree bindings for hdmiddc driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmiddc". +- reg: I2C address of the hdmiddc device. + +Example: + + hdmiddc { + compatible = "samsung,exynos5-hdmiddc"; + reg = <0x50>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt new file mode 100644 index 0000000..858f4f9 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_hdmiphy.txt @@ -0,0 +1,12 @@ +Device-Tree bindings for hdmiphy driver + +Required properties: +- compatible: value should be "samsung,exynos5-hdmiphy". +- reg: I2C address of the hdmiphy device. + +Example: + + hdmiphy { + compatible = "samsung,exynos5-hdmiphy"; + reg = <0x38>; + }; diff --git a/Documentation/devicetree/bindings/video/exynos_mixer.txt b/Documentation/devicetree/bindings/video/exynos_mixer.txt new file mode 100644 index 0000000..9b2ea03 --- /dev/null +++ b/Documentation/devicetree/bindings/video/exynos_mixer.txt @@ -0,0 +1,15 @@ +Device-Tree bindings for mixer driver + +Required properties: +- compatible: value should be "samsung,exynos5-mixer". +- reg: physical base address of the mixer and length of memory mapped + region. +- interrupts: interrupt number to the cpu. + +Example: + + mixer { + compatible = "samsung,exynos5-mixer"; + reg = <0x14450000 0x10000>; + interrupts = <0 94 0>; + };
Binding Documents for drm-devices are placed in Documentation/devicetree/bindings/drm/*. But these devices are common for v4l framework, hence moved to a common place Documentation/devicetree/bindings/video/. 'exynos_' prefix is added to associate them with exynos soc series. Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com> --- It is base on for-next branch of git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git .../devicetree/bindings/drm/exynos/hdmi.txt | 22 ---------------------- .../devicetree/bindings/drm/exynos/hdmiddc.txt | 12 ------------ .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ------------ .../devicetree/bindings/drm/exynos/mixer.txt | 15 --------------- .../devicetree/bindings/video/exynos_hdmi.txt | 22 ++++++++++++++++++++++ .../devicetree/bindings/video/exynos_hdmiddc.txt | 12 ++++++++++++ .../devicetree/bindings/video/exynos_hdmiphy.txt | 12 ++++++++++++ .../devicetree/bindings/video/exynos_mixer.txt | 15 +++++++++++++++ 8 files changed, 61 insertions(+), 61 deletions(-) delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmi.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiddc.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt delete mode 100644 Documentation/devicetree/bindings/drm/exynos/mixer.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmi.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiddc.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_hdmiphy.txt create mode 100644 Documentation/devicetree/bindings/video/exynos_mixer.txt