From patchwork Fri Mar 8 11:09:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 2236811 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 55818DF215 for ; Fri, 8 Mar 2013 11:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764Ab3CHLU0 (ORCPT ); Fri, 8 Mar 2013 06:20:26 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:54318 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732Ab3CHLU0 (ORCPT ); Fri, 8 Mar 2013 06:20:26 -0500 Received: by mail-pa0-f43.google.com with SMTP id bh2so1256184pad.16 for ; Fri, 08 Mar 2013 03:20:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=wHMqOrjnSnLTtT5GCVxEBe14ejG+Ti70AHyv8QWSvrM=; b=NN4TMz2wPU9byrlGHwzHCdJq7rgcG7zszatvdAmiWpOWMrpN5le0vRm9UpWTfEuCLv P5B+zndnIkwLMq53+4NDFIY9nCZnO+n9KGyBeBn58Aeuj57hLTAQuLhyMo6bI55s1lk2 kerQv7ulYIwGDsy3OcCbjzbLqiyHK6WD7QGNraI6vo/3oWqICWoCdR4Dvx+76PktxQ8z ZcYHWqolmgaseXAuNNZ0ugZi/PAft9hjCPktw2D5twKfuM3YV1sps7n2icF7A2kVipUW Tdd+UKY0vgFlVSjPYSOOL7N4nu+B9fTsYfOTgkYjwiAzaV/pAnwLFQj2Tbk6H0E2DEx/ dNOQ== X-Received: by 10.68.136.42 with SMTP id px10mr2774811pbb.32.1362741625659; Fri, 08 Mar 2013 03:20:25 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id e7sm2798892pbm.10.2013.03.08.03.20.22 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 08 Mar 2013 03:20:24 -0800 (PST) From: Tushar Behera To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: linux@arm.linux.org.uk, kgene.kim@samsung.com, patches@linaro.org Subject: [PATCH] ARM: EXYNOS: Use wfi macro in platform_do_lowpower Date: Fri, 8 Mar 2013 16:39:48 +0530 Message-Id: <1362740988-16483-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQl+U918T84PKFqNODyCasic3f5UKqAA7oIuSP8cy7fX4TlQN7x+e1IPZmk7A7ZtJmji9Z0U Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org As per commit b3377d186572 ("ARM: 7064/1: vexpress: Use wfi macro in platform_do_lowpower."), wfi macro should be used instead of the hardcoded WFI instruction. This fixes following oops when the kernel is compiled in Thumb-2 mode on EXYNOS5. (Tested on EXYNOS5250 based Arndale board) $ reboot Disabling non-boot CPUs ... IRQ153 no longer affine to CPU1 CPU1: shutdown Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP THUMB2 Modules linked in: CPU: 1 Not tainted (3.9.0-rc1-00015-gce76372 #1) PC is at 0xc065858e LR is at exynos_cpu_die+0x53/0xc0 Signed-off-by: Tushar Behera --- arch/arm/mach-exynos/hotplug.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index c3f825b..d9712fe 100644 --- a/arch/arm/mach-exynos/hotplug.c +++ b/arch/arm/mach-exynos/hotplug.c @@ -99,13 +99,7 @@ static inline void platform_do_lowpower(unsigned int cpu, int *spurious) if (cpu == 1) __raw_writel(0, S5P_ARM_CORE1_CONFIGURATION); - /* - * here's the WFI - */ - asm(".word 0xe320f003\n" - : - : - : "memory", "cc"); + wfi(); if (pen_release == cpu_logical_map(cpu)) { /*