diff mbox

[V3,1/2] ARM: dts: Add FIMD node to exynos5

Message ID 1363774955-22784-2-git-send-email-l.krishna@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Leela Krishna Amudala March 20, 2013, 10:22 a.m. UTC
This adds common FIMD device node for all Exynos5 SoCs

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Vikas Sajjan March 20, 2013, 11:39 a.m. UTC | #1
Hi Leela,

On Wed, Mar 20, 2013 at 3:52 PM, Leela Krishna Amudala
<l.krishna@samsung.com> wrote:
> This adds common FIMD device node for all Exynos5 SoCs
>
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 24c52e6..bd270b7 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -775,4 +775,14 @@
>                         samsung,enable-mask = <1>;
>                 };
>         };
> +
> +       fimd {
> +               compatible = "samsung,exynos5250-fimd";
> +               interrupt-parent = <&combiner>;
> +               reg = <0x14400000 0x40000>;
> +               interrupt-names = "fifo", "vsync", "lcd_sys";
> +               interrupts = <18 4>, <18 5>, <18 6>;
> +               clocks = <&clock 133>, <&clock 339>;
> +               clock-names = "sclk_fimd1", "fimd1";

I think the clock-names should be "sclk_fimd", "fimd";
since in the fimd driver during fimd_probe() we are doing
devm_clk_get(dev, "sclk_fimd")  and devm_clk_get(dev, "fimd")

> +       };
>  };
> --
> 1.8.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 24c52e6..bd270b7 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -775,4 +775,14 @@ 
 			samsung,enable-mask = <1>;
 		};
 	};
+
+	fimd {
+		compatible = "samsung,exynos5250-fimd";
+		interrupt-parent = <&combiner>;
+		reg = <0x14400000 0x40000>;
+		interrupt-names = "fifo", "vsync", "lcd_sys";
+		interrupts = <18 4>, <18 5>, <18 6>;
+		clocks = <&clock 133>, <&clock 339>;
+		clock-names = "sclk_fimd1", "fimd1";
+	};
 };