From patchwork Sun Apr 7 20:22:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 2403261 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 07721DF2A1 for ; Sun, 7 Apr 2013 20:23:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933836Ab3DGUXI (ORCPT ); Sun, 7 Apr 2013 16:23:08 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:61287 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933828Ab3DGUXH (ORCPT ); Sun, 7 Apr 2013 16:23:07 -0400 Received: by mail-ee0-f48.google.com with SMTP id b15so1977966eek.7 for ; Sun, 07 Apr 2013 13:23:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=z1oyYuopuTkRMuBqx1+T6ETTV4RkchOpJvs1diFmg7M=; b=oStdmS6wt8Lob4F6dGAi/s56VTi4MJnoD92HIUpxNd/whaEnxCj7AasIYmITnYI2V0 7sJAJAsmqQUHqepGf8WgnwU3vgzwmygyZEz7Ir6eNJhwiTX2A9F0UPbti24nU7RMlztz Nbj4EnNKYwAwk8U636yjlnE8lyQLKwr028toy3At2N0gLIAmMsV8AYYXfx3QvkS9AUg2 SwFZZnUdQQYDC/JeAMoTZ30HnpfsdeJzlA4/NCyG6vi5tciReACXNL8bT+vGPrh4Jl7g Y9tKK29cx+BIOjg2yXbL908SncCtJ5Ygz467sAoVaxrtIq9WVHVLf+TPVOwreZ5JLOTc CIMg== X-Received: by 10.14.179.201 with SMTP id h49mr41688418eem.26.1365366186310; Sun, 07 Apr 2013 13:23:06 -0700 (PDT) Received: from localhost.localdomain (093105185086.warszawa.vectranet.pl. [93.105.185.86]) by mx.google.com with ESMTPS id bj2sm3393335eeb.1.2013.04.07.13.23.02 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 07 Apr 2013 13:23:05 -0700 (PDT) From: Sylwester Nawrocki To: kgene.kim@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sylwester Nawrocki , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Tomasz Figa Subject: [PATCH] ARM: S3C24XX: Correct NR_IRQS definition for s3c2440 Date: Sun, 7 Apr 2013 22:22:50 +0200 Message-Id: <1365366170-9682-1-git-send-email-s.nawrocki@samsung.com> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Due to NR_IRQS being incorrectly defined not all IRQ domains can be registered for S3C2440. It causes following errors on a s3c2440 SoC based board: NR_IRQS:89 S3C2440: IRQ Support irq: clearing pending status 00000002 ------------[ cut here ]------------ WARNING: at kernel/irq/irqdomain.c:234 0xc0056ed0() ... irq: could not create irq-domain ... s3c2410-wdt s3c2410-wdt: failed to install irq (-22) s3c2410-wdt: probe of s3c2410-wdt failed with error -22 ... samsung-uart s3c2440-uart.0: cannot get irq 74 Fix this by increasing NR_IRQS to at least (IRQ_S3C2443_AC97 + 1) if CPU_S3C2440 is selected, so the subintc IRQ domain gets properly registered. Cc: Heiko Stübner Signed-off-by: Tomasz Figa Signed-off-by: Sylwester Nawrocki Acked-by: Heiko Stuebner --- arch/arm/mach-s3c24xx/include/mach/irqs.h | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-s3c24xx/include/mach/irqs.h b/arch/arm/mach-s3c24xx/include/mach/irqs.h index 43cada8..b6dd4cb 100644 --- a/arch/arm/mach-s3c24xx/include/mach/irqs.h +++ b/arch/arm/mach-s3c24xx/include/mach/irqs.h @@ -192,10 +192,8 @@ #if defined(CONFIG_CPU_S3C2416) #define NR_IRQS (IRQ_S3C2416_I2S1 + 1) -#elif defined(CONFIG_CPU_S3C2443) -#define NR_IRQS (IRQ_S3C2443_AC97+1) #else -#define NR_IRQS (IRQ_S3C2440_AC97+1) +#define NR_IRQS (IRQ_S3C2443_AC97 + 1) #endif /* compatibility define. */