From patchwork Mon Apr 8 16:58:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 2410391 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0A3BE3FC71 for ; Mon, 8 Apr 2013 16:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935097Ab3DHQ6e (ORCPT ); Mon, 8 Apr 2013 12:58:34 -0400 Received: from mail-ia0-f201.google.com ([209.85.210.201]:56162 "EHLO mail-ia0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935073Ab3DHQ6d (ORCPT ); Mon, 8 Apr 2013 12:58:33 -0400 Received: by mail-ia0-f201.google.com with SMTP id k25so404740iah.4 for ; Mon, 08 Apr 2013 09:58:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=MVJDtCdnn5bq04WMk1LAyqbUPaU4T3YhC7cVCN8p88o=; b=EzqJpo4Q35C57JAIKRprReTS+HZrHyTBVkO0Pl+cBzO2Z8v7HqhIaegFKH66Hp9uYp aw4+c7zaom9J9Bak5gkv0BAKfrV6xys6dyNdJnf2kdo5djrq0FyHkYL9Amv6Am240+GT lKPi25aDsDVePca0P1RbR5D+91B/FBOkRMibcoXK34xaoO7+xtvSCl/nBqgQxD/Fhjk5 +dY7p05cmE55FXjroHj1PvwkAvOBGV3/h8TrsoqCmL/5FLEzuGATF9K6M8H6nksfMUQm r2PE24lPSnPplWWJOTq+E58V9vZVWIue7ALybGI9HcJdBa+id4R4PzEogTMBc5xUbYvt pJtw== X-Received: by 10.43.136.5 with SMTP id ii5mr16923819icc.11.1365440307818; Mon, 08 Apr 2013 09:58:27 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id hn12si1669997igb.3.2013.04.08.09.58.27 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 08 Apr 2013 09:58:27 -0700 (PDT) Received: from tictac.mtv.corp.google.com (tictac.mtv.corp.google.com [172.22.162.34]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id B128A5A42A5; Mon, 8 Apr 2013 09:58:26 -0700 (PDT) Received: by tictac.mtv.corp.google.com (Postfix, from userid 121310) id 45E57811BE; Mon, 8 Apr 2013 09:58:26 -0700 (PDT) From: Doug Anderson To: Kukjin Kim Cc: Olof Johansson , Thomas Abraham , linux-samsung-soc@vger.kernel.org, Doug Anderson , Russell King , Jingoo Han , Padmavathi Venna , Giridhar Maruthy , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ARM: dts: Disable the RTC by default on exynos5 Date: Mon, 8 Apr 2013 09:58:15 -0700 Message-Id: <1365440295-4460-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 1.8.1.3 X-Gm-Message-State: ALoCoQmAbqwkWqS87ympKLrXlCxQqowPiTu9j5xxe4GhPACgVE1g4QQoha16ODU5kjFkHdK3+c28zJy2s4fOolMFmh1nt0vPnmZ+6kjF8Kr+/XLlFaw2QetFv1un97s27sRkgbyTMO3sqXucFaL/0rteg6qRz83isViclwEgA7xW4rRvcwnULmDuYhJ9nHRlXfFbHi4J84PUyvY1ajXWm7VvzsPsvu61RQ== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org This change makes the rtc on the exynos5250 and 5440 disabled by default to match exynos4. Ever since the common clock framework came in came in, exynos5250 boards have dumped lots of warnings in the boot log. It turns out that we don't see those on exynos4 since the rtc is disabled by default. While we need to get to the bottom of the problems with the RTC, it still makes sense to have the default state of the RTC on exynos boards match. For the record, warnings look like this: ------------[ cut here ]------------ WARNING: at /.../drivers/clk/clk.c:771 __clk_enable+0x34/0xb0() Modules linked in: [<80015bfc>] (unwind_backtrace+0x0/0xec) from [<804717f0>] (dump_stack+0x20/0x24) [<804717f0>] (dump_stack+0x20/0x24) from [<80023cd0>] (warn_slowpath_common+0x5c/0x7c) [<80023cd0>] (warn_slowpath_common+0x5c/0x7c) from [<80023d1c>] (warn_slowpath_null+0x2c/0x34) [<80023d1c>] (warn_slowpath_null+0x2c/0x34) from [<8035ddb0>] (__clk_enable+0x34/0xb0) [<8035ddb0>] (__clk_enable+0x34/0xb0) from [<8035de54>] (clk_enable+0x28/0x3c) [<8035de54>] (clk_enable+0x28/0x3c) from [<8031a160>] (s3c_rtc_probe+0xf4/0x434) [<8031a160>] (s3c_rtc_probe+0xf4/0x434) from [<8028e288>] (platform_drv_probe+0x24/0x28) [<8028e288>] (platform_drv_probe+0x24/0x28) from [<8028ce10>] (driver_probe_device+0xbc/0x22c) [<8028ce10>] (driver_probe_device+0xbc/0x22c) from [<8028cff8>] (__driver_attach+0x78/0x9c) [<8028cff8>] (__driver_attach+0x78/0x9c) from [<8028bdfc>] (bus_for_each_dev+0x64/0xac) [<8028bdfc>] (bus_for_each_dev+0x64/0xac) from [<8028c7e0>] (driver_attach+0x28/0x30) [<8028c7e0>] (driver_attach+0x28/0x30) from [<8028c43c>] (bus_add_driver+0xe0/0x234) [<8028c43c>] (bus_add_driver+0xe0/0x234) from [<8028d55c>] (driver_register+0xac/0x13c) [<8028d55c>] (driver_register+0xac/0x13c) from [<8028e4f4>] (platform_driver_register+0x54/0x68) [<8028e4f4>] (platform_driver_register+0x54/0x68) from [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c) [<8065c944>] (s3c_rtc_driver_init+0x14/0x1c) from [<800086d8>] (do_one_initcall+0x60/0x138) [<800086d8>] (do_one_initcall+0x60/0x138) from [<80633a8c>] (kernel_init_freeable+0x108/0x1d0) [<80633a8c>] (kernel_init_freeable+0x108/0x1d0) from [<8046d2f8>] (kernel_init+0x1c/0xf4) [<8046d2f8>] (kernel_init+0x1c/0xf4) from [<8000e358>] (ret_from_fork+0x14/0x20) ---[ end trace 4bcdc801c868d73f ]--- Signed-off-by: Doug Anderson --- arch/arm/boot/dts/exynos5250.dtsi | 1 + arch/arm/boot/dts/exynos5440.dtsi | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index dc55e33..892b724 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -183,6 +183,7 @@ interrupts = <0 43 0>, <0 44 0>; clocks = <&clock 337>; clock-names = "rtc"; + status = "disabled"; }; tmu@10060000 { diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index 25c6134..a8ceef4 100644 --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -181,5 +181,6 @@ interrupts = <0 17 0>, <0 16 0>; clocks = <&clock 21>; clock-names = "rtc"; + status = "disabled"; }; };