From patchwork Mon Jun 17 09:36:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2732321 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 161A7C0AB1 for ; Mon, 17 Jun 2013 09:51:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 39C172027A for ; Mon, 17 Jun 2013 09:51:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AF4F20288 for ; Mon, 17 Jun 2013 09:51:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932483Ab3FQJvW (ORCPT ); Mon, 17 Jun 2013 05:51:22 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:48370 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932350Ab3FQJvV (ORCPT ); Mon, 17 Jun 2013 05:51:21 -0400 Received: by mail-pd0-f172.google.com with SMTP id z10so2614188pdj.17 for ; Mon, 17 Jun 2013 02:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=oO4wtcTz43FiBzoLDd6F46+Bx5pcyUp11C4G9KdvqAA=; b=jI0S0n4vsxRNZKHgJicDUhynQgSlrUxsllgmLY+kRA/aVeCdgJk+BusIcAno6iMZch nPbFS6WMv95lZKR+1uZpRr5MVTuAa5WLLVxGQtZ6xtNxnPkMylwQ95cV254Bjc9T7c7x XNQkvveJPGyzvhZNl6mcUfMpPSFwwe82j6BYO7UspvV3qOJiSkzvwjcl/PvHcj9lgz5o Ch1HdZreyvD3eZPv51KIt2I7EgiIACFv7tbFkkfQRfugyQ3LDRbW40eqduGS7hW2ZIsv tIwqPX37jUEAdiBYueOAcTrULLzdEDQkmj8xjSU+ZNSO6BnxQB00PtzSF2Lme7hivFDE iSAg== X-Received: by 10.66.190.104 with SMTP id gp8mr12546142pac.84.1371462681003; Mon, 17 Jun 2013 02:51:21 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id vz8sm14233374pac.20.2013.06.17.02.51.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Jun 2013 02:51:20 -0700 (PDT) From: Sachin Kamat To: linux-kernel@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, linus.walleij@linaro.org, sachin.kamat@linaro.org, patches@linaro.org, Doug Anderson Subject: [PATCH 1/1] pinctrl: exynos: Fix build breakage Date: Mon, 17 Jun 2013 15:06:36 +0530 Message-Id: <1371461796-5061-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQk+4lDbAR1bNSrbs5ur3fsmPehFvY0qJN9dJ6IuMMbuMIvbE3mp1MFElmyK6zs5Nu2MnUWJ Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 'exynos_wkup_irq_mask' should be defined ahead of its call. Fixes the following error: drivers/pinctrl/pinctrl-exynos.c: In function ‘exynos_wkup_irq_mask’: drivers/pinctrl/pinctrl-exynos.c:299:3: error: implicit declaration of function ‘exynos_wkup_irq_ack’ [-Werror=implicit-function-declaration] exynos_wkup_irq_ack(irqd); Signed-off-by: Sachin Kamat Cc: Doug Anderson --- drivers/pinctrl/pinctrl-exynos.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-exynos.c b/drivers/pinctrl/pinctrl-exynos.c index 8cd5bf5..f9277bc 100644 --- a/drivers/pinctrl/pinctrl-exynos.c +++ b/drivers/pinctrl/pinctrl-exynos.c @@ -279,6 +279,15 @@ err_domains: return ret; } +static void exynos_wkup_irq_ack(struct irq_data *irqd) +{ + struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); + struct samsung_pinctrl_drv_data *d = b->drvdata; + unsigned long pend = d->ctrl->weint_pend + b->eint_offset; + + writel(1 << irqd->hwirq, d->virt_base + pend); +} + static void exynos_wkup_irq_mask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); @@ -307,15 +316,6 @@ static void exynos_wkup_irq_mask(struct irq_data *irqd) spin_unlock_irqrestore(&b->slock, flags); } -static void exynos_wkup_irq_ack(struct irq_data *irqd) -{ - struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd); - struct samsung_pinctrl_drv_data *d = b->drvdata; - unsigned long pend = d->ctrl->weint_pend + b->eint_offset; - - writel(1 << irqd->hwirq, d->virt_base + pend); -} - static void exynos_wkup_irq_unmask(struct irq_data *irqd) { struct samsung_pin_bank *b = irq_data_get_irq_chip_data(irqd);