From patchwork Fri Sep 27 10:29:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2953651 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 158F39F244 for ; Fri, 27 Sep 2013 10:30:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E3FC820318 for ; Fri, 27 Sep 2013 10:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDBB220334 for ; Fri, 27 Sep 2013 10:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672Ab3I0K3y (ORCPT ); Fri, 27 Sep 2013 06:29:54 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:51358 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619Ab3I0K3y (ORCPT ); Fri, 27 Sep 2013 06:29:54 -0400 Received: by mail-pd0-f182.google.com with SMTP id r10so2419305pdi.13 for ; Fri, 27 Sep 2013 03:29:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2qY/tIvC4zaMT4k0u0ytKF6wjL58icfVs2lVAdIZSFM=; b=TQw5zg5N7BFkm1BZW3oa9zb7fTVG4xmf59tBFayc9YfHYV2Phh9Rq6+zjTMNBg+iC5 G30kal/WeCc42wPGUBbyhvjH0A36PgZtWPVWJDJG4HNeutEUpK8tmcPuOOb0YiL+Zb6M rKUqabDgKI++5UXNOpKZs5TZhtky7xqeWaEUHBIXtaQrdhw7SxWss/LUFxvDUl8DIQzN aIDycMC2guGb8EROGq0CIBt75yF2zrSuYtuL/188Qg+/M/EGDVdwyoKoN6KJWOuExpBy HBEKQmYn+bjGsmuAARpGoQ2WsfPSHIA0mTB4f5pR5+H+m5DMiVq6sBQ8+xs+gGy/yBB/ ODKQ== X-Gm-Message-State: ALoCoQlHhE6HHgq63yN7m9pAuN2OIAG+YlphRjxdUzMenGN0Az7bP25BSx0j6tupxDb5QDaUc5Bn X-Received: by 10.66.248.161 with SMTP id yn1mr11024104pac.0.1380277793819; Fri, 27 Sep 2013 03:29:53 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id k4sm7905272pbd.11.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Sep 2013 03:29:53 -0700 (PDT) From: Sachin Kamat To: linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, tomasz.figa@gmail.com, sachin.kamat@linaro.org Subject: [PATCH 3/3] ARM: dts: Add reg property to regulator nodes in exynos5250-arndale Date: Fri, 27 Sep 2013 15:59:40 +0530 Message-Id: <1380277780-10903-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1380277780-10903-1-git-send-email-sachin.kamat@linaro.org> References: <1380277780-10903-1-git-send-email-sachin.kamat@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For consistency and correctness, since this is a bus, even if not physical, it is worth to add 'reg' property and unit-address to subnodes. The 'reg' property would merely be an index. Also for consistency, use "regulator" as node name as used most commonly across other dts files. Signed-off-by: Sachin Kamat --- arch/arm/boot/dts/exynos5250-arndale.dts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index cee55fa..0c42547 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -482,13 +482,15 @@ #address-cells = <1>; #size-cells = <0>; - main_dc_reg: fixedregulator@1 { + main_dc_reg: regulator@0 { compatible = "regulator-fixed"; + reg = <0>; regulator-name = "MAIN_DC"; }; - mmc_reg: voltage-regulator { + mmc_reg: regulator@1 { compatible = "regulator-fixed"; + reg = <1>; regulator-name = "VDD_33ON_2.8V"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; @@ -496,8 +498,9 @@ enable-active-high; }; - reg_hdmi_en: fixedregulator@0 { + reg_hdmi_en: regulator@2 { compatible = "regulator-fixed"; + reg = <2>; regulator-name = "hdmi-en"; }; };