From patchwork Wed Oct 9 06:29:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 3006561 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5F1D39F1E1 for ; Wed, 9 Oct 2013 06:32:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4A3532017A for ; Wed, 9 Oct 2013 06:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2987E2010A for ; Wed, 9 Oct 2013 06:32:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095Ab3JIGaq (ORCPT ); Wed, 9 Oct 2013 02:30:46 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:37377 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605Ab3JIGao (ORCPT ); Wed, 9 Oct 2013 02:30:44 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUE001CK22AXCL0@mailout4.samsung.com>; Wed, 09 Oct 2013 15:30:10 +0900 (KST) X-AuditID: cbfee61a-b7f7a6d00000235f-4b-5254f7f2e4a0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A8.8F.09055.2F7F4525; Wed, 09 Oct 2013 15:30:10 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUE004FY21WB380@mmp2.samsung.com>; Wed, 09 Oct 2013 15:30:10 +0900 (KST) From: Lukasz Majewski To: Zhang Rui , Eduardo Valentin , kgene.kim@samsung.com Cc: "Rafael J. Wysocki" , Linux PM list , Jonghwa Lee , Lukasz Majewski , Lukasz Majewski , linux-kernel , Bartlomiej Zolnierkiewicz , Tomasz Figa , Myungjoo Ham , devicetree@vger.kernel.org, Amit Daniel Kachhap , linux-samsung-soc@vger.kernel.org Subject: [PATCH v2 1/5] thermal: exynos: Remove check for thermal device pointer at exynos_report_trigger() Date: Wed, 09 Oct 2013 08:29:50 +0200 Message-id: <1381300194-13134-2-git-send-email-l.majewski@samsung.com> X-Mailer: git-send-email 1.7.10 In-reply-to: <1381300194-13134-1-git-send-email-l.majewski@samsung.com> References: <1380010102-25817-1-git-send-email-l.majewski@samsung.com> <1381300194-13134-1-git-send-email-l.majewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t9jQd1P30OCDP790LVouBpisXHGelaL +UfOsVqs2f+TyaLz7BNmi94FV9ks3jzitnjzcDOjxeVdc9gsPvceYbSYcX4fk8XtxhVsFmdO X2K1ePKwj81i/YzXLA78Hov3vGTyWDftLbPHlqvtLB59W1Yxehy/sZ3J4/MmuQC2KC6blNSc zLLUIn27BK6Mn9fvMxfM5amY+P8icwPjRq4uRg4OCQETifdzCrsYOYFMMYkL99azdTFycQgJ TGeU2POtlQXC6WKSaFmxnQWkik1AT+Lz3adMILaIQIbEqUuzmUCKmAX+Mktcn3YMrEhYIFfi 5etGdhCbRUBV4vu+3awg23gF3CQmXcmG2CYv8fR+HxuIzSngLnHwzjt2iGXNjBKPLm5imcDI u4CRYRWjaGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcLA+k9rBuLLB4hCjAAejEg/vA/6QICHW xLLiytxDjBIczEoivHkLgUK8KYmVValF+fFFpTmpxYcYpTlYlMR5D7RaBwoJpCeWpGanphak FsFkmTg4pRoYdezWv3nefIOJ7yPXwschM56InzqdlW8tYsATbHvosKMa44bGZbdeVblHLheX meDgwR6RwPPG7MWfpODUqwvb1/ou2JsZ1scukxJfWFes6DJJcf/Xgu7Y4nXPdz/RlXRL2qch 0JPSvTP0RtvHqz51eouzXleeEP27h+m1WO4JqeZXHy8b+05TYinOSDTUYi4qTgQAbPCtb1IC AAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 ("thermal: exynos: Add support for instance based register/unregister") broke check for presence of therm_dev at global thermal zone in exynos_report_trigger(). The resulting wrong test prevents thermal_zone_device_update() call, which calls handlers for situation when trip points are passed. Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. It turns out, that after exynos thermal subsystem redesign (at v3.12) this check is not needed, since it is not possible to register thermal zone without valid thermal device. Signed-off-by: Lukasz Majewski Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Tomasz Figa --- Changes for v2: - Remove check for th_zone->therm_dev at exynos_report_trigger() drivers/thermal/samsung/exynos_thermal_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c index f10a6ad..c2301da 100644 --- a/drivers/thermal/samsung/exynos_thermal_common.c +++ b/drivers/thermal/samsung/exynos_thermal_common.c @@ -310,8 +310,6 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; - if (th_zone->therm_dev) - return; if (th_zone->bind == false) { for (i = 0; i < th_zone->cool_dev_size; i++) {