| Message ID | 1387450673-331-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sachin, On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote: > Some boards might not have RTC xtal, so RTC shouldn't really be > enabled by default. Enable it in the required board files. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ > arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++ > arch/arm/boot/dts/exynos5420.dtsi | 2 +- > 3 files changed, 9 insertions(+), 1 deletion(-) Reviewed-by: Tomasz Figa <t.figa@samsung.com> By the way, can we expect a patch like this for Exynos 5250 to make all Exynos SoCs consistent about this? Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Tomasz, On 21 December 2013 02:42, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, > > On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote: >> Some boards might not have RTC xtal, so RTC shouldn't really be >> enabled by default. Enable it in the required board files. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++ >> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >> 3 files changed, 9 insertions(+), 1 deletion(-) > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> Thanks. > > By the way, can we expect a patch like this for Exynos 5250 to make all > Exynos SoCs consistent about this? Sure. That was my plan. --- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21 December 2013 02:42, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, > > On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote: >> Some boards might not have RTC xtal, so RTC shouldn't really be >> enabled by default. Enable it in the required board files. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++ >> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >> 3 files changed, 9 insertions(+), 1 deletion(-) > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> Ping Kukjin. Also the other patch for 5250.
On 01/03/14 19:08, Sachin Kamat wrote: > On 21 December 2013 02:42, Tomasz Figa<tomasz.figa@gmail.com> wrote: >> Hi Sachin, >> >> On Thursday 19 of December 2013 16:27:53 Sachin Kamat wrote: >>> Some boards might not have RTC xtal, so RTC shouldn't really be >>> enabled by default. Enable it in the required board files. >>> >>> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >>> --- >>> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ >>> arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++ >>> arch/arm/boot/dts/exynos5420.dtsi | 2 +- >>> 3 files changed, 9 insertions(+), 1 deletion(-) >> >> Reviewed-by: Tomasz Figa<t.figa@samsung.com> > > Ping Kukjin. Also the other patch for 5250. > Applied with 5250 related patch, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts index 9f3a3231158b..090117d595cb 100644 --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts @@ -38,6 +38,10 @@ }; }; + rtc@101E0000 { + status = "okay"; + }; + mmc@12200000 { status = "okay"; broken-cd; diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 62e1ebe4e989..edb4926f17d6 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -31,6 +31,10 @@ }; }; + rtc@101E0000 { + status = "okay"; + }; + mmc@12200000 { status = "okay"; broken-cd; diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 1c1a6a0db252..0b4bb87ae5f9 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi @@ -271,7 +271,7 @@ rtc@101E0000 { clocks = <&clock 317>; clock-names = "rtc"; - status = "okay"; + status = "disabled"; }; amba {
Some boards might not have RTC xtal, so RTC shouldn't really be enabled by default. Enable it in the required board files. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- arch/arm/boot/dts/exynos5420-arndale-octa.dts | 4 ++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 ++++ arch/arm/boot/dts/exynos5420.dtsi | 2 +- 3 files changed, 9 insertions(+), 1 deletion(-)