From patchwork Tue Jan 7 18:27:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 3449541 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D3F4BC02DC for ; Tue, 7 Jan 2014 18:27:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F610200E8 for ; Tue, 7 Jan 2014 18:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E9C44200DB for ; Tue, 7 Jan 2014 18:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753227AbaAGS1h (ORCPT ); Tue, 7 Jan 2014 13:27:37 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:56267 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbaAGS1g (ORCPT ); Tue, 7 Jan 2014 13:27:36 -0500 Received: by mail-we0-f179.google.com with SMTP id q59so494529wes.24 for ; Tue, 07 Jan 2014 10:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=8Gy7rwPrrmkfUb8PYbeLz8e7vAyKGnyZCxENQP8WtVk=; b=U9Nw8n7XwYNCDWoUWxgTShGqeJMhqUYnYUfsmiJ3GS1PmbE6xJCSOCMxHLLoaFwS3L 9ZJq06QoRNuvL2txNTkk2CVa7/y2mXjmFYBrL/5PGpTiXaK5x3QTVML8DwozijVoprbg Nma1DZpXg+JoxOLr8qvKTJBCzTjiIICXp0or52UFcJUC7FEa9L4t44YrhgS8wo339RP1 ybdg3745jqiJ5TGuPHsU9jIsaRCyDh8YFXBUopnXKXyZuRoXwvRHw7yDkvAJybxmSePg VbcUX5sFUKxZE1PE8hLqdQ8wl07cERk+yl0ALja52IVhzZsbt5+5xnT/HMbKHRgEol57 wuDw== X-Gm-Message-State: ALoCoQmkeFU0XUJj089j8PwVnVLPtghojcompz5otyxxFHuRDBJvVESB9Ktw30wOjzgZIc43p699 X-Received: by 10.195.13.234 with SMTP id fb10mr9210295wjd.50.1389119255847; Tue, 07 Jan 2014 10:27:35 -0800 (PST) Received: from localhost.localdomain ([85.235.11.236]) by mx.google.com with ESMTPSA id po3sm46086711wjc.3.2014.01.07.10.27.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 10:27:34 -0800 (PST) From: Linus Walleij To: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Kukjin Kim , Ben Dooks Cc: Linus Walleij , Heiko Stuebner , Tomasz Figa , Sylwester Nawrocki Subject: [PATCH] ARM: s3c24xx: fix build error Date: Tue, 7 Jan 2014 19:27:25 +0100 Message-Id: <1389119245-2167-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When enabling device tree on the S3C an additional build bug appears in the Osiris DVS board file: CC arch/arm/mach-s3c24xx/mach-osiris-dvs.o archh/arm/mach-s3c24xx/mach-osiris-dvs.c: In function ‘osiris_dvs_notify’: arch/arm/mach-s3c24xx/mach-osiris-dvs.c:77:4: error: implicit declaration of function ‘S3C2410_GPB’ [-Werror=implicit-function-declaration] gpio_set_value(OSIRIS_GPIO_DVS, 1); ^ Fix this by explicitly including Reported-by: Arnd Bergmann Cc: Kukjin Kim Cc: Heiko Stuebner Cc: Tomasz Figa Cc: Sylwester Nawrocki Cc: Ben Dooks Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Linus Walleij Acked-by: Heiko Stuebner --- I have tentatively applied this to the GPIO tree so I don't cause build regressions, ACKs are still appreciated from the S3C maintainers. --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c index 45e74363aaa9..5b8af46c0d6b 100644 --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c @@ -16,6 +16,7 @@ #include #include #include +#include #include