From patchwork Fri Jan 10 11:45:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naveen Krishna Chatradhi X-Patchwork-Id: 3465791 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0131E9F2E9 for ; Fri, 10 Jan 2014 11:45:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D9141200E8 for ; Fri, 10 Jan 2014 11:45:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD14C200DC for ; Fri, 10 Jan 2014 11:45:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751841AbaAJLpI (ORCPT ); Fri, 10 Jan 2014 06:45:08 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:44618 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbaAJLpF (ORCPT ); Fri, 10 Jan 2014 06:45:05 -0500 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZ6008I3ON40C70@mailout4.samsung.com>; Fri, 10 Jan 2014 20:45:04 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.124]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id C8.11.10364.04DDFC25; Fri, 10 Jan 2014 20:45:04 +0900 (KST) X-AuditID: cbfee690-b7f266d00000287c-3a-52cfdd40ddf0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 51.6D.28157.04DDFC25; Fri, 10 Jan 2014 20:45:04 +0900 (KST) Received: from username-ubuntu.sisodomain.com ([107.108.83.161]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MZ6006SJOMZPE80@mmp2.samsung.com>; Fri, 10 Jan 2014 20:45:03 +0900 (KST) From: Naveen Krishna Chatradhi To: linux-crypto@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, vzapolskiy@gmail.com, herbert@gondor.apana.org.au, naveenkrishna.ch@gmail.com, cpgs@samsung.com, tomasz.figa@gmail.com Subject: [PATCH 7/8 v3] crypto:s5p-sss: validate iv before memcpy Date: Fri, 10 Jan 2014 17:15:21 +0530 Message-id: <1389354321-32096-1-git-send-email-ch.naveen@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1389243640-13282-1-git-send-email-ch.naveen@samsung.com> References: <1389243640-13282-1-git-send-email-ch.naveen@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsWyRsSkRtfh7vkgg9mHDC1eHtK06H4lY3H/ 3k8mi8u75rBZzDi/j8li0bb/zBardv1htDg75xCTA4fHzll32T22HVD16NuyitHj8ya5AJYo LpuU1JzMstQifbsEroz/WxqZCy6wVTz49pipgXEraxcjJ4eEgInE9/X7GCFsMYkL99azdTFy cQgJLGWUWL5yEnMXIwdY0eWF1hDx6YwSq7f9YYJw+pkkTrbMBpvEJmAmcXDRanYQW0TAWeJ3 8xpWkCJmgTmMEg+XtLOATBIWcJRoblIAMVkEVCVWv1MDKecVcJW4+KqLDWKXgsScSTYgYU4B N4mtl5+ATRQCKplz4iozyEQJgXnsEou2vWUGSbAICEh8m3yIBaJXVmLTAWaIXyQlDq64wTKB UXgBI8MqRtHUguSC4qT0IhO94sTc4tK8dL3k/NxNjMDgPv3v2YQdjPcOWB9iTAYaN5FZSjQ5 HxgdeSXxhsZmRhamJqbGRuaWZqQJK4nzqj1KChISSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXA yLLBYs7mhnUedjt9JTb8X7twal7YowPmbBtzLtvv/qCYsbTretnSUKekT9/TnxssLPr7bePG Txobz/82bWfw/XLm+EbRJyVGWxuSRdoiPj3YFNopNfv4BvltzH1G8XPWLYzKyo+capnVsivm wqW/LMoXAjfcn/7riVCz4nnZ2sdPnhY8XPbnloUSS3FGoqEWc1FxIgBbV5r4hAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHIsWRmVeSWpSXmKPExsVy+t9jQV2Hu+eDDKat0rR4eUjTovuVjMX9 ez+ZLC7vmsNmMeP8PiaLRdv+M1us2vWH0eLsnENMDhweO2fdZffYdkDVo2/LKkaPz5vkAlii GhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4COUFIo S8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBm/N/SyFxwga3iwbfHTA2MW1m7 GDk4JARMJC4vtO5i5AQyxSQu3FvP1sXIxSEkMJ1RYvW2P0wQTj+TxMmW2awgVWwCZhIHF61m B7FFBJwlfjevYQUpYhaYwyjxcEk7C8hUYQFHieYmBRCTRUBVYvU7NZByXgFXiYuvutgg9ipI zJlkAxLmFHCT2Hr5CdhEIaCSOSeuMk9g5F3AyLCKUTS1ILmgOCk910ivODG3uDQvXS85P3cT Izh2nknvYFzVYHGIUYCDUYmHt2DW+SAh1sSy4srcQ4wSHMxKIrzmF4BCvCmJlVWpRfnxRaU5 qcWHGJOBbprILCWanA+M67ySeENjE3NTY1NLEwsTM0vShJXEeQ+2WgcKCaQnlqRmp6YWpBbB bGHi4JRqYJxjcG9D6pw3DjmHFP/zHbO1NVDcfamEUf1uUXa19umkj5dufbYOWZa6PGYyi/vX jVMsr6zxLivY4+d5lqOcX8jvFlf29PrmKt9VpjfkjXZ+krz3x6703uXHk7KW8Pu9iJ1tJ/i5 6GbVNkvGDZ9lr0pps7lX8f69V8TSnrDtqNTHTxf+vY1nEFViKc5INNRiLipOBADLxUck4QIA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds code to validate "iv" buffer before trying to memcpy the contents Signed-off-by: Naveen Krishna Chatradhi --- Changes since v2: None drivers/crypto/s5p-sss.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c index f274f5f..7058bb6 100644 --- a/drivers/crypto/s5p-sss.c +++ b/drivers/crypto/s5p-sss.c @@ -381,8 +381,9 @@ static void s5p_set_aes(struct s5p_aes_dev *dev, struct samsung_aes_variant *var = dev->variant; void __iomem *keystart; - memcpy(dev->ioaddr + SSS_REG_AES_IV_DATA - (var->aes_offset, 0), iv, 0x10); + if (iv) + memcpy(dev->ioaddr + SSS_REG_AES_IV_DATA + (var->aes_offset, 0), iv, 0x10); if (keylen == AES_KEYSIZE_256) keystart = dev->ioaddr +