From patchwork Tue Mar 4 09:34:34 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 3760501 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ABA81BF13A for ; Tue, 4 Mar 2014 09:40:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E19AA203DC for ; Tue, 4 Mar 2014 09:40:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3869203B6 for ; Tue, 4 Mar 2014 09:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756660AbaCDJk3 (ORCPT ); Tue, 4 Mar 2014 04:40:29 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:42909 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756569AbaCDJk2 (ORCPT ); Tue, 4 Mar 2014 04:40:28 -0500 Received: by mail-pd0-f172.google.com with SMTP id p10so4946335pdj.3 for ; Tue, 04 Mar 2014 01:40:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4hlv8zddSztEIZodZxlcxB8Ul8OwbxMLbzVJJNogve0=; b=ktcHl3yW6P3EmtS8EVhVOnj1IHE0SvZrB0kar735cYoal2I3I4E5pyRppP74/VsPK4 D+KcjCJS0G8+WXpzqk/VMdSt0ne/8kj1mc1wpICWYNymFje7MitHZS54JXHxw8jGE8li 9Dk1cxf6UhwqrbqKTYgoPzq3SNrrzStqGIcf/TjPb1IEw372BW0K0pfF9ing2CNYflEW vG9QwHhoHpP6ANpLBAWJLZueQ9b+4gu9WmXATvUvK/a+QzrGmRLeTJp8PYEh0WDyuKxg yj5GanJN2SbMV2dji2VJcbvAGYBTVfjW4WCDeG8qf5Olylnlpj4V7OYdzSmj267IAtex Rc+A== X-Gm-Message-State: ALoCoQk8eonTdH97it/qoGJOosxSA7yrZ2a+Jvd5Z4MoVr7HNmmd2Jwe72jZNkwlruVSX7IxooPB X-Received: by 10.66.136.71 with SMTP id py7mr5108100pab.2.1393926027756; Tue, 04 Mar 2014 01:40:27 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id gj9sm45620806pbc.7.2014.03.04.01.40.25 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Mar 2014 01:40:27 -0800 (PST) From: Sachin Kamat To: linux-watchdog@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, wim@iguana.be, sachin.kamat@linaro.org Subject: [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization Date: Tue, 4 Mar 2014 15:04:34 +0530 Message-Id: <1393925675-21636-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Initializing clk to NULL as a reset/error condition does not help as NULL is not an invalid condition w.r.t clk. Remove this initialization altogether as there is no state retention. Signed-off-by: Sachin Kamat Reviewed-by: Guenter Roeck --- drivers/watchdog/s3c2410_wdt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c index aba6cd46b45b..a0f8f771adec 100644 --- a/drivers/watchdog/s3c2410_wdt.c +++ b/drivers/watchdog/s3c2410_wdt.c @@ -607,7 +607,6 @@ static int s3c2410wdt_probe(struct platform_device *pdev) err_clk: clk_disable_unprepare(wdt->clock); - wdt->clock = NULL; err: return ret; @@ -627,7 +626,6 @@ static int s3c2410wdt_remove(struct platform_device *dev) s3c2410wdt_cpufreq_deregister(wdt); clk_disable_unprepare(wdt->clock); - wdt->clock = NULL; return 0; }