From patchwork Fri Apr 4 13:54:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vivek Gautam X-Patchwork-Id: 3938551 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3277D9F1EE for ; Fri, 4 Apr 2014 13:55:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 56CB120396 for ; Fri, 4 Apr 2014 13:55:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81F8C2038D for ; Fri, 4 Apr 2014 13:55:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbaDDNzD (ORCPT ); Fri, 4 Apr 2014 09:55:03 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:61635 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbaDDNy7 (ORCPT ); Fri, 4 Apr 2014 09:54:59 -0400 Received: by mail-pd0-f173.google.com with SMTP id z10so3362935pdj.4 for ; Fri, 04 Apr 2014 06:54:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=NajypBW+9HbMXPzmqTts6Z+ZdYO9Lg+or5056Yx30jA=; b=AEcoPSE9cwDAuQTb/sIDj+G3VCZChyWq8PWq2hwTzwqlO6jzXGDJ4IYpT/tV5XqDo5 S1VApQ7qu8avJA6vUKWCqGjdb8lZkr/xaCvcYtSiGCwww2VM/1oFGwObgZAUg7nMmMZF bEw3uE8vjGOAZM7iIcVwecP5XOKwmUWoHwrCHQTGeETJtZted2TmytFclVat/t6KQSHO U8dwCAn00ZSwAlKXtmvLL/JxVtc0LUzUM/Bh3DuJe4BfqSmFH8eUiyt074kNA7+3k1Ul G4r0tTX3rt86VqOvIi80INWZd08Asip0Yff6TOKRDJaxUvBvJ8ONZ5hA1ztuYC5xZ3tu FLiA== X-Received: by 10.66.141.231 with SMTP id rr7mr14943408pab.41.1396619698871; Fri, 04 Apr 2014 06:54:58 -0700 (PDT) Received: from vivek-linuxpc.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id sy2sm18020900pbc.28.2014.04.04.06.54.55 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 06:54:57 -0700 (PDT) From: Vivek Gautam To: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: gregkh@linuxfoundation.org, kgene.kim@samsung.com, Manjunath Goudar , Alan Stern Subject: [PATCH] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback Date: Fri, 4 Apr 2014 19:24:48 +0530 Message-Id: <1396619688-26857-1-git-send-email-gautam.vivek@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396618417-9560-1-git-send-email-gautam.vivek@samsung.com> References: <1396618417-9560-1-git-send-email-gautam.vivek@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Patch : 14982e3 USB: OHCI: Properly handle ohci-exynos suspend has already removed 'ohci_hcd' settings from exynos glue layer as a part of streamlining the ohci controller's suspend. So we don't need the locks for 'ohci_hcd' anymore. Signed-off-by: Vivek Gautam Cc: Manjunath Goudar Cc: Alan Stern --- drivers/usb/host/ohci-exynos.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c index 68588d8..9cf80cb 100644 --- a/drivers/usb/host/ohci-exynos.c +++ b/drivers/usb/host/ohci-exynos.c @@ -190,17 +190,13 @@ static int exynos_ohci_suspend(struct device *dev) { struct usb_hcd *hcd = dev_get_drvdata(dev); struct exynos_ohci_hcd *exynos_ohci = to_exynos_ohci(hcd); - struct ohci_hcd *ohci = hcd_to_ohci(hcd); struct platform_device *pdev = to_platform_device(dev); bool do_wakeup = device_may_wakeup(dev); - unsigned long flags; int rc = ohci_suspend(hcd, do_wakeup); if (rc) return rc; - spin_lock_irqsave(&ohci->lock, flags); - if (exynos_ohci->otg) exynos_ohci->otg->set_host(exynos_ohci->otg, &hcd->self); @@ -208,8 +204,6 @@ static int exynos_ohci_suspend(struct device *dev) clk_disable_unprepare(exynos_ohci->clk); - spin_unlock_irqrestore(&ohci->lock, flags); - return 0; }