From patchwork Wed Jun 4 12:13:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Hutchings X-Patchwork-Id: 4293531 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 61C599F333 for ; Wed, 4 Jun 2014 12:09:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 51D1E202D1 for ; Wed, 4 Jun 2014 12:09:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37250201C7 for ; Wed, 4 Jun 2014 12:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752577AbaFDMJR (ORCPT ); Wed, 4 Jun 2014 08:09:17 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:54743 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752497AbaFDMJR (ORCPT ); Wed, 4 Jun 2014 08:09:17 -0400 Received: from deadeye.wl.decadent.org.uk ([192.168.4.249]) by shadbolt.decadent.org.uk with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1WsA0I-0001s5-8u; Wed, 04 Jun 2014 13:09:14 +0100 Received: from ben by deadeye.wl.decadent.org.uk with local (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1WsA4Y-0006Hr-GZ; Wed, 04 Jun 2014 13:13:38 +0100 Message-ID: <1401884009.2412.73.camel@deadeye.wl.decadent.org.uk> Subject: Re: [PATCH v2 2/2] s5p-mfc: Adding MFC v7 and v8 firmwares From: Ben Hutchings To: Kamil Debski Cc: 'Arun Kumar K' , 'David Woodhouse' , 'linux-samsung-soc' , Tomasz Figa , linux-firmware@kernel.org Date: Wed, 04 Jun 2014 13:13:29 +0100 In-Reply-To: <01f601cf7fe5$5b325fa0$11971ee0$%debski@samsung.com> References: <1400676064-17819-1-git-send-email-arun.kk@samsung.com> <1400676064-17819-2-git-send-email-arun.kk@samsung.com> <1401824047.2412.7.camel@deadeye.wl.decadent.org.uk> <1401837995.2412.45.camel@deadeye.wl.decadent.org.uk> <01f601cf7fe5$5b325fa0$11971ee0$%debski@samsung.com> X-Mailer: Evolution 3.12.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 192.168.4.249 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 2014-06-04 at 13:08 +0200, Kamil Debski wrote: > Hi Arun, Ben, > > > > From: arunkk.samsung@gmail.com [mailto:arunkk.samsung@gmail.com] On > > Behalf Of Arun Kumar K > > Sent: Wednesday, June 04, 2014 7:32 AM > > > > Hi Ben, > > > > On Wed, Jun 4, 2014 at 4:56 AM, Ben Hutchings > > wrote: > > > On Tue, 2014-06-03 at 20:34 +0100, Ben Hutchings wrote: > > >> On Wed, 2014-05-21 at 18:11 +0530, Arun Kumar K wrote: > > >> > Adding the following firmware files for MFC > > >> > s5p-mfc-v7.fw: Used in exynos 5420 > > >> > s5p-mfc-v8.fw: Used in exynos 5800 > > >> > > > >> > Signed-off-by: Arun Kumar K > > >> > --- > > >> > Changes from v1 > > >> > - None > > >> > --- > > >> > WHENCE | 2 ++ > > >> > s5p-mfc/s5p-mfc-v7.fw | Bin 0 -> 382724 bytes > > >> > s5p-mfc/s5p-mfc-v8.fw | Bin 0 -> 360576 bytes > > >> > 3 files changed, 2 insertions(+) > > >> > create mode 100644 s5p-mfc/s5p-mfc-v7.fw create mode 100644 > > >> > s5p-mfc/s5p-mfc-v8.fw > > >> [...] > > >> > > >> Applied, thanks. > > > > > > Just noticed a problem with all the s5p-mfc firmware: you are putting > > > it in the s5p-mfc subdirectory, so distribution packages will install > > > them in /lib/firmware/s5p-mfc. However, unless I'm mistaken your > > > driver requests it with a bare filename (e.g. "s5p-mfc-v7.fw") so it > > > won't be found. > > > > > > > Yes this issue is there. > > Kamil, are you ok with changing the fw load path to s5p-mfc/s5p-mfc*.fw > > in the driver? > > We have two options here: > 1) Change the driver to request s5p-mfc/sp5-mfc-fw* > 2) Move the files in the firmware repository > > I would opt for the second option. The driver was uploaded before the > firmware. I see that there are many firmware files in the root folder > of the repository > > Ben, what is your opinion? Which is preferred: creating subdirectories > or storing firmware in the root folder? I prefer subdirectories, but compatibility wins. So I'll apply the following patch if no-one objects. Ben. --- Subject: Move the s5p-mfc firmware out of its subdirectory The driver does not include this subdirectory name when requesting firmware. Signed-off-by: Ben Hutchings --- WHENCE | 10 +++++----- s5p-mfc/s5p-mfc-v6-v2.fw => s5p-mfc-v6-v2.fw | Bin s5p-mfc/s5p-mfc-v6.fw => s5p-mfc-v6.fw | Bin s5p-mfc/s5p-mfc-v7.fw => s5p-mfc-v7.fw | Bin s5p-mfc/s5p-mfc-v8.fw => s5p-mfc-v8.fw | Bin s5p-mfc/s5p-mfc.fw => s5p-mfc.fw | Bin 6 files changed, 5 insertions(+), 5 deletions(-) rename s5p-mfc/s5p-mfc-v6-v2.fw => s5p-mfc-v6-v2.fw (100%) rename s5p-mfc/s5p-mfc-v6.fw => s5p-mfc-v6.fw (100%) rename s5p-mfc/s5p-mfc-v7.fw => s5p-mfc-v7.fw (100%) rename s5p-mfc/s5p-mfc-v8.fw => s5p-mfc-v8.fw (100%) rename s5p-mfc/s5p-mfc.fw => s5p-mfc.fw (100%) diff --git a/s5p-mfc/s5p-mfc-v6-v2.fw b/s5p-mfc-v6-v2.fw similarity index 100% rename from s5p-mfc/s5p-mfc-v6-v2.fw rename to s5p-mfc-v6-v2.fw diff --git a/s5p-mfc/s5p-mfc-v6.fw b/s5p-mfc-v6.fw similarity index 100% rename from s5p-mfc/s5p-mfc-v6.fw rename to s5p-mfc-v6.fw diff --git a/s5p-mfc/s5p-mfc-v7.fw b/s5p-mfc-v7.fw similarity index 100% rename from s5p-mfc/s5p-mfc-v7.fw rename to s5p-mfc-v7.fw diff --git a/s5p-mfc/s5p-mfc-v8.fw b/s5p-mfc-v8.fw similarity index 100% rename from s5p-mfc/s5p-mfc-v8.fw rename to s5p-mfc-v8.fw diff --git a/s5p-mfc/s5p-mfc.fw b/s5p-mfc.fw similarity index 100% rename from s5p-mfc/s5p-mfc.fw rename to s5p-mfc.fw diff --git a/WHENCE b/WHENCE index 6a64fc2..a172f5f 100644 --- a/WHENCE +++ b/WHENCE @@ -2250,11 +2250,11 @@ Licence: Redistributable. See LICENCE.atheros_firmware for details Driver: s5p-mfc - Samsung MFC video encoder/decoder driver -File: s5p-mfc/s5p-mfc.fw -File: s5p-mfc/s5p-mfc-v6.fw -File: s5p-mfc/s5p-mfc-v6-v2.fw -File: s5p-mfc/s5p-mfc-v7.fw -File: s5p-mfc/s5p-mfc-v8.fw +File: s5p-mfc.fw +File: s5p-mfc-v6.fw +File: s5p-mfc-v6-v2.fw +File: s5p-mfc-v7.fw +File: s5p-mfc-v8.fw Licence: Samsung grants permission to use and redistribute aforementioned firmware