From patchwork Mon Jun 23 05:32:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Sharma X-Patchwork-Id: 4399341 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 32A079F26E for ; Mon, 23 Jun 2014 05:33:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72946202B8 for ; Mon, 23 Jun 2014 05:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8502E202B4 for ; Mon, 23 Jun 2014 05:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751122AbaFWFd3 (ORCPT ); Mon, 23 Jun 2014 01:33:29 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:42839 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbaFWFd2 (ORCPT ); Mon, 23 Jun 2014 01:33:28 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N7L00KG5WRREOD0@mailout4.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 23 Jun 2014 14:33:27 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.123]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 03.3D.13369.72CB7A35; Mon, 23 Jun 2014 14:33:27 +0900 (KST) X-AuditID: cbfee690-b7fb56d000003439-21-53a7bc27d172 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D2.79.04943.62CB7A35; Mon, 23 Jun 2014 14:33:27 +0900 (KST) Received: from localhost.localdomain ([107.108.83.245]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N7L00JJKWRH6C90@mmp2.samsung.com>; Mon, 23 Jun 2014 14:33:26 +0900 (KST) From: Rahul Sharma To: dri-devel@lists.freedesktop.org Cc: linux-samsung-soc@vger.kernel.org, inki.dae@samsung.com, kgene.kim@samsung.com, joshi@samsung.com, r.sh.open@gmail.com, Rahul Sharma Subject: [PATCH 3/5 v2] drm/exynos: allow mulitple layer updates per vsync for mixer Date: Mon, 23 Jun 2014 11:02:23 +0530 Message-id: <1403501545-16482-4-git-send-email-rahul.sharma@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1403501545-16482-1-git-send-email-rahul.sharma@samsung.com> References: <1403501545-16482-1-git-send-email-rahul.sharma@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsWyRsSkWld9z/Jgg5YdPBZXvr5ns5h0fwKL xfddX9gtehdcZbOYcX4fk8XCF/EWUxYdZnVg99g56y67x/3u40wefVtWMXp83iQXwBLFZZOS mpNZllqkb5fAlXHlWgNbQRNnxapZj5kaGM+zdzFyckgImEj8uPuOGcIWk7hwbz1bFyMXh5DA UkaJo72bWGCK1u/fxwqRmM4oMan5LlRVO5PEzi17mUCq2AR0JWYffMYIYosIKEv8nbiKEaSI WWA5o8TLzS1sIAlhgTCJczu/gNksAqoST9dPBbN5BTwkbi85AzSIA2idgsScSTYgYU4BT4mu S9/BZgoBlTx8tADq7H52iWXXMiHGCEh8m3yIBaJVVmLTAahvJCUOrrjBMoFReAEjwypG0dSC 5ILipPQiE73ixNzi0rx0veT83E2MwNA+/e/ZhB2M9w5YH2JMBho3kVlKNDkfGBt5JfGGxmZG FqYmpsZG5pZmpAkrifOqPUoKEhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cC43GN95WdLzUX3 nv298ibI2/rk1ncypx7GlZjKyqwQFgt07BDZnCCkrpkWt+PK5/CFU1bu3szC/uiE1ZyWf39m rfq9an7hBbngb93LE0KEy9e+3/ri+KXEi21PDtfu9VhvO4thUf7y5BTT5f4fi2MWfvARb9Gy FKmSWyE7rbQqp2La07SOc5r7lFiKMxINtZiLihMBIrkKIYMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAIsWRmVeSWpSXmKPExsVy+t9jQV31PcuDDSZ9YrG48vU9m8Wk+xNY LL7v+sJu0bvgKpvFjPP7mCwWvoi3mLLoMKsDu8fOWXfZPe53H2fy6NuyitHj8ya5AJaoBkab jNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKALlBTKEnNK gUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGENYwZV641sBU0cVasmvWYqYHxPHsXIyeH hICJxPr9+1ghbDGJC/fWs3UxcnEICUxnlJjUfBfKaWeS2LllLxNIFZuArsTsg88YQWwRAWWJ vxNXMYIUMQssZ5R4ubmFDSQhLBAmcW7nFzCbRUBV4un6qWA2r4CHxO0lZ4AGcQCtU5CYM8kG JMwp4CnRdek72EwhoJKHjxawT2DkXcDIsIpRNLUguaA4KT3XUK84Mbe4NC9dLzk/dxMjOHae Se1gXNlgcYhRgINRiYdXw215sBBrYllxZe4hRgkOZiUR3sYGoBBvSmJlVWpRfnxRaU5q8SFG U6CjJjJLiSbnA+M6ryTe0NjE3NTY1NLEwsTMUkmc90CrdaCQQHpiSWp2ampBahFMHxMHp1QD 47K+38qHkuxNbvLuZcrxnHiYxe7Btlybtf4eysuEd5efYOnd3HNYibOka2mYx4Jjl8v+m+Vr zb/5e9PSSZ+krj0Tn2+l/eeDjAr7ekF9TskLZz8IWzNV2k84xl/Af3b7p/sLzh496d7Cxut1 uzdebH9zoqKAw96Vj3zFarlqele9O3X68dQ1J5RYijMSDbWYi4oTARu0ujqzAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Allowing only one layer update per vsync can cause issues while there are update available for both layers. There is a good amount of possibility to loose updates if we allow single update per vsync. Signed-off-by: Rahul Sharma --- drivers/gpu/drm/exynos/exynos_mixer.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index d359501..6773b03 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -511,13 +511,8 @@ static void vp_video_buffer(struct mixer_context *ctx, int win) static void mixer_layer_update(struct mixer_context *ctx) { struct mixer_resources *res = &ctx->mixer_res; - u32 val; - - val = mixer_reg_read(res, MXR_CFG); - /* allow one update per vsync only */ - if (!(val & MXR_CFG_LAYER_UPDATE_COUNT_MASK)) - mixer_reg_writemask(res, MXR_CFG, ~0, MXR_CFG_LAYER_UPDATE); + mixer_reg_writemask(res, MXR_CFG, ~0, MXR_CFG_LAYER_UPDATE); } static void mixer_graph_buffer(struct mixer_context *ctx, int win)