| Message ID | 1405337093-15377-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote: > Building of EXYNOS5420_MCPM with disabled SUSPEND fails: > arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init': > arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback' > > The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which > depends on cpu_suspend function (ARM_CPU_SUSPEND). > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Cc: <stable@vger.kernel.org> No need to CC stable here as this code has not reached a released kernel yet. > Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback") And this is not clear yet if this commit ID is stable. Other than that: Acked-by: Nicolas Pitre <nico@linaro.org> Please send to RMK's patch system. > --- > arch/arm/mach-exynos/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 8f9b66c4ac78..5d4ff6571dcd 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM > bool "Exynos5420 Multi-Cluster PM support" > depends on MCPM && SOC_EXYNOS5420 > select ARM_CCI > + select ARM_CPU_SUSPEND > help > This is needed to provide CPU and cluster power management > on Exynos5420 implementing big.LITTLE. > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On pon, 2014-07-14 at 07:35 -0400, Nicolas Pitre wrote: > On Mon, 14 Jul 2014, Krzysztof Kozlowski wrote: > > > Building of EXYNOS5420_MCPM with disabled SUSPEND fails: > > arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init': > > arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback' > > > > The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which > > depends on cpu_suspend function (ARM_CPU_SUSPEND). > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > Cc: <stable@vger.kernel.org> > > No need to CC stable here as this code has not reached a released kernel > yet. > > > Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback") > > And this is not clear yet if this commit ID is stable. > > Other than that: > > Acked-by: Nicolas Pitre <nico@linaro.org> > > Please send to RMK's patch system. Sure, I'll remove the cc-stable tag, add your ack and send to the patch system. Thanks, Krzysztof > > > > --- > > arch/arm/mach-exynos/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > > index 8f9b66c4ac78..5d4ff6571dcd 100644 > > --- a/arch/arm/mach-exynos/Kconfig > > +++ b/arch/arm/mach-exynos/Kconfig > > @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM > > bool "Exynos5420 Multi-Cluster PM support" > > depends on MCPM && SOC_EXYNOS5420 > > select ARM_CCI > > + select ARM_CPU_SUSPEND > > help > > This is needed to provide CPU and cluster power management > > on Exynos5420 implementing big.LITTLE. > > -- > > 1.9.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 8f9b66c4ac78..5d4ff6571dcd 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -119,6 +119,7 @@ config EXYNOS5420_MCPM bool "Exynos5420 Multi-Cluster PM support" depends on MCPM && SOC_EXYNOS5420 select ARM_CCI + select ARM_CPU_SUSPEND help This is needed to provide CPU and cluster power management on Exynos5420 implementing big.LITTLE.
Building of EXYNOS5420_MCPM with disabled SUSPEND fails: arch/arm/mach-exynos/built-in.o: In function `exynos_mcpm_init': arch/arm/mach-exynos/mcpm-exynos.c:361: undefined reference to `mcpm_loopback' The exynos_mcpm_init() in mcp-exynos.c calls mcpm_loopback() which depends on cpu_suspend function (ARM_CPU_SUSPEND). Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: <stable@vger.kernel.org> Fixes: a6a4d3152e3cbb6 ("ARM: 8083/1: exynos: activate the CCI on boot CPU/cluster using the MCPM loopback") --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+)