From patchwork Mon Jul 14 11:37:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naveen Krishna Chatradhi X-Patchwork-Id: 4545191 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E3E7AC0514 for ; Mon, 14 Jul 2014 11:41:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03CD920136 for ; Mon, 14 Jul 2014 11:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 158E22013D for ; Mon, 14 Jul 2014 11:41:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444AbaGNLlN (ORCPT ); Mon, 14 Jul 2014 07:41:13 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38377 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754477AbaGNLlF (ORCPT ); Mon, 14 Jul 2014 07:41:05 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N8P00IHG9SF9I10@mailout2.samsung.com>; Mon, 14 Jul 2014 20:41:04 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.122]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id A5.3E.16580.FC1C3C35; Mon, 14 Jul 2014 20:41:03 +0900 (KST) X-AuditID: cbfee691-b7f2f6d0000040c4-7e-53c3c1cf576a Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 61.F6.05196.FC1C3C35; Mon, 14 Jul 2014 20:41:03 +0900 (KST) Received: from chnaveen-ubuntu.sisodomain.com ([107.108.83.161]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N8P00BXR9RQIVA0@mmp2.samsung.com>; Mon, 14 Jul 2014 20:41:03 +0900 (KST) From: Naveen Krishna Chatradhi To: kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: gregkh@linuxfoundation.org, ben-linux@fluff.org, cpgs@samsung.com Subject: [PATCH 2/3] serial: samsung: correct the case and default order in switch Date: Mon, 14 Jul 2014 17:07:17 +0530 Message-id: <1405337838-30335-3-git-send-email-ch.naveen@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1405337838-30335-1-git-send-email-ch.naveen@samsung.com> References: <1405337838-30335-1-git-send-email-ch.naveen@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsWyRsSkSvf8wcPBBusvmFtMWneAyeLlIU2L +UfOsVo0L17PZtG74CqbxabH11gtZpzfx+TA7vF31Qtmj/1z17B7bF5S79G3ZRWjx+dNcgGs UVw2Kak5mWWpRfp2CVwZp+f2sBb0s1VMbsxoYPzK0sXIySEhYCIxbcZtZghbTOLCvfVsXYxc HEICSxklWudNZoMp2rdnMhOILSQwnVHi0a5iiKJ+JomLL66CJdgEzCQOLlrNDpIQEWhglGhZ /IgdJMEs4Cqxc8dCsHXCAiES/87uBouzCKhKzLy/CMzmBapZ/HQaaxcjB9A2BYk5k2xAwpwC bhI7/nYwQyx2lbh8to0R4qDJ7BLnm7MhxghIfJt8iAWiVVZi0wGoZyQlDq64wTKBUXgBI8Mq RtHUguSC4qT0IlO94sTc4tK8dL3k/NxNjMDwPv3v2cQdjPcPWB9iTAYaN5FZSjQ5HxgfeSXx hsZmRhamJqbGRuaWZqQJK4nzpj9KChISSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAaF18f5qg 9cmWxNXdU+R+KfG7X9CZKzlTJYu/KFzBpnnBqds+cid/pO9hM1Bpt9NYu/TeujVzxaY/N+e1 SNbftOnb04kL8tZ05rvODklf3+rzdn9FNMvcwvurfipPUFA5rbVQgfnIYe/Ak1r8Dz7wv2+v KV1qv/ggu9Csbes/JhZ87mMPSPLmU2Ipzkg01GIuKk4EADuCtbmFAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEIsWRmVeSWpSXmKPExsVy+t9jQd3zBw8HG5yYa2Axad0BJouXhzQt 5h85x2rRvHg9m0XvgqtsFpseX2O1mHF+H5MDu8ffVS+YPfbPXcPusXlJvUffllWMHp83yQWw RjUw2mSkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAXaGk UJaYUwoUCkgsLlbSt8M0ITTETdcCpjFC1zckCK7HyAANJKxhzDg9t4e1oJ+tYnJjRgPjV5Yu Rk4OCQETiX17JjNB2GISF+6tZwOxhQSmM0o82lXcxcgFZPczSVx8cRWsiE3ATOLgotXsIAkR gQZGiZbFj9hBEswCrhI7dywEmyosECLx7+xusDiLgKrEzPuLwGxeoJrFT6exdjFyAG1TkJgz yQYkzCngJrHjbwczxGJXictn2xgnMPIuYGRYxSiaWpBcUJyUnmukV5yYW1yal66XnJ+7iREc P8+kdzCuarA4xCjAwajEw5vBcThYiDWxrLgy9xCjBAezkgivxz6gEG9KYmVValF+fFFpTmrx IUZToKMmMkuJJucDYzuvJN7Q2MTc1NjU0sTCxMxSSZz3YKt1oJBAemJJanZqakFqEUwfEwen VANjwCylauYTxVt+7flYyc+72X7rVU1ruS+6gj+LFvV91b/9XPxJRKCp08qZ3rvZeZQm/DkQ uFN0mtbyjg1hMdOubL6ivOu8xXJL503/4x7EPy+yU3Vy/e5T+zRq6o2GtO7+AMfacJai6VGV jDs7vlRYW7X1XddKsdkRwGX28b8Lc49nAq/ux81KLMUZiYZazEXFiQCSyxdttQIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The cases should comes before default in a switch. Even if we want the case and default to share same code. Its good to define the case first followed by default. Signed-off-by: Naveen Krishna Chatradhi Cc: gregkh@linuxfoundation.org --- drivers/tty/serial/samsung.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index e49a945..d98f93d 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -1542,8 +1542,8 @@ s3c24xx_serial_get_options(struct uart_port *port, int *baud, case S3C2410_LCON_CS7: *bits = 7; break; - default: case S3C2410_LCON_CS8: + default: *bits = 8; break; }