From patchwork Fri Aug 15 12:40:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 4727051 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1B9D0C033A for ; Fri, 15 Aug 2014 12:42:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 504EE201BC for ; Fri, 15 Aug 2014 12:42:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 59056201F5 for ; Fri, 15 Aug 2014 12:42:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbaHOMkc (ORCPT ); Fri, 15 Aug 2014 08:40:32 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:57457 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbaHOMka (ORCPT ); Fri, 15 Aug 2014 08:40:30 -0400 Received: by mail-we0-f172.google.com with SMTP id x48so2315056wes.3 for ; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cTK4XD79/qSARMLN/rcoYrZ5691unUddBcsFw7ooLvI=; b=O40hVMPUS9V1rJZWdGZrTibrdWKsVqJEVVQ0toOt/MTNVShok/B8sI/+lVJlQHBR66 DUnmZkC8FE/rICi0NzI6jbXmAFdONOWhhFxbFjh+XokyprQ/24WQNmRLlxr3og3Hl46q oAS7BzcIQZ5Dh27aX0uFxbbXs3/tZLNj0iBTQStoXeG5r1VenoYQfPP+ut7y0LF7oUit RhbRiv4Vp8TrMECkzJqVw14i7Lk7gfgzgt4AJUwg7i7owzccHuKE6e9xCs+LJEJdX2Ae u7Oa7Mc8Gu/lx0TMpuk6MNe9LnLbbPY5x4p3CEALkkKjwg2D1WZ9rzU75m+vwj6TsBIl Wsmg== X-Gm-Message-State: ALoCoQnOuo++lhPAl6Rwz4uqLRApXJfjqlHUtiP1fNp95WevPuXiLdGWr9Wrl6gOSzi8Ad5W8ijs X-Received: by 10.180.19.200 with SMTP id h8mr54624233wie.32.1408106429060; Fri, 15 Aug 2014 05:40:29 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:28 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 4/9] phy: phy-ti-pipe3: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:11 +0100 Message-Id: <1408106416-19044-5-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-ti-pipe3.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c index b964aa9..9280ef8 100644 --- a/drivers/phy/phy-ti-pipe3.c +++ b/drivers/phy/phy-ti-pipe3.c @@ -299,10 +299,9 @@ static int ti_pipe3_probe(struct platform_device *pdev) struct clk *clk; phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); - if (!phy) { - dev_err(&pdev->dev, "unable to alloc mem for TI PIPE3 PHY\n"); + if (!phy) return -ENOMEM; - } + phy->dev = &pdev->dev; if (!of_device_is_compatible(node, "ti,phy-pipe3-pcie")) {