| Message ID | 1415025649-8119-10-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 282179105d5403d991d2510ec74d1031695b3ef0 |
| Headers | show |
On Mon, Nov 03, 2014 at 03:40:44PM +0100, Javier Martinez Canillas wrote: > The struct of_regulator_match rmatch[] is declared as a non-static local > variable so the structure members are not auto-initialized. Applied, thanks.
diff --git a/drivers/regulator/s2mpa01.c b/drivers/regulator/s2mpa01.c index 2263071..5db4e12 100644 --- a/drivers/regulator/s2mpa01.c +++ b/drivers/regulator/s2mpa01.c @@ -341,7 +341,7 @@ static int s2mpa01_pmic_probe(struct platform_device *pdev) { struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent); struct sec_platform_data *pdata = dev_get_platdata(iodev->dev); - struct of_regulator_match rdata[S2MPA01_REGULATOR_MAX]; + struct of_regulator_match rdata[S2MPA01_REGULATOR_MAX] = { }; struct device_node *reg_np = NULL; struct regulator_config config = { }; struct s2mpa01_info *s2mpa01;
The struct of_regulator_match rmatch[] is declared as a non-static local variable so the structure members are not auto-initialized. Initialize the array at declaration time to avoid the structure members values to be indeterminate and have sane defaults instead. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- drivers/regulator/s2mpa01.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)