From patchwork Tue Nov 18 19:10:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baker X-Patchwork-Id: 5332731 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 90B3C9F2ED for ; Tue, 18 Nov 2014 19:11:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E3D622018E for ; Tue, 18 Nov 2014 19:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02BF2200D5 for ; Tue, 18 Nov 2014 19:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbaKRTL0 (ORCPT ); Tue, 18 Nov 2014 14:11:26 -0500 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33553 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755051AbaKRTLZ (ORCPT ); Tue, 18 Nov 2014 14:11:25 -0500 Received: by mail-pd0-f176.google.com with SMTP id y10so4578543pdj.35 for ; Tue, 18 Nov 2014 11:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zWH7PaQ04lCO+BO5OAwbR9ZAo9rnvDggSaFXBwxm9Zk=; b=S5fI4+cPep+K5TrxsMVLBSdhrYwwQU3FNFtHrwW/qwi7B/9VA55JiuQkt+4XHEmLdr UKRWcCRFRi7fL/tX0i0jw+t0gupK4vWrp91QZlnPEKdf+KJ2Rj7KacPmh2CLc2C1zMbu H25uZKqMunib6XkNs2wTywCV9hzW5q3+fQPbh8X6QNj9Uhmyc4RX407g+GVB1yNsZXzR n88P6hGmDlkSwztMi3it7IOUY2PUfUo6Ie/8R6v0Cd0qNnTN4Hh/M+UEeTLUAMdiCCYe P/gNNpxQU4Sh3dzL9rdCjjGga/k0soQxs8/f5IS9ZCOVN9A+pjE6RsS15g9J+XJvsJIB 8sVg== X-Gm-Message-State: ALoCoQmyRSj43MrnmOs/MvaAk0Ur7Tie4ksdVQAyCY6CmvM9rC4R9TZh72CcWVk8R2IAGB8VeGUj X-Received: by 10.70.32.197 with SMTP id l5mr29208096pdi.67.1416337885183; Tue, 18 Nov 2014 11:11:25 -0800 (PST) Received: from localhost.localdomain ([173.14.250.228]) by mx.google.com with ESMTPSA id zn2sm38561414pbb.41.2014.11.18.11.11.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Nov 2014 11:11:24 -0800 (PST) From: Tyler Baker To: linux-arm-kernel@lists.infradead.org, arm@kernel.org Cc: kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, Tyler Baker Subject: [PATCH] ARM: multi_v7_defconfig: fix failure setting CPU voltage by enabling dependent I2C controller Date: Tue, 18 Nov 2014 11:10:53 -0800 Message-Id: <1416337853-1558-1-git-send-email-tyler.baker@linaro.org> X-Mailer: git-send-email 2.1.3 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes a long standing issue introduced during the 3.16 merge window. Shortly after the merge, exynos5250-based arndale boards began to produce the following errors: kern.err kernel: exynos-cpufreq exynos-cpufreq: failed to set cpu voltage kern.err kernel: cpufreq: __target_index: Failed to change cpu frequency: -22 Further analysis revealed that the S5M8767 voltage regulator used on the exynos5250-based arndale board utilizes the S3C2410 I2C controller. If the S3C2410 I2C controller driver is not enabled, the S5M8767 voltage regulator fails to probe. Therefore a dependency exists between these two drivers. In the exynos_defconfig both CONFIG_REGULATOR_S5M8767 and CONFIG_I2C_S3C2410 options are enabled, and no errors are produced. However, in the multi_v7_defconfig only the CONFIG_REGULATOR_S5M8767 option is enabled and the errors are present. So let's enable the CONFIG_I2C_S3C2410 option in the multi_v7_defconfig to allow the S5M8767 voltage regulator to probe. Signed-off-by: Tyler Baker Acked-by: Kukjin Kim --- This issue was reported [1]. I've also confirmed this fix on two different arndale boards. [1] https://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg38765.html arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 3487046..9d7a32f 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -217,6 +217,7 @@ CONFIG_I2C_CADENCE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_EXYNOS5=y CONFIG_I2C_MV64XXX=y +CONFIG_I2C_S3C2410=y CONFIG_I2C_SIRF=y CONFIG_I2C_TEGRA=y CONFIG_I2C_ST=y