| Message ID | 1422023038-11842-1-git-send-email-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Jaehoon, On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Add sd0_rst node to exynos5420-pinctrl.dtsi. > (It's used on odroid-xu3 board) > It would be good to mention which device needs this pinctrl line. > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 5 +++++ If this pin is used by the Odroid XU3 board, shouldn't be defined in the exynos5422-odroidxu3.dts instead? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2015-01-23 at 15:36 +0100, Javier Martinez Canillas wrote: > Hello Jaehoon, > > On Fri, Jan 23, 2015 at 3:23 PM, Jaehoon Chung <jh80.chung@samsung.com> wrote: > > Add sd0_rst node to exynos5420-pinctrl.dtsi. > > (It's used on odroid-xu3 board) > > > > It would be good to mention which device needs this pinctrl line. > > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > > --- > > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 5 +++++ > > If this pin is used by the Odroid XU3 board, shouldn't be defined in > the exynos5422-odroidxu3.dts instead? It's not just used by the XU3 though, it's also hooked up on the peach pi chromebook for example and i would expect it to be hooked up on most board with an eMMC This change is consistent with most of the special purpose GPIO pins defined in that file, so i don't see the problem with including it in that pinctrl file
On Fri, 2015-01-23 at 23:23 +0900, Jaehoon Chung wrote: > Add sd0_rst node to exynos5420-pinctrl.dtsi. > (It's used on odroid-xu3 board) > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > index ba686e4..315cad7 100644 > --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi > @@ -194,6 +194,11 @@ > samsung,pin-drv = <3>; > }; > > + sd0_rst: sd0-rst { > + samsung,pins = "gpd1-0"; > + samsung,pin-function = <1>; I think this should be samsung,pin-function = <2>; for that functionality.
Hello Sjoerd, On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote: >> >> If this pin is used by the Odroid XU3 board, shouldn't be defined in >> the exynos5422-odroidxu3.dts instead? > > It's not just used by the XU3 though, it's also hooked up on the peach > pi chromebook for example and i would expect it to be hooked up on most > board with an eMMC > > This change is consistent with most of the special purpose GPIO pins > defined in that file, so i don't see the problem with including it in > that pinctrl file In that case I completely agree that it should be defined in the .dtsi but that is not what the commit message said though :-) Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 01/24/2015 12:59 AM, Javier Martinez Canillas wrote: > Hello Sjoerd, > > On Fri, Jan 23, 2015 at 4:47 PM, Sjoerd Simons > <sjoerd.simons@collabora.co.uk> wrote: >>> >>> If this pin is used by the Odroid XU3 board, shouldn't be defined in >>> the exynos5422-odroidxu3.dts instead? >> >> It's not just used by the XU3 though, it's also hooked up on the peach >> pi chromebook for example and i would expect it to be hooked up on most >> board with an eMMC >> >> This change is consistent with most of the special purpose GPIO pins >> defined in that file, so i don't see the problem with including it in >> that pinctrl file > > In that case I completely agree that it should be defined in the .dtsi > but that is not what the commit message said though :-) I will resend the patch with obvious commit message. Thanks for review. Best Regards, Jaehoon Chung > > Best regards, > Javier > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index ba686e4..315cad7 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi @@ -194,6 +194,11 @@ samsung,pin-drv = <3>; }; + sd0_rst: sd0-rst { + samsung,pins = "gpd1-0"; + samsung,pin-function = <1>; + }; + sd1_clk: sd1-clk { samsung,pins = "gpc1-0"; samsung,pin-function = <2>;
Add sd0_rst node to exynos5420-pinctrl.dtsi. (It's used on odroid-xu3 board) Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 5 +++++ 1 file changed, 5 insertions(+)