From patchwork Mon Feb 2 20:58:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 5764101 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id ADBB5BF440 for ; Mon, 2 Feb 2015 21:01:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 410392097B for ; Mon, 2 Feb 2015 21:01:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B75D20977 for ; Mon, 2 Feb 2015 21:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965153AbbBBU7X (ORCPT ); Mon, 2 Feb 2015 15:59:23 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:48867 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965092AbbBBU7U (ORCPT ); Mon, 2 Feb 2015 15:59:20 -0500 Received: by mail-pa0-f47.google.com with SMTP id lj1so86871568pab.6; Mon, 02 Feb 2015 12:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=UhdL3LKSmO8pCSJXLMby7fA6450MnSoBW54SkMpy9qw=; b=JXJne/dQVUfpGfSLhwTkCTcyaIUiovmCw2v2CWEZLujx+rmSFGCVjNyVAogBkrOaTM w8+ZIL59G7yO+XdnI54d1ItjeHSSgTGmDOGytrldwWjaU/MKhv3jjoWkfwi66FcTITNu e54nr8vGOFWOj3AQFS8tbTg4aZTegIk1wqpVTkma3MlkABWVzwyKsI4MR+PlZpb4Aa4j 4ixB7kP83inTuOEl9P5C+Q+VD9RnuqxrvT5xUUIZA2AmAfHoxnhPdbSUrbNJfQhPJMDh LqMZZ6cLH+etrg5au2Xv/fClfEQXER9SoXEOF2lhKkfsnAmy/AyRzQSbW36JU+IfEd7h 9eJQ== X-Received: by 10.66.66.230 with SMTP id i6mr32307807pat.108.1422910760051; Mon, 02 Feb 2015 12:59:20 -0800 (PST) Received: from localhost (amazon.gigabitethernet4-0-6.asr1.snv2.gblx.net. [64.211.110.86]) by mx.google.com with ESMTPSA id k3sm13776882pde.79.2015.02.02.12.59.18 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128/128); Mon, 02 Feb 2015 12:59:18 -0800 (PST) From: Eduardo Valentin To: Linux PM , Viresh Kumar Cc: Eduardo Valentin , "Rafael J. Wysocki" , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/14] cpufreq: exynos5250: use devm_clk_get Date: Mon, 2 Feb 2015 16:58:12 -0400 Message-Id: <1422910697-5920-10-git-send-email-edubezval@gmail.com> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1422910697-5920-1-git-send-email-edubezval@gmail.com> References: <1422910697-5920-1-git-send-email-edubezval@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Switch to managed clk_get to properly release resources when they are not needed. Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Kukjin Kim Cc: linux-pm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Eduardo Valentin --- drivers/cpufreq/exynos5250-cpufreq.c | 24 +++++++++--------------- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/cpufreq/exynos5250-cpufreq.c b/drivers/cpufreq/exynos5250-cpufreq.c index e61d149..d3ce829 100644 --- a/drivers/cpufreq/exynos5250-cpufreq.c +++ b/drivers/cpufreq/exynos5250-cpufreq.c @@ -168,23 +168,23 @@ int exynos5250_cpufreq_init(struct exynos_dvfs_info *info) return -EFAULT; } - cpu_clk = clk_get(NULL, "armclk"); + cpu_clk = devm_clk_get(info->dev, "armclk"); if (IS_ERR(cpu_clk)) - return PTR_ERR(cpu_clk); + goto err; - moutcore = clk_get(NULL, "mout_cpu"); + moutcore = devm_clk_get(info->dev, "mout_cpu"); if (IS_ERR(moutcore)) - goto err_moutcore; + goto err; - mout_mpll = clk_get(NULL, "mout_mpll"); + mout_mpll = devm_clk_get(info->dev, "mout_mpll"); if (IS_ERR(mout_mpll)) - goto err_mout_mpll; + goto err; rate = clk_get_rate(mout_mpll) / 1000; - mout_apll = clk_get(NULL, "mout_apll"); + mout_apll = devm_clk_get(info->dev, "mout_apll"); if (IS_ERR(mout_apll)) - goto err_mout_apll; + goto err; info->mpll_freq_khz = rate; /* 800Mhz */ @@ -199,13 +199,7 @@ int exynos5250_cpufreq_init(struct exynos_dvfs_info *info) return 0; -err_mout_apll: - clk_put(mout_mpll); -err_mout_mpll: - clk_put(moutcore); -err_moutcore: - clk_put(cpu_clk); - +err: iounmap(info->cmu_regs); of_node_put(np); pr_err("%s: failed initialization\n", __func__);