From patchwork Thu Feb 5 07:23:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 5782541 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C9EDCBF6C3 for ; Thu, 5 Feb 2015 07:24:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 051D5201E4 for ; Thu, 5 Feb 2015 07:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16E8F202C8 for ; Thu, 5 Feb 2015 07:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbbBEHXm (ORCPT ); Thu, 5 Feb 2015 02:23:42 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:43086 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754733AbbBEHXk (ORCPT ); Thu, 5 Feb 2015 02:23:40 -0500 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJA00KGLFE2YK90@mailout4.w1.samsung.com>; Thu, 05 Feb 2015 07:27:38 +0000 (GMT) X-AuditID: cbfec7f5-b7fc86d0000066b7-8b-54d319e72379 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 08.DE.26295.7E913D45; Thu, 05 Feb 2015 07:21:11 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NJA00HC4F78PT10@eusync3.samsung.com>; Thu, 05 Feb 2015 07:23:38 +0000 (GMT) From: Krzysztof Kozlowski To: Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pankaj Dubey , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Date: Thu, 05 Feb 2015 08:23:20 +0100 Message-id: <1423121002-25117-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOJMWRmVeSWpSXmKPExsVy+t/xq7rPJS+HGLQtVrXYOGM9q8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72OyuH2Z12LtkbvsFou2fmF34PRoae5h89i0qpPNY/OSeo++ LasYPT5vkgtgjeKySUnNySxLLdK3S+DK6Hj+kqmgS7Di4a43TA2MJ/i6GDk5JARMJP4uvMYO YYtJXLi3nq2LkYtDSGApo8TcozPZIZw+JonVy/ezgVSxCRhLbF6+BKxKRGAzo0R/425WEIdZ 4DCjRN/3eSwgVcICIRK37n1mArFZBFQl7my/AmbzCrhLTHr7hQ1in5zEyWOTWScwci9gZFjF KJpamlxQnJSea6RXnJhbXJqXrpecn7uJERI4X3cwLj1mdYhRgINRiYe3o/diiBBrYllxZe4h RgkOZiURXk2OyyFCvCmJlVWpRfnxRaU5qcWHGJk4OKUaGI9zV9ep5ied1e4RYOLoYzgy2Thi +4vNjB6Xvl3gNn7X8eJ6R9OyWu/XMh4aG1Xlluv5xV0tOXxKILdj5dMz7kn1MQENKQpHRTj3 vWT38pio6aV22Lz4yZw/5U3NDQsN62dZfBM5Ha0yd06ov07AjUSWoH11N6O/555d93DZcn0+ rp6Pd07NU2Ipzkg01GIuKk4EAOPWK6v6AQAA Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs' and 'exynos5420_release_ret_regs' are not exported nor used outside of suspend.c file. Make them static. This fixes following sparse warnings: arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pankaj Dubey --- Changes since v2: None Changes since v1: 1. Add static to 'exynos3250_release_ret_regs' (suggested by Kukjin). --- arch/arm/mach-exynos/suspend.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index 82e6b6fba23f..77cc39bdad47 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -75,7 +75,7 @@ struct exynos_pm_data { int (*cpu_suspend)(unsigned long); }; -struct exynos_pm_data *pm_data; +static struct exynos_pm_data *pm_data; static int exynos5420_cpu_state; static unsigned int exynos_pmu_spare3; @@ -104,7 +104,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = { { /* sentinel */ }, }; -unsigned int exynos_release_ret_regs[] = { +static unsigned int exynos_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -115,7 +115,7 @@ unsigned int exynos_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos3250_release_ret_regs[] = { +static unsigned int exynos3250_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -128,7 +128,7 @@ unsigned int exynos3250_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos5420_release_ret_regs[] = { +static unsigned int exynos5420_release_ret_regs[] = { EXYNOS_PAD_RET_DRAM_OPTION, EXYNOS_PAD_RET_MAUDIO_OPTION, EXYNOS_PAD_RET_JTAG_OPTION,