From patchwork Wed Mar 11 11:08:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 5983451 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4F4A2BF440 for ; Wed, 11 Mar 2015 11:08:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5912920395 for ; Wed, 11 Mar 2015 11:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6120F203AA for ; Wed, 11 Mar 2015 11:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752652AbbCKLIw (ORCPT ); Wed, 11 Mar 2015 07:08:52 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:35125 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbbCKLIv (ORCPT ); Wed, 11 Mar 2015 07:08:51 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NL100DSUOHIFO20@mailout1.w1.samsung.com>; Wed, 11 Mar 2015 11:12:54 +0000 (GMT) X-AuditID: cbfec7f5-b7fc86d0000066b7-eb-550021aa006b Received: from eusync2.samsung.com ( [203.254.199.212]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 07.F4.26295.AA120055; Wed, 11 Mar 2015 11:06:18 +0000 (GMT) Received: from AMDC1943.digital.local ([106.116.151.171]) by eusync2.samsung.com (Oracle Communications Messaging Server 7u4-23.01(7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0NL100G66OAL9560@eusync2.samsung.com>; Wed, 11 Mar 2015 11:08:48 +0000 (GMT) From: Krzysztof Kozlowski To: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Olof Johansson , Marek Szyprowski , Pankaj Dubey , Krzysztof Kozlowski Subject: [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Date: Wed, 11 Mar 2015 12:08:39 +0100 Message-id: <1426072121-6822-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFJMWRmVeSWpSXmKPExsVy+t/xK7qrFBlCDeb80LX4O+kYu8XrF4YW /Y9fM1tsenyN1eLyrjlsFjPO72OyWHvkLrvFqeuf2SwWbf3C7sDp8fvXJEaPTas62Tw2L6n3 uHKiidWjb8sqRo/Pm+QC2KK4bFJSczLLUov07RK4MjY3bGYumCFU0TDrIFsD4xL+LkZODgkB E4nz9+exQthiEhfurWfrYuTiEBJYyihxZc8LdpCEkEAfk0T3RiYQm03AWGLz8iVgRSICXYwS s7b8ZgNJMAucZZSYtMIdxBYWCJG41bMXbCqLgKrEv5d/gZo5OHgF3CRW7AyHWCYncfLYZNYJ jNwLGBlWMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoSEz9cdjEuPWR1iFOBgVOLhvRH9L0SI NbGsuDL3EKMEB7OSCG8fP0OoEG9KYmVValF+fFFpTmrxIUYmDk6pBsa29eJtfaG5Gw9aV386 vuHjkrO3irpFfl4UWP3K6YyEx4JpIRUBd9c4Zy658+CaQHRuxBzvZRE1qx68Cthj/6m97GTc inKFHOXZZ74f/9ISuPpI7vpNH+7dCbacV2x33PJpEkvdzwIN68vfDG8krjITiHxQ5r1rlb86 97aHixdwr4nvnaspUCytxFKckWioxVxUnAgAOo0aJP0BAAA= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs' and 'exynos5420_release_ret_regs' are not exported nor used outside of suspend.c file. Make them static. This fixes following sparse warnings: arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static? arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pankaj Dubey --- Notes: Changes since v3: 1. Add Pankaj's reviewed-by. Changes since v2: None Changes since v1: 1. Add static to 'exynos3250_release_ret_regs' (suggested by Kukjin). arch/arm/mach-exynos/suspend.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index 318d127df147..2fefb7073083 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -75,7 +75,7 @@ struct exynos_pm_data { int (*cpu_suspend)(unsigned long); }; -struct exynos_pm_data *pm_data; +static struct exynos_pm_data *pm_data; static int exynos5420_cpu_state; static unsigned int exynos_pmu_spare3; @@ -104,7 +104,7 @@ static const struct exynos_wkup_irq exynos5250_wkup_irq[] = { { /* sentinel */ }, }; -unsigned int exynos_release_ret_regs[] = { +static unsigned int exynos_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -115,7 +115,7 @@ unsigned int exynos_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos3250_release_ret_regs[] = { +static unsigned int exynos3250_release_ret_regs[] = { S5P_PAD_RET_MAUDIO_OPTION, S5P_PAD_RET_GPIO_OPTION, S5P_PAD_RET_UART_OPTION, @@ -128,7 +128,7 @@ unsigned int exynos3250_release_ret_regs[] = { REG_TABLE_END, }; -unsigned int exynos5420_release_ret_regs[] = { +static unsigned int exynos5420_release_ret_regs[] = { EXYNOS_PAD_RET_DRAM_OPTION, EXYNOS_PAD_RET_MAUDIO_OPTION, EXYNOS_PAD_RET_JTAG_OPTION,