From patchwork Sat Mar 14 08:11:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 6011101 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A5A0EBF90F for ; Sat, 14 Mar 2015 08:16:16 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D555E2020F for ; Sat, 14 Mar 2015 08:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D1F8201FA for ; Sat, 14 Mar 2015 08:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbbCNIML (ORCPT ); Sat, 14 Mar 2015 04:12:11 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:49161 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbbCNIMH (ORCPT ); Sat, 14 Mar 2015 04:12:07 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: javier) with ESMTPSA id 81A4360048B From: Javier Martinez Canillas To: Kukjin Kim Cc: Andrzej Hajda , Marek Szyprowski , Doug Anderson , Olof Johansson , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250 Date: Sat, 14 Mar 2015 09:11:56 +0100 Message-Id: <1426320716-28137-1-git-send-email-javier.martinez@collabora.co.uk> X-Mailer: git-send-email 2.1.4 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP By making the DP controller a consumer of DISP1, the PD is powered off when the exynos-dp probe is deferred and powered on again when the exynos-drm driver is probed. But this causes the exynos-dp driver failing to obtain the stream clock since the FIMD has been powered off with the DISP1 PD: exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok exynos-dp 145b0000.dp-controller: unable to config video The Exynos5250 documentation doesn't mention that the Display Port Transmitter module is included in the DISP1 PD so the device should not have a reference to this Power Domain. This patch fixes video display on an Exynos5250 Snow Chromebook. Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250") Signed-off-by: Javier Martinez Canillas Tested-by: Andreas Färber --- Hello Andrzej and Marek, I need this patch to have display working on an Snow Chromebook with next20150312. I remember testing the mentioned patch that introduced the regression when it was posted and I did not find any issues with it. Do you know what could had caused this behavior change? According to the Exynos5250 documentation I've access to, the modules that are included in the DISP1 power domain are LCD controller (FIMD), MIE1 VP, MIXER, TV Encoder and HDMI so I think this patch is correct since it not only solves the regression but also models the HW better. Please let me know if you think it should be fixed in a different way. Best regards, Javier arch/arm/boot/dts/exynos5250.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index adbde1adad95..ffb505171216 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -775,7 +775,6 @@ }; dp: dp-controller@145B0000 { - power-domains = <&pd_disp1>; clocks = <&clock CLK_DP>; clock-names = "dp"; phys = <&dp_phy>;