From patchwork Mon Jul 6 14:20:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 6724861 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4DAC4C05AC for ; Mon, 6 Jul 2015 14:21:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7B90320584 for ; Mon, 6 Jul 2015 14:21:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91051206CC for ; Mon, 6 Jul 2015 14:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751328AbbGFOVH (ORCPT ); Mon, 6 Jul 2015 10:21:07 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:35565 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753094AbbGFOVG (ORCPT ); Mon, 6 Jul 2015 10:21:06 -0400 Received: by qget71 with SMTP id t71so69542897qge.2 for ; Mon, 06 Jul 2015 07:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EmpGx8byd9CxoWTipTX/O0/pKl3HX7deyur3/zuNy0E=; b=Lj/tHOddP95oAYXsO3gS7VaQYFEb2sLRFIA2h+QuPqNiF+WvIM3sghUNwV5f79jfWJ fdn99cktlMvBn/A6N6sQinaIM1q3ryg9pmK1j+1LYFnzIhHpv40dPN5y51VKtDwImZpz HEQSqAe2/4WM9JzSxQBw/H4ujJwUvJ5yHCDlqdTvgPPcrd9qLEO7QlMFFgUTRyzq0Aho bjTdFetrh9RG7yyuTsrHHsifrnkgispkEeBcTlmUBANMWQ1qSTvwoJz9SPZGXrHkH5dJ MMvZ3SMTWOrl6QpXm9Jba8TpuReiwpa4+UdLQDjHX1MngKkta/Bc9tyN2CLUhqwYta1p 8kwg== X-Received: by 10.55.18.197 with SMTP id 66mr76432596qks.13.1436192465659; Mon, 06 Jul 2015 07:21:05 -0700 (PDT) Received: from jade.localdomain ([191.255.48.48]) by mx.google.com with ESMTPSA id f207sm1707424qhc.41.2015.07.06.07.21.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jul 2015 07:21:05 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com, jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de, Gustavo Padovan Subject: [PATCH v2 11/23] drm/exynos: return return value of exynos_crtc->enable_vblank Date: Mon, 6 Jul 2015 11:20:12 -0300 Message-Id: <1436192424-18194-12-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1436192424-18194-1-git-send-email-gustavo@padovan.org> References: <1436192424-18194-1-git-send-email-gustavo@padovan.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan Instead of blindly ignore the return value of enable_vblank return it to the upper DRM layer for error handling. Suggested-by: Joonyoung Shim Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index e9c291f..9bc2353 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -175,7 +175,7 @@ int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int pipe) return -EPERM; if (exynos_crtc->ops->enable_vblank) - exynos_crtc->ops->enable_vblank(exynos_crtc); + return exynos_crtc->ops->enable_vblank(exynos_crtc); return 0; }