From patchwork Fri Sep 4 20:15:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 7125931 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BF491BEEC1 for ; Fri, 4 Sep 2015 20:16:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5A97B208A9 for ; Fri, 4 Sep 2015 20:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8C0C20895 for ; Fri, 4 Sep 2015 20:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760565AbbIDUQL (ORCPT ); Fri, 4 Sep 2015 16:16:11 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:34098 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760503AbbIDUQK (ORCPT ); Fri, 4 Sep 2015 16:16:10 -0400 Received: by ykdg206 with SMTP id g206so31890245ykd.1 for ; Fri, 04 Sep 2015 13:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9w0He08dfRb0mJr2Hjb1QrA8AzzEcTqgI+n2JWjv/Sc=; b=C3zaqKKtCUu/k7fRa64Nfowbvtst0XuRcMF5jYmVAIzTs0Nn/67TVF+6sgwUSR7PP1 d+TvMpu+ATzC0IdZtJ5sjEjZ+ftOp2On/fItDjZ1pwKjHuDAWKcV5dGZeUb+srsdWzrv uSYePO0ef2hwZ52uobifMQzwWsUHE9NU8db29F91XGS1T9QIgsMvjcAr94AEvVqLVWlZ rAkfSkVlO0yVQBQPf7WlocuCzviIfGScluGmmegtqhuKWItg9qryT+pjKqgqeSQdavMU svlsLzaV3r5qJ+MdsLXPSCYl1+UCYt7dQXUvn0fGs3tVNPBv1/6w7N9Pg5MVdMrJGIKY N4fw== X-Received: by 10.170.142.198 with SMTP id j189mr6570709ykc.54.1441397769977; Fri, 04 Sep 2015 13:16:09 -0700 (PDT) Received: from jade.localdomain ([187.64.235.140]) by smtp.gmail.com with ESMTPSA id w186sm3228710ywf.18.2015.09.04.13.16.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Sep 2015 13:16:09 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com, jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de, Gustavo Padovan Subject: [PATCH 05/10] drm/exynos: remove exynos_crtc commit() callback Date: Fri, 4 Sep 2015 17:15:47 -0300 Message-Id: <1441397752-6672-6-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1441397752-6672-1-git-send-email-gustavo@padovan.org> References: <1441397752-6672-1-git-send-email-gustavo@padovan.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan It turns out that .commit() was never executed, because at the time .mode_set_nofb() called it ctx->suspended was still false and .commit() would return. It removes the callback from FIMD DECON 7 and DECON 5433. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 2697ebc..0bbe537 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -888,7 +888,6 @@ static const struct exynos_drm_crtc_ops fimd_crtc_ops = { .enable = fimd_enable, .disable = fimd_disable, .mode_fixup = fimd_mode_fixup, - .commit = fimd_commit, .enable_vblank = fimd_enable_vblank, .disable_vblank = fimd_disable_vblank, .wait_for_vblank = fimd_wait_for_vblank,