From patchwork Tue Sep 29 20:59:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 7290351 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2FDC9BEEA4 for ; Tue, 29 Sep 2015 20:59:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5686C20688 for ; Tue, 29 Sep 2015 20:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EAD12068D for ; Tue, 29 Sep 2015 20:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752542AbbI2U7k (ORCPT ); Tue, 29 Sep 2015 16:59:40 -0400 Received: from mail-yk0-f172.google.com ([209.85.160.172]:33909 "EHLO mail-yk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752432AbbI2U73 (ORCPT ); Tue, 29 Sep 2015 16:59:29 -0400 Received: by ykdg206 with SMTP id g206so19994014ykd.1 for ; Tue, 29 Sep 2015 13:59:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/XIwKUhBsxGdn2SnunywyHmapdgDmpFBKorkF/eD1fI=; b=DAQhOTEqJUtYC+aIHGM7fsQW6mlFlWuEXqUFku4qgX+TJNA36Er+15KPE4tlSTLrWW 72b1vLIBMYQDIwRFbrKBw8afourmhK7ZWtSFgECbb0ToMgayge38ezMl+Y2Ww61Oi08i dAPk8QFIj9qxINQ437KAE5DiX44BHP45qhNguE6zglqeeQUb1z8d1Y+7AcXu3/F0Vq7b Wyy9sKgsqbr3ofBcEEvHLtUxzf384ZFpUG7IzU6drUZs5NABogo6hoBiPqh9Pnwu8End 7VurnA+GJNyQrOJGD9kxOjpyd85RbAXHoJCe6NhyVSELFlNZOaZr/3ohZ0bLZKa8u/B7 8Gvg== X-Received: by 10.13.211.135 with SMTP id v129mr19008ywd.129.1443560368675; Tue, 29 Sep 2015 13:59:28 -0700 (PDT) Received: from jade.localdomain ([187.64.235.140]) by smtp.gmail.com with ESMTPSA id f65sm3181392ywe.45.2015.09.29.13.59.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Sep 2015 13:59:28 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, inki.dae@samsung.com, jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de, Gustavo Padovan Subject: [PATCH 2/3] drm/exynos: remove decon_mode_fixup() Date: Tue, 29 Sep 2015 17:59:18 -0300 Message-Id: <1443560359-4389-2-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1443560359-4389-1-git-send-email-gustavo@padovan.org> References: <1443560359-4389-1-git-send-email-gustavo@padovan.org> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan The only thing mode_fixup was doing was set the adjusted_mode->vrefresh to 60, but it already has the value of 60 when the decon_mode_fixup() is called. That means this call is actually pointless and can be removed. Signed-off-by: Gustavo Padovan --- This is untested as I don't have any decon device, but I assume the behaviour is similar to FIMD and it that case, I'm proposing the the removal in decon_mode_fixup() as well. --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c index cbdb78e..e6cbaca 100644 --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c @@ -37,7 +37,6 @@ * DECON stands for Display and Enhancement controller. */ -#define DECON_DEFAULT_FRAMERATE 60 #define MIN_FB_WIDTH_FOR_16WORD_BURST 128 #define WINDOWS_NR 2 @@ -165,16 +164,6 @@ static u32 decon_calc_clkdiv(struct decon_context *ctx, return (clkdiv < 0x100) ? clkdiv : 0xff; } -static bool decon_mode_fixup(struct exynos_drm_crtc *crtc, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - if (adjusted_mode->vrefresh == 0) - adjusted_mode->vrefresh = DECON_DEFAULT_FRAMERATE; - - return true; -} - static void decon_commit(struct exynos_drm_crtc *crtc) { struct decon_context *ctx = crtc->ctx; @@ -637,7 +626,6 @@ static void decon_disable(struct exynos_drm_crtc *crtc) static const struct exynos_drm_crtc_ops decon_crtc_ops = { .enable = decon_enable, .disable = decon_disable, - .mode_fixup = decon_mode_fixup, .commit = decon_commit, .enable_vblank = decon_enable_vblank, .disable_vblank = decon_disable_vblank,