From patchwork Fri Jan 29 14:50:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 8164121 Return-Path: X-Original-To: patchwork-linux-samsung-soc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 04BA8BEEE5 for ; Fri, 29 Jan 2016 14:53:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 33F512038E for ; Fri, 29 Jan 2016 14:53:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4391D20382 for ; Fri, 29 Jan 2016 14:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756393AbcA2Ovi (ORCPT ); Fri, 29 Jan 2016 09:51:38 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:51077 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756305AbcA2Ove (ORCPT ); Fri, 29 Jan 2016 09:51:34 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPA (Nemesis) id 0LfikE-1Zitp91sza-00pM8b; Fri, 29 Jan 2016 15:51:01 +0100 From: Arnd Bergmann To: linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Kukjin Kim , Krzysztof Kozlowski , linux-kernel@vger.kernel.org Subject: [PATCH 1/6] ARM: s3c24xx: don't select EEPROM_AT24 Date: Fri, 29 Jan 2016 15:50:33 +0100 Message-Id: <1454079040-3567945-2-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1454079040-3567945-1-git-send-email-arnd@arndb.de> References: <1454079040-3567945-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:WceVxc/kFXRmppagcIJTpynffpJRC/kBjFcjQDoj22EyDTOpDsa E7x7n33eNIvZftKsKnT/ZqFkjsrRx1Ur8vIVMTVXjYqyh+i0oi1h+o5xgf00h3QYR9O8SND hxZqjXJrLnKUjwCEnnZCUl8tUkc58x5QZNgZHcfDwA9VMPyw3NhRsLwCWSHVL2tPFejtnEs 6U0Zr5OG7taO6Xu1Y33/Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:syWQyBQgysI=:2tETZ/dnZVvsnYFUQsdtBB GO1vdfIlJcbyWvbI0IUnviYvQMPfm1TxwxqjdzsXGqx75yrlOP+DXzBVc/eW3XL5Kv533KEVa KBQf9V0aUFz+AYQaiJIcdbowWMrlaazx12F3BtUs4ZJHrnnESYES4pRxKQ5Z4dY0vtC5DXzH+ kqRCP6vcTKy3HWnTmoWfudApRDjBnxoTJ+gLnG0mW8G2o+0BWkMlMjVt/Lkx1S+bFRuHhZSl8 mKSqtF130Mi0cyUivPOadTQJFlrkS1kJJT2HyUccTE8vcxIkMpfBajHPfOCfsdGiI8cuo1Lmi OpLCY1F0NnpakyP+SZTUvSrS/opcUtGPMfhQXwCGDk1Am97iAjWbccKWEkW8UWpR77hiMHvT3 fUH7q+BBbEGl3/Zsgh1cQMUCjtPFmd7YELh4gbSWf71VJoTrv0isUjzYcgqWTN6MyiaEVAkPf iQki63ox5bjdIut4/vzCR4ZCqZQPNxyGtBkzKcCJ7F2FYG8jCMjzT+HRfgxgMB4tUOlFeN8A6 aLS3xSDSm+OuNlTLNStxVNGlG1t1nrLwnzPHvVTh+1urP3rM57OX1kbGn95XVAvvR9kyI7bNu 1F6D/UcyhQjsje2u/GSAtt/ayOuJBqANdyWrC/fRzvcOkiIkUm6QGYx2Lz1XYwkp/YHEXIRon y1sOh2CX8831NDkp3Vz5Nkqk8UuQbkMhWudo0Zmmgr06SILBOV8EpsN4xOnQzBkxIZI8= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP EEPROM_AT24 depends on both I2C and SYSFS. We have in the past added I2C 'select' statements to avoid build problems with the first, but we still get a warning because of the second: warning: (MACH_DAVINCI_EVM && MACH_SFFSDR && MACH_DAVINCI_DM6467_EVM && MACH_DAVINCI_DM365_EVM && MACH_DAVINCI_DA830_EVM && MACH_MITYOMAPL138 && MACH_MINI2440) selects EEPROM_AT24 which has unmet direct dependencies (I2C && SYSFS) This removes the 'select' statements again, and forces users to enable the driver in their configuration files, as we do for most other drivers. Signed-off-by: Arnd Bergmann Reviewed-by: Krzysztof Kozlowski --- arch/arm/configs/mini2440_defconfig | 1 + arch/arm/configs/s3c2410_defconfig | 1 + arch/arm/mach-s3c24xx/Kconfig | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/mini2440_defconfig b/arch/arm/configs/mini2440_defconfig index 9c93f5655248..0b02e4f43c6a 100644 --- a/arch/arm/configs/mini2440_defconfig +++ b/arch/arm/configs/mini2440_defconfig @@ -158,6 +158,7 @@ CONFIG_I2C=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_S3C2410=y CONFIG_I2C_SIMTEC=y +CONFIG_EEPROM_AT24=y CONFIG_SPI=y CONFIG_SPI_S3C24XX=y CONFIG_SPI_SPIDEV=y diff --git a/arch/arm/configs/s3c2410_defconfig b/arch/arm/configs/s3c2410_defconfig index f3142369f594..b3ade552a2a5 100644 --- a/arch/arm/configs/s3c2410_defconfig +++ b/arch/arm/configs/s3c2410_defconfig @@ -290,6 +290,7 @@ CONFIG_HW_RANDOM=y CONFIG_I2C_CHARDEV=m CONFIG_I2C_S3C2410=y CONFIG_I2C_SIMTEC=y +CONFIG_EEPROM_AT24=y CONFIG_SPI=y CONFIG_SPI_GPIO=m CONFIG_SPI_S3C24XX=m diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index ef68ecb27396..c94ef77405ed 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -460,7 +460,6 @@ config MACH_AT2440EVB config MACH_MINI2440 bool "MINI2440 development board" - select EEPROM_AT24 if I2C select LEDS_CLASS select LEDS_TRIGGERS select LEDS_TRIGGER_BACKLIGHT