diff mbox

i2c: s3c2410: fix indentation for better readability

Message ID 1461533338-17479-1-git-send-email-wsa@the-dreams.de (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Wolfram Sang April 24, 2016, 9:28 p.m. UTC
smatch rightfully says:

drivers/i2c/busses/i2c-s3c2410.c:1217 s3c24xx_i2c_probe() warn: inconsistent indenting

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski April 25, 2016, 8:55 a.m. UTC | #1
On 04/24/2016 11:28 PM, Wolfram Sang wrote:
> smatch rightfully says:
> 
> drivers/i2c/busses/i2c-s3c2410.c:1217 s3c24xx_i2c_probe() warn: inconsistent indenting
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  drivers/i2c/busses/i2c-s3c2410.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Hi,

You could just apply this one:
i2c: s3c2410: Cleanup indentation and comment style
https://lkml.org/lkml/2016/4/20/163

I fixed this in that patch. Its trivial so it does not have to be a
separate patch.

Best regards,
Krzysztof

> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index 1bc756313cb8e4..315c88ea1fa153 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -1214,8 +1214,8 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev)
>  			return ret;
>  		}
>  
> -	ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> -				dev_name(&pdev->dev), i2c);
> +		ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
> +				       dev_name(&pdev->dev), i2c);
>  
>  		if (ret != 0) {
>  			dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
index 1bc756313cb8e4..315c88ea1fa153 100644
--- a/drivers/i2c/busses/i2c-s3c2410.c
+++ b/drivers/i2c/busses/i2c-s3c2410.c
@@ -1214,8 +1214,8 @@  static int s3c24xx_i2c_probe(struct platform_device *pdev)
 			return ret;
 		}
 
-	ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
-				dev_name(&pdev->dev), i2c);
+		ret = devm_request_irq(&pdev->dev, i2c->irq, s3c24xx_i2c_irq, 0,
+				       dev_name(&pdev->dev), i2c);
 
 		if (ret != 0) {
 			dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq);