diff mbox

[v3,3/3] ARM: dts: exynos: Lower SD card interface voltage to 2.8 V on Odroid X/X2/U3

Message ID 1462365840-27406-3-git-send-email-k.kozlowski@samsung.com (mailing list archive)
State Accepted
Headers show

Commit Message

Krzysztof Kozlowski May 4, 2016, 12:44 p.m. UTC
Odroid X/X2/U3 schematics say that SD card vmmc regulator
(LDO21/TFLASH) operates on 2.8 V. Mainline U-Boot uses that value as
well and 2.8 V is common on Exynos-based boards. Additionally use some
descriptive name for this regulator.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---
Changes since v2:
1. Add Javier's tag.

Changes since v1:
1. None
---
 arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Javier Martinez Canillas May 4, 2016, 12:51 p.m. UTC | #1
Hello Krzysztof,

On 05/04/2016 08:44 AM, Krzysztof Kozlowski wrote:
> Odroid X/X2/U3 schematics say that SD card vmmc regulator
> (LDO21/TFLASH) operates on 2.8 V. Mainline U-Boot uses that value as
> well and 2.8 V is common on Exynos-based boards. Additionally use some
> descriptive name for this regulator.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> Changes since v2:
> 1. Add Javier's tag.
> 

It's missing though :)

Adding the tag again so it can be picked by patchwork:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Krzysztof Kozlowski May 4, 2016, 1:06 p.m. UTC | #2
On 05/04/2016 02:51 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 05/04/2016 08:44 AM, Krzysztof Kozlowski wrote:
>> Odroid X/X2/U3 schematics say that SD card vmmc regulator
>> (LDO21/TFLASH) operates on 2.8 V. Mainline U-Boot uses that value as
>> well and 2.8 V is common on Exynos-based boards. Additionally use some
>> descriptive name for this regulator.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> ---
>> Changes since v2:
>> 1. Add Javier's tag.
>>
> 
> It's missing though :)
> 
> Adding the tag again so it can be picked by patchwork:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

D'oh!

Thanks for spotting,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 7485ce8a6fb3..14e653e32e0f 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -341,9 +341,9 @@ 
 			};
 
 			ldo21_reg: LDO21 {
-				regulator-name = "LDO21_3.3V";
-				regulator-min-microvolt = <3300000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-name = "TFLASH_2.8V";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
 				regulator-boot-on;
 			};