From patchwork Thu Jun 2 14:20:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 9150099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 07E1160751 for ; Thu, 2 Jun 2016 14:20:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ECD5928047 for ; Thu, 2 Jun 2016 14:20:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1A89282E8; Thu, 2 Jun 2016 14:20:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A5E4C28047 for ; Thu, 2 Jun 2016 14:20:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161312AbcFBOU2 (ORCPT ); Thu, 2 Jun 2016 10:20:28 -0400 Received: from lists.s-osg.org ([54.187.51.154]:39602 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161283AbcFBOU1 (ORCPT ); Thu, 2 Jun 2016 10:20:27 -0400 Received: from minerva.sisa.samsung.com (host-165.58.217.201.copaco.com.py [201.217.58.165]) by lists.s-osg.org (Postfix) with ESMTPSA id 5A175E27BD; Thu, 2 Jun 2016 07:21:01 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Marc Zyngier , Javier Martinez Canillas , Kukjin Kim , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Inki Dae , linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org Subject: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 Date: Thu, 2 Jun 2016 10:20:10 -0400 Message-Id: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.5.5 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added hardware trigger support to the FIMD controller driver. But this broke the display in at least the Exynos5800 Peach Pi Chromebook. So until the issue is fixed, avoid using HW trigger for the Exynos5420 based boards and use SW trigger as it was before the mentioned commit. Signed-off-by: Javier Martinez Canillas --- Hello Inki, Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be picked to make sure that v4.7 is released with the display working for the Exynos5420 based Chromebooks. We can then figure out what's wrong with the HW trigger support and fix it for v4.8. Best regards, Javier drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 1c23a8ff5e83..f10030ff00e6 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { .lcdblk_vt_shift = 24, .lcdblk_bypass_shift = 15, .lcdblk_mic_bypass_shift = 11, - .trg_type = I80_HW_TRG, .has_shadowcon = 1, .has_vidoutcon = 1, .has_vtsel = 1, .has_mic_bypass = 1, .has_dp_clk = 1, - .has_hw_trigger = 1, - .has_trigger_per_te = 1, }; struct fimd_context {