| Message ID | 1466000018-16784-6-git-send-email-ldewangan@nvidia.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello Laxman, On 06/15/2016 10:13 AM, Laxman Dewangan wrote: > The clock driver used by Maxim PMIC MAX77802 is clk-max77686 > which can be enabled with config CONFIG_COMMON_CLK_MAX77686. > > Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > CC: Javier Martinez Canillas <javier@dowhile0.org> > --- > arch/arm/configs/exynos_defconfig | 1 - > arch/arm/configs/multi_v7_defconfig | 1 - Please split these two changes in separate patches, there are just cleanups needed after 1/5 and they can be picked separately. The change looks good to me though so feel free to add: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote: > Hello Laxman, > > On 06/15/2016 10:13 AM, Laxman Dewangan wrote: >> The clock driver used by Maxim PMIC MAX77802 is clk-max77686 >> which can be enabled with config CONFIG_COMMON_CLK_MAX77686. >> >> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. >> >> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> >> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> CC: Javier Martinez Canillas <javier@dowhile0.org> >> --- >> arch/arm/configs/exynos_defconfig | 1 - >> arch/arm/configs/multi_v7_defconfig | 1 - > > Please split these two changes in separate patches, there are just > cleanups needed after 1/5 and they can be picked separately. Not entirely separately. If we do not want to loose max77802 clocks on defconfigs, then it should go with the same tree or after driver get merged. I prefer the latter, similar case to 1898994229f8 ("ARM: multi_v7_defconfig: Switch max77693 to module"). Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Krzysztof, On 06/16/2016 08:25 AM, Krzysztof Kozlowski wrote: > On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote: >> Hello Laxman, >> >> On 06/15/2016 10:13 AM, Laxman Dewangan wrote: >>> The clock driver used by Maxim PMIC MAX77802 is clk-max77686 >>> which can be enabled with config CONFIG_COMMON_CLK_MAX77686. >>> >>> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. >>> >>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> >>> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> CC: Javier Martinez Canillas <javier@dowhile0.org> >>> --- >>> arch/arm/configs/exynos_defconfig | 1 - >>> arch/arm/configs/multi_v7_defconfig | 1 - >> >> Please split these two changes in separate patches, there are just >> cleanups needed after 1/5 and they can be picked separately. > > Not entirely separately. If we do not want to loose max77802 clocks on > defconfigs, then it should go with the same tree or after driver get > merged. I prefer the latter, similar case to 1898994229f8 ("ARM: > multi_v7_defconfig: Switch max77693 to module"). > Agreed. Your latter example is what I tried to say (that can be picked as cleanups separately once 1/5 hits mainline). I just didn't express clearly. > Best regards, > Krzysztof > Best regards,
On Thursday 16 June 2016 06:36 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 06/16/2016 08:25 AM, Krzysztof Kozlowski wrote: >> On 06/15/2016 05:39 PM, Javier Martinez Canillas wrote: >>> Hello Laxman, >>> >>> On 06/15/2016 10:13 AM, Laxman Dewangan wrote: >>>> The clock driver used by Maxim PMIC MAX77802 is clk-max77686 >>>> which can be enabled with config CONFIG_COMMON_CLK_MAX77686. >>>> >>>> Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. >>>> >>>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> >>>> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>>> CC: Javier Martinez Canillas <javier@dowhile0.org> >>>> --- >>>> arch/arm/configs/exynos_defconfig | 1 - >>>> arch/arm/configs/multi_v7_defconfig | 1 - >>> Please split these two changes in separate patches, there are just >>> cleanups needed after 1/5 and they can be picked separately. >> Not entirely separately. If we do not want to loose max77802 clocks on >> defconfigs, then it should go with the same tree or after driver get >> merged. I prefer the latter, similar case to 1898994229f8 ("ARM: >> multi_v7_defconfig: Switch max77693 to module"). >> > Agreed. Your latter example is what I tried to say (that can be picked > as cleanups separately once 1/5 hits mainline). I just didn't express > clearly. > > OK, I will drop this from series when will send V2. The changes can be done later on once clock changes get merged. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index daf9762..cfd75c7 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -216,7 +216,6 @@ CONFIG_DMADEVICES=y CONFIG_PL330_DMA=y CONFIG_CROS_EC_CHARDEV=y CONFIG_COMMON_CLK_MAX77686=y -CONFIG_COMMON_CLK_MAX77802=y CONFIG_COMMON_CLK_S2MPS11=y CONFIG_EXTCON=y CONFIG_EXTCON_MAX14577=y diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index ee7c884..7cbf389 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -787,7 +787,6 @@ CONFIG_CHROME_PLATFORMS=y CONFIG_STAGING_BOARD=y CONFIG_CROS_EC_CHARDEV=m CONFIG_COMMON_CLK_MAX77686=y -CONFIG_COMMON_CLK_MAX77802=m CONFIG_COMMON_CLK_RK808=m CONFIG_COMMON_CLK_S2MPS11=m CONFIG_APQ_MMCC_8084=y
The clock driver used by Maxim PMIC MAX77802 is clk-max77686 which can be enabled with config CONFIG_COMMON_CLK_MAX77686. Hence the config CONFIG_COMMON_CLK_MAX77802 is not required. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> CC: Javier Martinez Canillas <javier@dowhile0.org> --- arch/arm/configs/exynos_defconfig | 1 - arch/arm/configs/multi_v7_defconfig | 1 - 2 files changed, 2 deletions(-)