From patchwork Fri Jul 15 08:12:49 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 9231291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F233C60574 for ; Fri, 15 Jul 2016 08:13:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2BB22522B for ; Fri, 15 Jul 2016 08:13:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D652F28304; Fri, 15 Jul 2016 08:13:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A0C92522B for ; Fri, 15 Jul 2016 08:13:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751172AbcGOINN (ORCPT ); Fri, 15 Jul 2016 04:13:13 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:45610 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbcGOINH (ORCPT ); Fri, 15 Jul 2016 04:13:07 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OAC000OJK5R8F10@mailout3.w1.samsung.com>; Fri, 15 Jul 2016 09:13:03 +0100 (BST) X-AuditID: cbfec7f4-f796c6d000001486-8c-57889b0f7933 Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id E6.22.05254.F0B98875; Fri, 15 Jul 2016 09:13:03 +0100 (BST) Received: from AMDC2174.DIGITAL.local ([106.120.53.17]) by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OAC007B0K5NRJ60@eusync4.samsung.com>; Fri, 15 Jul 2016 09:13:03 +0100 (BST) From: Krzysztof Kozlowski To: Kukjin Kim , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, alim.akhtar@samsung.com Cc: Bartlomiej Zolnierkiewicz Subject: [PATCH v2] ARM: dts: exynos: Properly select eMMC HighSpeed mode on Odroid XU Date: Fri, 15 Jul 2016 10:12:49 +0200 Message-id: <1468570369-14355-1-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNJMWRmVeSWpSXmKPExsVy+t/xa7r8szvCDU49VLF4MG8bm8XGGetZ LeYfOcdq8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mBw4PDat6mTz2Lyk3qNvyypGj8+b5AJY orhsUlJzMstSi/TtErgy1v3YxVzwiqfiy6NFLA2Md7m6GDk5JARMJHpbrrND2GISF+6tZ+ti 5OIQEljKKHFx1W5mCKeRSeL+c5AMJwebgLHE5uVLwKpEBD4xSpw628cMkmAWsJDYunU12Chh gQiJljXLGEFsFgFVicbP38FsXgF3iZOvX0Otk5M4eWwy6wRG7gWMDKsYRVNLkwuKk9JzDfWK E3OLS/PS9ZLzczcxQoLkyw7GxcesDjEKcDAq8fAKHG0PF2JNLCuuzD3EKMHBrCTCu3NqR7gQ b0piZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGB3/XlLkmhY3 s+cCwwS5q5tVmZb9Tl5+4EiehNeT67P9569NLvX4Mzc8+cTyNW1By/dpTH5j+msu056lhzZq 3WfwVWXccSdxMnOTSlJVN/uUZVNCRHlaw2cqq5nLTwzcfOnfTaWbhuYrOr31OKVm8d+7Yv11 2YHAxS8OvHijurogxMr2l7jgz79KLMUZiYZazEXFiQBBSzKXDgIAAA== Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Exynos5410 supports eMMC version 4.41 so HS200 is the top mode which should be configured. This is reflected in usage of "samsung,exynos5250-dw-mshc" compatible. However Odroid XU DTS contained also property "mmc-hs400-1_8v" which is parsed by MMC core therefore resulting in mixed configuration. MMC core set HS400 but dwmmc_exynos driver did not configure the data strobe for HS400 DDR mode. Removal of HS400 properties fixes semi-random mmc errors during boot: mmc_host mmc0: Bus speed (slot 0) = 400000000Hz (slot req 200000000Hz, actual 200000000HZ div = 1) mmc0: mmc_select_hs400 failed, error -84 mmc0: error -84 whilst initialising MMC card Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alim Akhtar --- Changes since v1: 1. Remove also samsung,read-strobe-delay, suggested by Alim Akhtar. --- arch/arm/boot/dts/exynos5410-odroidxu.dts | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index d9499310a301..f6d135245a4b 100644 --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts @@ -447,14 +447,11 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; - samsung,dw-mshc-hs400-timing = <0 2>; - samsung,read-strobe-delay = <90>; pinctrl-names = "default"; pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus1 &sd0_bus4 &sd0_bus8 &sd0_cd>; bus-width = <8>; cap-mmc-highspeed; mmc-hs200-1_8v; - mmc-hs400-1_8v; vmmc-supply = <&ldo20_reg>; vqmmc-supply = <&ldo11_reg>; };