diff mbox

ARM: exynos_defconfig: Enable PM_DEBUG

Message ID 1468926554-22204-1-git-send-email-k.kozlowski@samsung.com (mailing list archive)
State Accepted
Headers show

Commit Message

Krzysztof Kozlowski July 19, 2016, 11:09 a.m. UTC
PM_DEBUG and PM_ADVANCED_DEBUG bring some information useful for
development and they should not cause any significant overhead.  Enable
them in default configuration so debugging would be slightly easier.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/configs/exynos_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Javier Martinez Canillas July 19, 2016, 2:49 p.m. UTC | #1
Hello Krzysztof,

On 07/19/2016 07:09 AM, Krzysztof Kozlowski wrote:
> PM_DEBUG and PM_ADVANCED_DEBUG bring some information useful for
> development and they should not cause any significant overhead.  Enable
> them in default configuration so debugging would be slightly easier.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---

I agree that it's good to have these enabled to make debugging easier.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
kgene@kernel.org July 20, 2016, 1:58 p.m. UTC | #2
On 07/19/16 23:49, Javier Martinez Canillas wrote:
> Hello Krzysztof,
> 
> On 07/19/2016 07:09 AM, Krzysztof Kozlowski wrote:
>> PM_DEBUG and PM_ADVANCED_DEBUG bring some information useful for
>> development and they should not cause any significant overhead.  Enable
>> them in default configuration so debugging would be slightly easier.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
> 
> I agree that it's good to have these enabled to make debugging easier.
> 
I'm back ;-)

I agreed...so,
Acked-by: Kukjin Kim <kgene@kernel.org>

BTW, I have not seen the kernel log with PM_ADVANCED_DEBUG. Can anyone
show me the log?...to be honest I need to setup the dev. environment on
my desk at this moment...

Thanks,
Kukjin

> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index a5aa44c56bfe..d7366891e9cf 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -35,6 +35,8 @@  CONFIG_ARM_EXYNOS_CPUIDLE=y
 CONFIG_VFP=y
 CONFIG_NEON=y
 CONFIG_KERNEL_MODE_NEON=y
+CONFIG_PM_DEBUG=y
+CONFIG_PM_ADVANCED_DEBUG=y
 CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y