From patchwork Wed Aug 24 13:07:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milo Kim X-Patchwork-Id: 9297745 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 66A8960757 for ; Wed, 24 Aug 2016 13:27:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 57C9F28FD9 for ; Wed, 24 Aug 2016 13:27:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C6BA28FEA; Wed, 24 Aug 2016 13:27:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A31428FD9 for ; Wed, 24 Aug 2016 13:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753737AbcHXN0l (ORCPT ); Wed, 24 Aug 2016 09:26:41 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:36029 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753563AbcHXN0k (ORCPT ); Wed, 24 Aug 2016 09:26:40 -0400 Received: by mail-pa0-f65.google.com with SMTP id ez1so1206239pab.3; Wed, 24 Aug 2016 06:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yJ3bsy19L0ee5Ipd1RKCAvlk5YhOChzeF+dz6lTJ2HQ=; b=cvPpO//5kcChjC2AiyB/UsRp93pzPRb30ZHLnuf2dY+sFLfdPO1Y3gXVhHTm34Nunv HK2Us6i7DIWzL1+O2MRv3UwvhMsQbXdu1BS/2622h1opbxMV7536cvtvboZaC2Zqj+JF IjZu1eaTbx3bm6ao+ABs5VwodR2uX1fRAW1y4inQy9OKBbdef2v8A6K0AV9ziVLsAHm9 BarYVQ7fcu/Nt9V0cfLuPa7b9v2POc0CNytsEjIBVygZVtpXz4b52JfpH/hi0JXUjGZt crf9kwOgrsAxyAC6ldk+tFOq+Wu67eVx45ibwgw6hSDZ3uRcU84ORea/Vif4zq7ECrK2 YYOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yJ3bsy19L0ee5Ipd1RKCAvlk5YhOChzeF+dz6lTJ2HQ=; b=iCeC12Abqc8vFEhBmNSXNxXFZSirvXFeXAphg+Z9tkyhrisRidfxKog1UvvgR5uG8L Tt1gTolSpqOTZM/JJ4tlEmzIlzVewURx1iMYrtztLwrHWXgRmAcl+TBlEN0OlTae0d5s voNAABgOHb0un1QycPmlqnTUTDUlU9bT9MuV7DJVcfeD7goZ1LTBSA3NER5cNmQ9KcjN otvEQ12hwHALqSvf6fr8/GCgXGYpKoHR9GNa9Vtm/u5vMrm2Pp9RZyg/MyogmFW6+gL2 FGvwG314EA2hAUB0R4yTCTUBFOBUwfY2WuMBRI/eYvS4SuFqNyAdgoXFb0ChpVqDsBwS yDpA== X-Gm-Message-State: AE9vXwOTW8rtaxIoRwRJjzQCQmlK6wZN8SKFjECZcaq6Dd9QCyn4iz4J4hZeXVbb2Ul0iQ== X-Received: by 10.66.145.73 with SMTP id ss9mr5565661pab.82.1472044123925; Wed, 24 Aug 2016 06:08:43 -0700 (PDT) Received: from milo-dev.kornet ([61.77.30.12]) by smtp.gmail.com with ESMTPSA id h125sm13689199pfg.54.2016.08.24.06.08.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Aug 2016 06:08:43 -0700 (PDT) From: Milo Kim To: Kukjin Kim , Krzysztof Kozlowski , David Airlie Cc: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Milo Kim Subject: [PATCH v3 5/5] gpu: drm: exynos_hdmi: Remove duplicate initialization of regulator bulk consumer Date: Wed, 24 Aug 2016 22:07:19 +0900 Message-Id: <1472044039-16536-6-git-send-email-woogyom.kim@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1472044039-16536-1-git-send-email-woogyom.kim@gmail.com> References: <1472044039-16536-1-git-send-email-woogyom.kim@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The helper, devm_regulator_bulk_get() initializes the consumer as NULL, so this code can be ignored. Cc: Kukjin Kim Cc: Krzysztof Kozlowski Cc: David Airlie Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Milo Kim Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_hdmi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 249cb23..4e17877f 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -1669,10 +1669,9 @@ static int hdmi_resources_init(struct hdmi_context *hdata) if (ret) return ret; - for (i = 0; i < ARRAY_SIZE(supply); ++i) { + for (i = 0; i < ARRAY_SIZE(supply); ++i) hdata->regul_bulk[i].supply = supply[i]; - hdata->regul_bulk[i].consumer = NULL; - } + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(supply), hdata->regul_bulk); if (ret) { if (ret != -EPROBE_DEFER)